[Gptfdisk-general] GPTPart::GetDescription broken in 1.0.7 on Big Endian systems

[Christian E. <chr...@ca...>]

Hi,
I wanted to let you know that the recent try to fix big endian byte
swapping is actually breaking big endian in 1.0.7.

This is broken on s390x (=big endian) in Debian [1] and Ubuntu [2].

When you look at just these logs it seems it is just failing for no
apparent reason,
but with -x enabled in gdisk_test.sh one quickly sees there is some
string-mangling happening:

Number  Start (sector)    End (sector)  Size       Code  Name
   1            2048          131038   63.0 MiB    8300  䰀椀渀甀砀 昀椀氀攀猀礀猀琀攀洀

Reading the very same file with the old gdisk is good - so likely the
on-dis content is good as well:
Number  Start (sector)    End (sector)  Size       Code  Name
   1            2048          131038   63.0 MiB    8300  Linux filesystem

This is caused by GPTPart::GetDescription due to this change [3] in 1.0.7

Reverting this fixes change fixes the problem.

[1]: https://buildd.debian.org/status/fetch.php?pkg=gdisk&arch=s390x&ver=1.0.7-1&stamp=1617791278&raw=0
[2]: https://launchpadlibrarian.net/540613637/buildlog_ubuntu-impish-s390x.gdisk_1.0.7-1_BUILDING.txt.gz
[3]: https://sourceforge.net/p/gptfdisk/code/ci/86dd5fea351a5a55bea26b7622eb85ebd6075a60/

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd