Re: [Gptfdisk-general] [PATCH] Fix creating of two 0xEE partitions in hybrid MBR

[Rod S. <rod...@ro...>]

On 06/15/2012 01:15 PM, Kirill Elagin wrote:
> This makes gfdisk create two protective EFI GPT partitions with
> eeFirst='N' if user hybridized less than three partitions.

Thanks for the patch; however, all it does according to my reading of 
the code and in my tests is to change the partition number of the 0xEE 
partition from partition 4 to the lowest-available partition number when 
the user opts to not place 0xEE first in the table. AFAIK, this is an 
irrelevant detail. If you can point out a problem caused by the original 
code, I'll consider including your patch, but if not, I'll stick with 
the current code.

> ---
>   gpttext.cc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gpttext.cc b/gpttext.cc
> index 506c0f1..474b23b 100644
> --- a/gpttext.cc
> +++ b/gpttext.cc
> @@ -452,7 +452,7 @@ void GPTDataTextUI::MakeHybrid(void) {
>         if (eeFirst == 'Y') {
>            hybridMBR.AddPart(0, hybridPart);
>         } else {
> -         hybridMBR.AddPart(3, hybridPart);
> +         hybridMBR.AddPart(numPartsToCvt, hybridPart);
>         } // else
>         hybridMBR.SetHybrid();
>


-- 
Rod Smith
rod...@ro...
http://www.rodsbooks.com