gptfdisk-general Mailing List for GPT fdisk (Page 2)

Brought to you by: srs5694

gptfdisk-general — General discussions of GPT fdisk

You can subscribe to this list here.

2011	Jan	Feb	Mar (3)	Apr	May	Jun	Jul (1)	Aug (5)	Sep (1)	Oct (1)	Nov (2)	Dec (4)
2012	Jan (2)	Feb	Mar (3)	Apr (1)	May (2)	Jun (5)	Jul (6)	Aug (1)	Sep (1)	Oct	Nov (6)	Dec
2013	Jan	Feb	Mar	Apr (2)	May	Jun	Jul (1)	Aug	Sep	Oct (3)	Nov	Dec
2014	Jan (17)	Feb (3)	Mar (3)	Apr	May (1)	Jun	Jul	Aug (3)	Sep	Oct	Nov	Dec
2015	Jan	Feb	Mar	Apr	May (2)	Jun (5)	Jul	Aug	Sep (1)	Oct (8)	Nov	Dec
2016	Jan	Feb	Mar (1)	Apr	May	Jun (2)	Jul	Aug (1)	Sep	Oct (1)	Nov	Dec
2017	Jan (1)	Feb	Mar	Apr (1)	May	Jun	Jul (13)	Aug (1)	Sep (1)	Oct (3)	Nov	Dec
2019	Jan	Feb (1)	Mar	Apr	May	Jun	Jul (2)	Aug (2)	Sep	Oct	Nov	Dec
2020	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug (2)	Sep	Oct	Nov	Dec
2021	Jan (3)	Feb	Mar	Apr	May	Jun (20)	Jul	Aug	Sep	Oct (4)	Nov (1)	Dec
2022	Jan	Feb	Mar	Apr (22)	May (1)	Jun (1)	Jul	Aug	Sep	Oct (1)	Nov	Dec
2023	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug (4)	Sep	Oct	Nov	Dec
2024	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov	Dec (1)
2025	Jan	Feb (1)	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov (1)	Dec

Flat | Threaded

<< < 1 2 3 4 .. 8 > >> (Page 2 of 8)

[Gptfdisk-general] [PATCH 06/15] makefile: Add "-O2" compiler flag for linux/freebsd builds

From: Bin M. <bme...@gm...> - 2022-04-02 07:00:48

At present the makefiles for linux/freebsd builds don't use the "-O2"
compiler flag, while other platform builds do.

Let's add it to keep consistency with others.

Signed-off-by: Bin Meng <bme...@gm...>
---

 Makefile         | 4 ++--
 Makefile.freebsd | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 58e9d2d..d1ac530 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
-#CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16
-CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64
+#CXXFLAGS+=-O2 -Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16
+CXXFLAGS+=-O2 -Wall -D_FILE_OFFSET_BITS=64
 LDFLAGS+=
 LIB_NAMES=crc32 support guid gptpart mbrpart basicmbr mbr gpt bsd parttypes attributes diskio diskio-unix
 MBR_LIBS=support diskio diskio-unix basicmbr mbrpart
diff --git a/Makefile.freebsd b/Makefile.freebsd
index 13fc0fb..c0dd416 100644
--- a/Makefile.freebsd
+++ b/Makefile.freebsd
@@ -1,6 +1,6 @@
 CXX=clang++
-#CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16 -I/usr/local/include
-CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include 
+#CXXFLAGS+=-O2 -Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16 -I/usr/local/include
+CXXFLAGS+=-O2 -Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include 
 LDFLAGS+=
 LIB_NAMES=crc32 support guid gptpart mbrpart basicmbr mbr gpt bsd parttypes attributes diskio diskio-unix
 MBR_LIBS=support diskio diskio-unix basicmbr mbrpart
-- 
2.25.1

[Gptfdisk-general] [PATCH 04/15] makefile: Drop "-g" compiler flag for mac/mingw* builds

From: Bin M. <bme...@gm...> - 2022-04-02 07:00:45

At present the makefiles for mac/mingw* builds have the "-g" compiler
flag, while other platform builds don't.

Let's drop it given "-g" is only useful for a DEBUG build.

Signed-off-by: Bin Meng <bme...@gm...>
---

 Makefile.mac     | 4 ++--
 Makefile.mingw   | 4 ++--
 Makefile.mingw64 | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Makefile.mac b/Makefile.mac
index e30b592..bf68b83 100644
--- a/Makefile.mac
+++ b/Makefile.mac
@@ -2,8 +2,8 @@ CXX=c++
 # FATBINFLAGS=-arch x86_64 -arch i386 -mmacosx-version-min=10.9
 FATBINFLAGS=-arch x86_64 -arch arm64 -mmacosx-version-min=10.9
 THINBINFLAGS=-arch x86_64 -mmacosx-version-min=10.9
-#CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16 -I/opt/local/include -I/usr/local/include -I/opt/local/include -g
-CXXFLAGS=$(FATBINFLAGS) -O2 -Wall -D_FILE_OFFSET_BITS=64 -stdlib=libc++ -I/opt/local/include -I /usr/local/include -I/opt/local/include -g
+#CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16 -I/opt/local/include -I/usr/local/include -I/opt/local/include
+CXXFLAGS=$(FATBINFLAGS) -O2 -Wall -D_FILE_OFFSET_BITS=64 -stdlib=libc++ -I/opt/local/include -I /usr/local/include -I/opt/local/include
 LIB_NAMES=crc32 support guid gptpart mbrpart basicmbr mbr gpt bsd parttypes attributes diskio diskio-unix
 MBR_LIBS=support diskio diskio-unix basicmbr mbrpart
 #LIB_SRCS=$(NAMES:=.cc)
diff --git a/Makefile.mingw b/Makefile.mingw
index 11f6242..199547c 100644
--- a/Makefile.mingw
+++ b/Makefile.mingw
@@ -1,7 +1,7 @@
 CXX=/usr/bin/i686-w64-mingw32-g++
 STRIP=/usr/bin/i686-w64-mingw32-strip
-CXXFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++ -D_FILE_OFFSET_BITS=64 -g
-#CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include -I/opt/local/include -g
+CXXFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++ -D_FILE_OFFSET_BITS=64
+#CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include -I/opt/local/include
 LIB_NAMES=guid gptpart bsd parttypes attributes crc32 mbrpart basicmbr mbr gpt support diskio diskio-windows
 MBR_LIBS=support diskio diskio-windows basicmbr mbrpart
 LIB_SRCS=$(NAMES:=.cc)
diff --git a/Makefile.mingw64 b/Makefile.mingw64
index 7c0db2d..fc8dfd6 100644
--- a/Makefile.mingw64
+++ b/Makefile.mingw64
@@ -1,7 +1,7 @@
 CXX=/usr/bin/x86_64-w64-mingw32-g++
 STRIP=/usr/bin/x86_64-w64-mingw32-strip
-CXXFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++ -D_FILE_OFFSET_BITS=64 -g
-#CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include -I/opt/local/include -g
+CXXFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++ -D_FILE_OFFSET_BITS=64
+#CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include -I/opt/local/include
 LIB_NAMES=guid gptpart bsd parttypes attributes crc32 mbrpart basicmbr mbr gpt support diskio diskio-windows
 MBR_LIBS=support diskio diskio-windows basicmbr mbrpart
 LIB_SRCS=$(NAMES:=.cc)
-- 
2.25.1

[Gptfdisk-general] [PATCH 05/15] gptcl: Silence the compiler warning in BuildMBR()

From: Bin M. <bme...@gm...> - 2022-04-02 07:00:45

When built with -O2 flag, there is a compiler warning:

  gptcl.cc: In member function 'int GPTDataCL::BuildMBR(char*, int)':
  gptcl.cc:507:8: warning: 'eeLast' may be used uninitialized in this
  function [-Wmaybe-uninitialized]
    507 |    int eeLast, mbrNum = 0;
        |        ^~~~~~

The code logic is correct despite the warning. The warning can be
silenced by initializing the local variable.

Signed-off-by: Bin Meng <bme...@gm...>
---

 gptcl.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gptcl.cc b/gptcl.cc
index 3995093..0141994 100644
--- a/gptcl.cc
+++ b/gptcl.cc
@@ -504,7 +504,7 @@ int GPTDataCL::DoOptions(int argc, char* argv[]) {
 // Create a hybrid or regular MBR from GPT data structures
 int GPTDataCL::BuildMBR(char* argument, int isHybrid) {
    int numParts, allOK = 1, i, origPartNum;
-   int eeLast, mbrNum = 0;
+   int eeLast = 0, mbrNum = 0;
    MBRPart newPart;
    BasicMBRData newMBR;
 
-- 
2.25.1

[Gptfdisk-general] [PATCH 03/15] makefile: Fix the 'clean' rule for freebsd/mingw* builds

From: Bin M. <bme...@gm...> - 2022-04-02 07:00:43

The executables to be cleaned in the freebsd/mingw* builds are either
incomplete or incorrect. Fix the 'clean' rule.

Signed-off-by: Bin Meng <bme...@gm...>
---

 Makefile.freebsd | 2 +-
 Makefile.mingw   | 2 +-
 Makefile.mingw64 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile.freebsd b/Makefile.freebsd
index b91ea94..13fc0fb 100644
--- a/Makefile.freebsd
+++ b/Makefile.freebsd
@@ -30,7 +30,7 @@ lint:	#no pre-reqs
 	lint $(SRCS)
 
 clean:	#no pre-reqs
-	rm -f core *.o *~ gdisk sgdisk
+	rm -f core *.o *~ gdisk cgdisk sgdisk fixparts
 
 # what are the source dependencies
 depend: $(SRCS)
diff --git a/Makefile.mingw b/Makefile.mingw
index 608e3c0..11f6242 100644
--- a/Makefile.mingw
+++ b/Makefile.mingw
@@ -25,7 +25,7 @@ lint:	#no pre-reqs
 	lint $(SRCS)
 
 clean:	#no pre-reqs
-	rm -f core *.o *~ gdisk.exe sgdisk.exe
+	rm -f core *.o *~ gdisk32.exe fixparts32.exe
 
 strip:	#no pre-reqs
 	$(STRIP) gdisk32.exe fixparts32.exe
diff --git a/Makefile.mingw64 b/Makefile.mingw64
index 8907130..7c0db2d 100644
--- a/Makefile.mingw64
+++ b/Makefile.mingw64
@@ -25,7 +25,7 @@ lint:	#no pre-reqs
 	lint $(SRCS)
 
 clean:	#no pre-reqs
-	rm -f core *.o *~ gdisk64.exe sgdisk64.exe
+	rm -f core *.o *~ gdisk64.exe fixparts64.exe
 
 strip:	#no pre-reqs
 	$(STRIP) gdisk64.exe fixparts64.exe
-- 
2.25.1

[Gptfdisk-general] [PATCH 02/15] makefile: Remove the 'testguid' rule for mac build

From: Bin M. <bme...@gm...> - 2022-04-02 07:00:40

There is no such source file called testguid.* hence the 'testguid'
build target is invalid. Remove it.

Signed-off-by: Bin Meng <bme...@gm...>
---

 Makefile.mac | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Makefile.mac b/Makefile.mac
index 1dcb065..e30b592 100644
--- a/Makefile.mac
+++ b/Makefile.mac
@@ -31,9 +31,6 @@ sgdisk: $(LIB_OBJS) gptcl.o sgdisk.o
 fixparts: $(MBR_LIB_OBJS) fixparts.o
 	$(CXX) $(MBR_LIB_OBJS) fixparts.o $(LDFLAGS) $(FATBINFLAGS) -o fixparts
 
-testguid:	$(LIB_OBJS) testguid.o
-	$(CXX) $(LIB_OBJS) testguid.o -o testguid
-
 lint:	#no pre-reqs
 	lint $(SRCS)
 
-- 
2.25.1

[Gptfdisk-general] [PATCH 01/15] makefile: Drop CC and CFLAGS

From: Bin M. <bme...@gm...> - 2022-04-02 07:00:38

There is no C source file to compile, hence CC/CFLAGS are not needed.

Signed-off-by: Bin Meng <bme...@gm...>
---

 Makefile         | 1 -
 Makefile.freebsd | 2 --
 Makefile.mac     | 2 --
 Makefile.mingw   | 2 --
 Makefile.mingw64 | 2 --
 5 files changed, 9 deletions(-)

diff --git a/Makefile b/Makefile
index 0d7309c..58e9d2d 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,3 @@
-CFLAGS+=-D_FILE_OFFSET_BITS=64
 #CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16
 CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64
 LDFLAGS+=
diff --git a/Makefile.freebsd b/Makefile.freebsd
index 4b4b616..b91ea94 100644
--- a/Makefile.freebsd
+++ b/Makefile.freebsd
@@ -1,6 +1,4 @@
-CC=clang
 CXX=clang++
-CFLAGS+=-D_FILE_OFFSET_BITS=64
 #CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16 -I/usr/local/include
 CXXFLAGS+=-Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include 
 LDFLAGS+=
diff --git a/Makefile.mac b/Makefile.mac
index ea21fa6..1dcb065 100644
--- a/Makefile.mac
+++ b/Makefile.mac
@@ -1,9 +1,7 @@
-CC=gcc
 CXX=c++
 # FATBINFLAGS=-arch x86_64 -arch i386 -mmacosx-version-min=10.9
 FATBINFLAGS=-arch x86_64 -arch arm64 -mmacosx-version-min=10.9
 THINBINFLAGS=-arch x86_64 -mmacosx-version-min=10.9
-CFLAGS=$(FATBINFLAGS) -O2 -D_FILE_OFFSET_BITS=64 -g
 #CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -D USE_UTF16 -I/opt/local/include -I/usr/local/include -I/opt/local/include -g
 CXXFLAGS=$(FATBINFLAGS) -O2 -Wall -D_FILE_OFFSET_BITS=64 -stdlib=libc++ -I/opt/local/include -I /usr/local/include -I/opt/local/include -g
 LIB_NAMES=crc32 support guid gptpart mbrpart basicmbr mbr gpt bsd parttypes attributes diskio diskio-unix
diff --git a/Makefile.mingw b/Makefile.mingw
index acfff64..608e3c0 100644
--- a/Makefile.mingw
+++ b/Makefile.mingw
@@ -1,7 +1,5 @@
-CC=/usr/bin/i686-w64-mingw32-gcc
 CXX=/usr/bin/i686-w64-mingw32-g++
 STRIP=/usr/bin/i686-w64-mingw32-strip
-CFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++  -D_FILE_OFFSET_BITS=64 -g
 CXXFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++ -D_FILE_OFFSET_BITS=64 -g
 #CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include -I/opt/local/include -g
 LIB_NAMES=guid gptpart bsd parttypes attributes crc32 mbrpart basicmbr mbr gpt support diskio diskio-windows
diff --git a/Makefile.mingw64 b/Makefile.mingw64
index 7e4b32b..8907130 100644
--- a/Makefile.mingw64
+++ b/Makefile.mingw64
@@ -1,7 +1,5 @@
-CC=/usr/bin/x86_64-w64-mingw32-gcc
 CXX=/usr/bin/x86_64-w64-mingw32-g++
 STRIP=/usr/bin/x86_64-w64-mingw32-strip
-CFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++  -D_FILE_OFFSET_BITS=64 -g
 CXXFLAGS=-O2 -Wall -static -static-libgcc -static-libstdc++ -D_FILE_OFFSET_BITS=64 -g
 #CXXFLAGS=-O2 -Wall -D_FILE_OFFSET_BITS=64 -I /usr/local/include -I/opt/local/include -g
 LIB_NAMES=guid gptpart bsd parttypes attributes crc32 mbrpart basicmbr mbr gpt support diskio diskio-windows
-- 
2.25.1

[Gptfdisk-general] [PATCH 00/15] Clean up makefiles and support building sgdisk executable for Windows

From: Bin M. <bme...@gm...> - 2022-04-02 07:00:35

This series was originated from trying to build the sgdisk executable
for Windows host, that has not been formally supported as of today.

The series starts from several patches to do some clean-ups to existing
makefiles for various platforms (patch 1, 2, 3, 4, 6, 7).

Patch 5 is a build warning fix as the result of adding the '-O2' flag.

Patch 8 fixes several issues in the 'sgdisk' build rule for mingw*
builds, and patch 9 enables the sgdisk build by default.

Path 10 does further clean-up to simplify the build rules.

Path 11 and 12 are fixes when using newer version gcc (e.g.: gcc 11)
which is the one that ships on MSYS2.

Patch 13 switches the Windows executable build from static to shared.

Patch 14 allows MinGW compiler on both Linux and Windows to be used.

Patch 15 updates the Windows documentation with the latest information.


Bin Meng (15):
  makefile: Drop CC and CFLAGS
  makefile: Remove the 'testguid' rule for mac build
  makefile: Fix the 'clean' rule for freebsd/mingw* builds
  makefile: Drop "-g" compiler flag for mac/mingw* builds
  gptcl: Silence the compiler warning in BuildMBR()
  makefile: Add "-O2" compiler flag for linux/freebsd builds
  makefile: Drop duplicated "-static-libgcc" flag in mingw* builds
  makefile: Fix the 'sgdisk' rule for mingw* builds
  makefile: Enable building sgdisk by default for mingw* builds
  makefile: Consolidate build rules with LDFLAGS and LDLIBS
  crc32: Remove deprecated 'register' specifier for C++17
  Explicitly namespace-qualify all std names in header files
  makefile: Switch to building shared executables for mingw* builds
  makefile: Avoid absolute path in CXX for mingw* builds
  README: Update build instructions for Windows executables

 Makefile         | 17 +++++++----------
 Makefile.freebsd | 22 +++++++++-------------
 Makefile.mac     | 22 +++++++---------------
 Makefile.mingw   | 26 +++++++++++++-------------
 Makefile.mingw64 | 26 +++++++++++++-------------
 README.Windows   | 37 ++++++++++++++++++++-----------------
 attributes.h     | 10 ++++------
 basicmbr.h       | 12 +++++-------
 bsd.h            |  5 +----
 crc32.cc         |  2 +-
 diskio.h         | 16 +++++++---------
 gdisk.cc         |  2 ++
 gpt.h            | 20 +++++++++-----------
 gptcl.cc         |  4 +++-
 gptcl.h          | 10 ++++------
 gptcurses.h      | 10 ++++------
 gptpart.cc       | 11 +++++------
 gptpart.h        |  6 ++----
 gpttext.h        | 12 +++++-------
 guid.h           | 12 +++++-------
 mbr.h            |  4 +---
 mbrpart.h        |  2 --
 parttypes.h      | 16 +++++++---------
 support.h        | 16 +++++++---------
 24 files changed, 141 insertions(+), 179 deletions(-)

-- 
2.25.1

[Gptfdisk-general] [PATCH] gptcurses.cc: always use "%s"-style format for printf()-style functions

From: Sergei T. <sl...@gm...> - 2021-11-28 18:56:59

`ncuses-6.3` added printf-style function attributes and now makes
it easier to catch cases when user input is used in palce of format
string when built with CFLAGS=-Werror=format-security:

    gptcurses.cc:274:10: error:
        format not a string literal and no format arguments [-Werror=format-security]
      274 |    printw(theLine.c_str());
          |    ~~~~~~^~~~~~~~~~~~~~~~~

Let's wrap all the missing places with "%s" format.
---
 gptcurses.cc | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/gptcurses.cc b/gptcurses.cc
index 1fbaad2..aaf113a 100644
--- a/gptcurses.cc
+++ b/gptcurses.cc
@@ -239,22 +239,22 @@ Space* GPTDataCurses::ShowSpace(int spaceNum, int lineNum) {
       ClearLine(lineNum);
       if (space->partNum == -1) { // space is empty
          move(lineNum, 12);
-         printw(BytesToIeee((space->lastLBA - space->firstLBA + 1), blockSize).c_str());
+         printw("%s", BytesToIeee((space->lastLBA - space->firstLBA + 1), blockSize).c_str());
          move(lineNum, 24);
          printw("free space");
       } else { // space holds a partition
          move(lineNum, 3);
          printw("%d", space->partNum + 1);
          move(lineNum, 12);
-         printw(BytesToIeee((space->lastLBA - space->firstLBA + 1), blockSize).c_str());
+         printw("%s", BytesToIeee((space->lastLBA - space->firstLBA + 1), blockSize).c_str());
          move(lineNum, 24);
-         printw(space->origPart->GetTypeName().c_str());
+         printw("%s", space->origPart->GetTypeName().c_str());
          move(lineNum, 50);
          #ifdef USE_UTF16
          space->origPart->GetDescription().extract(0, 39, temp, 39);
-         printw(temp);
+         printw("%s", temp);
          #else
-         printw(space->origPart->GetDescription().c_str());
+         printw("%s", space->origPart->GetDescription().c_str());
          #endif
       } // if/else
    } // if
@@ -271,10 +271,10 @@ int GPTDataCurses::DisplayParts(int selected) {
 
    move(lineNum++, 0);
    theLine = "Part. #     Size        Partition Type            Partition Name";
-   printw(theLine.c_str());
+   printw("%s", theLine.c_str());
    move(lineNum++, 0);
    theLine = "----------------------------------------------------------------";
-   printw(theLine.c_str());
+   printw("%s", theLine.c_str());
    numToShow = LINES - RESERVED_TOP - RESERVED_BOTTOM;
    pageNum = selected / numToShow;
    for (i = pageNum * numToShow; i <= (pageNum + 1) * numToShow - 1; i++) {
@@ -636,7 +636,7 @@ void GPTDataCurses::DisplayOptions(char selectedKey) {
          } // if/else
       } // for
       move(LINES - 1, (COLS - optionDesc.length()) / 2);
-      printw(optionDesc.c_str());
+      printw("%s", optionDesc.c_str());
       currentKey = selectedKey;
    } // if
 } // GPTDataCurses::DisplayOptions()
@@ -748,11 +748,11 @@ void GPTDataCurses::DrawMenu(void) {
 
    clear();
    move(0, (COLS - title.length()) / 2);
-   printw(title.c_str());
+   printw("%s", title.c_str());
    move(2, (COLS - drive.length()) / 2);
-   printw(drive.c_str());
+   printw("%s", drive.c_str());
    move(3, (COLS - size.str().length()) / 2);
-   printw(size.str().c_str());
+   printw("%s", size.str().c_str());
    DisplayParts(currentSpaceNum);
 } // DrawMenu
 
@@ -802,7 +802,7 @@ void PromptToContinue(void) {
 void Report(string theText) {
    clear();
    move(0, 0);
-   printw(theText.c_str());
+   printw("%s", theText.c_str());
    move(LINES - 2, (COLS - 29) / 2);
    printw("Press any key to continue....");
    cbreak();
-- 
2.33.1

Re: [Gptfdisk-general] sgdisk: Slightly more verbose when choosing first available partNum

From: Rod S. <rod...@ro...> - 2021-10-09 22:42:07

On 10/9/21 5:26 PM, u3...@ne... wrote:
> Rod Smith <rod...@ro...> wrote:
> 
>> Actually, it should never print that message with the --new command. In
>> fact, it *SHOULD* never print that message at all; however, I did find a
>> stray bit of debugging code that prints such a message in the
>> -c/--change-name function of sgdisk. I've removed this code from the
>> source code; the change is now in the git repository.
>>
> 
> Thank you.
> 
> The following is NOT with the latest git revision. It is with 1.0.8 already 
> installed here. Hopefully, you already addressed it.
> I rechecked my example. Indeed, it doesn't print the partNum message. It 
> could be I was tired. However, I do get the following:
> 
>     # sgdisk --pretend --set-alignment=1 --new=0:0:+100000 --typecode=0:0700 --change-name=0:12345 --attributes=0:set:63 /dev/sdc
>     Setting name!
>     partNum is 2

That command includes the --change-name option, which is what was
triggering the stray debugging code.

> (The long command line is due to this time trying to keep exactly what I 
> have tried)
> I think those messages also appear without --pretend, keeping the rest of 
> the line as is. Once again, this is NOT with the latest git revision.
> Hopefully, you already fixed the problem.
> 
> --
> u34
> 
>>> . Meaning, while the first available partition number is 3, it prints 
>>> partNum is 2. Which looks to me a bit confusing. Takes time to get used to. 
>>> I think it should be a bit more verbose. Something like:
>>>
>>>    Last used partNum is 2
>>> Or,
>>>    Last used partNum is 2. Will create partNum 3.
>>> Or,
>>>    Highest used partNum is 2
>>> Or,
>>>    First available partNum is 3 
>>>
>>> --
>>> u34
>>>
>>>
>>> _______________________________________________
>>> Gptfdisk-general mailing list
>>> Gpt...@li...
>>> https://lists.sourceforge.net/lists/listinfo/gptfdisk-general
>>>
>>
>>
>> -- 
>> Rod Smith
>> rod...@ro...
>> http://www.rodsbooks.com
> 
> 
> _______________________________________________
> Gptfdisk-general mailing list
> Gpt...@li...
> https://lists.sourceforge.net/lists/listinfo/gptfdisk-general
> 


-- 
Rod Smith
rod...@ro...
http://www.rodsbooks.com

Re: [Gptfdisk-general] sgdisk: Slightly more verbose when choosing first available partNum

From: <u3...@ne...> - 2021-10-09 21:26:50

Rod Smith <rod...@ro...> wrote:

> On 10/9/21 9:53 AM, u3...@ne... wrote:
> > Hello,
> > Relating to 1.0.8, and prior versions:
> > With, for example,
> > 
> >     sgdisk --new:0:0:+10000000 /dev/sdc
> > 
> > it can print
> > 
> >     partNum is 2
> 
> Actually, it should never print that message with the --new command. In
> fact, it *SHOULD* never print that message at all; however, I did find a
> stray bit of debugging code that prints such a message in the
> -c/--change-name function of sgdisk. I've removed this code from the
> source code; the change is now in the git repository.
> 

Thank you.

The following is NOT with the latest git revision. It is with 1.0.8 already 
installed here. Hopefully, you already addressed it.
I rechecked my example. Indeed, it doesn't print the partNum message. It 
could be I was tired. However, I do get the following:

    # sgdisk --pretend --set-alignment=1 --new=0:0:+100000 --typecode=0:0700 --change-name=0:12345 --attributes=0:set:63 /dev/sdc
    Setting name!
    partNum is 2

(The long command line is due to this time trying to keep exactly what I 
have tried)
I think those messages also appear without --pretend, keeping the rest of 
the line as is. Once again, this is NOT with the latest git revision.
Hopefully, you already fixed the problem.

--
u34

> > . Meaning, while the first available partition number is 3, it prints 
> > partNum is 2. Which looks to me a bit confusing. Takes time to get used to. 
> > I think it should be a bit more verbose. Something like:
> > 
> >    Last used partNum is 2
> > Or,
> >    Last used partNum is 2. Will create partNum 3.
> > Or,
> >    Highest used partNum is 2
> > Or,
> >    First available partNum is 3 
> > 
> > --
> > u34
> > 
> > 
> > _______________________________________________
> > Gptfdisk-general mailing list
> > Gpt...@li...
> > https://lists.sourceforge.net/lists/listinfo/gptfdisk-general
> > 
> 
> 
> -- 
> Rod Smith
> rod...@ro...
> http://www.rodsbooks.com

Re: [Gptfdisk-general] sgdisk: Slightly more verbose when choosing first available partNum

From: Rod S. <rod...@ro...> - 2021-10-09 20:52:31

On 10/9/21 9:53 AM, u3...@ne... wrote:
> Hello,
> Relating to 1.0.8, and prior versions:
> With, for example,
> 
>     sgdisk --new:0:0:+10000000 /dev/sdc
> 
> it can print
> 
>     partNum is 2

Actually, it should never print that message with the --new command. In
fact, it *SHOULD* never print that message at all; however, I did find a
stray bit of debugging code that prints such a message in the
-c/--change-name function of sgdisk. I've removed this code from the
source code; the change is now in the git repository.

> . Meaning, while the first available partition number is 3, it prints 
> partNum is 2. Which looks to me a bit confusing. Takes time to get used to. 
> I think it should be a bit more verbose. Something like:
> 
>    Last used partNum is 2
> Or,
>    Last used partNum is 2. Will create partNum 3.
> Or,
>    Highest used partNum is 2
> Or,
>    First available partNum is 3 
> 
> --
> u34
> 
> 
> _______________________________________________
> Gptfdisk-general mailing list
> Gpt...@li...
> https://lists.sourceforge.net/lists/listinfo/gptfdisk-general
> 


-- 
Rod Smith
rod...@ro...
http://www.rodsbooks.com

[Gptfdisk-general] sgdisk: Slightly more verbose when choosing first available partNum

From: <u3...@ne...> - 2021-10-09 14:12:15

Hello,
Relating to 1.0.8, and prior versions:
With, for example,

    sgdisk --new:0:0:+10000000 /dev/sdc

it can print

    partNum is 2

. Meaning, while the first available partition number is 3, it prints 
partNum is 2. Which looks to me a bit confusing. Takes time to get used to. 
I think it should be a bit more verbose. Something like:

   Last used partNum is 2
Or,
   Last used partNum is 2. Will create partNum 3.
Or,
   Highest used partNum is 2
Or,
   First available partNum is 3 

--
u34

[Gptfdisk-general] GPT fdisk 1.0.8 (was Re: GPTPart::GetDescription broken in 1.0.7 on Big Endian systems)

From: Rod S. <rod...@ro...> - 2021-06-10 00:47:17

This is a heads-up that I've released version 1.0.8, which fixes this
bug. It also adds a new feature to gdisk and sgdisk that enables
correcting a corrupted partition name. To use this feature:

* In gdisk, enter the experts' menu and then type 'b'. This will
  prompt you for a partition number (unless the disk has just
  one partition), shows the original and transformed names, and
  asks for verification. After you've fixed all the broken partition
  names, type 'w' to write your changes and exit.
* In sgdisk, use the new -B/--byte-swap-name parameter, which takes a
  partition number as an option. If valid, changes will be immediately
  written to disk.

This new feature works on any CPU architecture, but it probably won't be
necessary on x86 or x86-64. The bug doesn't affect little-endian CPUs
like x86 or x86-64, so the bug fix has no effect on them.

GPT fdisk 1.0.8 also adds a new partition type code for the Barebox boot
loader.

On 6/8/21 1:16 PM, Rod Smith wrote:
> On 6/8/21 12:21 PM, Erik Larsson wrote:
>> Hi,
>>
>> On 08-06-2021 18:16, Rod Smith wrote:
>>> On 6/8/21 10:54 AM, Christian Ehrhardt wrote:
>>>>> There aren't a lot of changes from 1.0.7 to the current
>>>>> state, but given that this is kind of important for big-endian systems,
>>>>> I'll release this change as 1.0.8 soon -- but I'll give it a day or two
>>>>> in case something else crops up.
>>>> Agreed, that little wait sounds wise.
>>>> I've indirectly also pulled IBM into the boat since they are kind of
>>>> the "master of big-endian things".
>>>> Maybe (but no promise) they have opinions/hints on this as well.
>>> I've been doing some searching to find a way to identify UCS-2 with
>>> swapped bytes, so that the program could fix this automatically when
>>> reading corrupted partition tables. (GPT technically uses UCS-2, not
>>> UTF-16, although the GPT fdisk code has a lot of references to UTF-16
>>> because at one time I relied on an external UTF-16 library.) So far no
>>> luck.
>>
>>
>> This problem is impossible to solve perfectly, however I would think
>> that partition labels with characters outside the ASCII range are very
>> rare in practice so for a start one could check if the first byte is 0
>> in every UCS-2 byte-pair.
>> If true, then it's almost certain that the label is in big endian (but I
>> would still ask the user to confirm that the big-endian interpretation
>> makes more sense).
> 
> Rather than implement something that stands a chance of getting things
> badly wrong, I'm leaning toward either doing nothing so that users can
> manually change partition labels, if desired; or implement an option to
> let users explicitly select partitions to byte-swap their labels. Either
> approach enables users to fix problems as they're detected, with the
> second option providing some help to users in recovering the original
> intended partition labels. Because most disk tools don't use partition
> labels for anything important, I don't think it's critical that these
> problems be corrected automatically. OTOH, automatically "fixing"
> something that's not broken, because of an algorithm that's prone to
> false alarms, could be really annoying.
> 
>> There are of course also some ranges that are reserved in Unicode that
>> can be used to detect that something might not be right with the
>> endianness and if we're limiting the allowed Unicode range to UCS-2 we
>> can exclude UTF-16 surrogate pair ranges (disallowing for instance the
>> poop emoji as a partition label).
>>
>> One could also check locality (text doesn't usually use characters from
>> all over the place in but stays within a few defined script ranges) and
>> there may also be statistical models based on the frequency that Unicode
>> characters occur in text,  but that's probably taking it too far. :)
>>
>> Best regards,
>>
>> - Erik
> 
> 


-- 
Rod Smith
rod...@ro...
http://www.rodsbooks.com

Re: [Gptfdisk-general] sgdisk: minor suggestions for manual page, and program

From: Rod S. <rod...@ro...> - 2021-06-09 13:26:13

On 6/8/21 6:29 PM, u3...@ne... wrote:
> Replying to myself because I had time to prepare a patch for the manual 
> page. Which is the simple work. In particular, because it doesn't address
> the code, that I hope will be written, for sgdisk --info=0.

Thanks for the patch. I've applied it and it's in the git repository now.

> At 2021-06-07 03:30:50, u3...@ne... wrote:
> 
>> Thank you for your work.
>>
>> 1) With some entries, such as for -N, --largest-new=num, the manual page 
>>    takes the burden of claryfing -a (--set-alignment). I suggest to take 
>>    the same approach for the references to the -A, -c, -t, and -u options 
>>    within the entry for -n, --new=partnum:start:end.
>>
> 
> The following patch fixes only the above long options issue.
> 
> --- a/gptfdisk-1.0.7/sgdisk.8	2021-03-11 00:45:56.000000000 +0000
> +++ b/gptfdisk-1.0.7/sgdisk.8	2021-06-08 21:49:17.679338911 +0000
> @@ -339,7 +339,8 @@
>  start of the largest available block for the start sector and the end of
>  the same block for the end sector. A partnum value of 0 causes the program
>  to use the first available partition number. Subsequent uses of the
> -\fI\-A\fR, \fI\-c\fR, \fI\-t\fR, and \fI\-u\fR options may also use
> +\fI\-A\fR (\fI\-\-attributes\fR), \fI\-c\fR (\fI\-\-change\-name\fR), \fI\-t\fR
> +(\fI\-\-typecode\fR), and \fI\-u\fR (\fI\-\-partition\-guid\fR) options may also use
>  \fI0\fR to refer to the same partition.
>  
>  .TP
> 
> --
> u34
> 
>> 2) For the special partnum of 0, --info=0 will show detailed information 
>>    about what -n, --new=partnum:start:end will do with 0 partnum, and a  
>>    0 start value.
>>
>> --
>> u34
>>
>>
>> _______________________________________________
>> Gptfdisk-general mailing list
>> Gpt...@li...
>> https://lists.sourceforge.net/lists/listinfo/gptfdisk-general
> 
> 
> _______________________________________________
> Gptfdisk-general mailing list
> Gpt...@li...
> https://lists.sourceforge.net/lists/listinfo/gptfdisk-general
> 


-- 
Rod Smith
rod...@ro...
http://www.rodsbooks.com

Re: [Gptfdisk-general] sgdisk: minor suggestions for manual page, and program

From: <u3...@ne...> - 2021-06-08 22:29:40

Replying to myself because I had time to prepare a patch for the manual 
page. Which is the simple work. In particular, because it doesn't address
the code, that I hope will be written, for sgdisk --info=0.

At 2021-06-07 03:30:50, u3...@ne... wrote:

> Thank you for your work.
> 
> 1) With some entries, such as for -N, --largest-new=num, the manual page 
>    takes the burden of claryfing -a (--set-alignment). I suggest to take 
>    the same approach for the references to the -A, -c, -t, and -u options 
>    within the entry for -n, --new=partnum:start:end.
> 

The following patch fixes only the above long options issue.

--- a/gptfdisk-1.0.7/sgdisk.8	2021-03-11 00:45:56.000000000 +0000
+++ b/gptfdisk-1.0.7/sgdisk.8	2021-06-08 21:49:17.679338911 +0000
@@ -339,7 +339,8 @@
 start of the largest available block for the start sector and the end of
 the same block for the end sector. A partnum value of 0 causes the program
 to use the first available partition number. Subsequent uses of the
-\fI\-A\fR, \fI\-c\fR, \fI\-t\fR, and \fI\-u\fR options may also use
+\fI\-A\fR (\fI\-\-attributes\fR), \fI\-c\fR (\fI\-\-change\-name\fR), \fI\-t\fR
+(\fI\-\-typecode\fR), and \fI\-u\fR (\fI\-\-partition\-guid\fR) options may also use
 \fI0\fR to refer to the same partition.
 
 .TP

--
u34

> 2) For the special partnum of 0, --info=0 will show detailed information 
>    about what -n, --new=partnum:start:end will do with 0 partnum, and a  
>    0 start value.
> 
> --
> u34
> 
> 
> _______________________________________________
> Gptfdisk-general mailing list
> Gpt...@li...
> https://lists.sourceforge.net/lists/listinfo/gptfdisk-general