The patch adds transparent background for the buttons on the sides of the map screen.
Transparent buttons background
I had tried out this patch last year and while it's a great idea I think the filled background is a bit too dark. But something like this might actually be useful for e.g. making the text backgrounds transparent if the performance impact and increased battery power needs is not too high.
Well, regarding buttons this might be conflicting with mbaeurle's plans I suppose he has when looking at this commit:
But probably we are far away from this as with the increased count of scaled images on the map screen I think we really need something like https://sourceforge.net/tracker/?func=detail&aid=3512878&group_id=192084&atid=939977. So in the meanwhile the filled transparent buttons would be IMHO an improvement, if the impact is not too high.
The button text color was still black in this patch. With white button color the transparent background buttons looking very good.
The performance is similar as drawing something else onto the map screen. The drawing is done line by line. When worrying about performance we can make this configurable.
I have a local Git branch with some other changes. If nobody is mind, I'll upload it so everybody can have a look what to take over.
Would be pleased to see this feature with white colour (and maybe later on configurable) in git then. Would be good to commit other changes separately one by one if they are complex.
The buttons with transparent background can be tested now. Old zip maps will still have the black button text color!
I also pushed a branch master_extended where you can have a look onto.
Hmm...got this wrong thought about white background color not text color but'll see how it looks on real device. However in landscape mode the buttons are reordered to a four button square causing with your patch * and _ to overlap because of setAdditionalOffsetY.
Btw. always thought _ schould be above * in landscape mode as well but never got to it.
Regarding the master_extended branch - seems there's some interesting stuff inside but I can't check this all out now.
One remark on http://gpsmid.git.sourceforge.net/git/gitweb.cgi?p=gpsmid/GpsMid;a=commitdiff;h=0610f04115da8c24584a0747146449877725f888 - please remove the cosmetical / formatting changes from the commit if you push this to the master branch - to make it easier to look for anything that causes issues in the commit if this should become necessary.
About http://gpsmid.git.sourceforge.net/git/gitweb.cgi?p=gpsmid/GpsMid;a=commitdiff;h=b858d42b42e67daf7df1c3396bf183a0702677bc - I think I remember this one from another patch and on new tile loading I think it happened sometimes the not loaded tile greyed out the complete map screen ntil loaded which was a very irritating effect.
Continued at http://sourceforge.net/tracker/index.php?func=detail&aid=3514945&group_id=192084&atid=939976 about master_extended...
I like the transparency, but when the map happens to be dark near the spot of the icons, it's very hard to see the dark character on the button. However I tested white text on the +-_|>* text, and I like how that looks, much more clear.
Another alternative would be to make the map lighter instead of darker, not sure if that's technically feasible.
> Another alternative would be to make the map lighter instead of darker, not
sure if that's technically feasible.
That's line 667 of LayoutElement, just changed to
iaTransparentPaintingBlack[i] = 0x80AAAAAA;
(and black text color in colors.inc)
This would make the map lighter under the button which I also think would be preferrable.
>Would be pleased to see this feature with white colour (and maybe later on
>configurable) in git then. Would be good to commit other changes separately
>one by one if they are complex.
OK, didn't see this discussed already. Do you mean white colour for the button (would it make the map lighter?) or white colour for the text? If for the text, I see a problem - old maps have the text color as dark, and with the new app version, background will be dark as well, making readability worse then before.
OK, but probably the button background color/transparency should also be made configurable in map to allow for users to change.
iaTransparentPaintingBlack[i] = 0x80FFFFFF;
looks even nicer to me (that's white).
Yes, this is the value I talked about making configurable in colors.inc
@sk750: Thanks, looks quite readably with that value (though stylistically dark background with white text maybe looks better), maybe that setting should be the default for the time being (while the color is hard-coded in the app). When map format changes, dark background with white text can be made the default.
Lets take a hard coded bright background by now since actual maps using black button text. Making the value configurable in the next map format will give the freedom to play around with different values.
I've pushed for now a white background with black text to git.
What I'd like more about a bright backgound, is that you can IMHO better see the map that is under the transparent button. With the dark transparent button the map was hardly to recognize making the transparent background only slightly more useful than an opaque background.
Also might be good to make this effect configurable - from googling it seems that drawRGB() has issues on some devices, especially very low performance.
What about an user configurable value allowing to have transparent, solid or no background?
Yes - I think filling with a color (transparent ARGB or solid RGB) should be configurable in colors.inc, while turning off the filled background should be possible at runtime.
Transparent button background probably would be nice for virtual keyboard as well to increase readability of the button texts while keeping the search results readable, too.
As drawRGB() might need too much performance and/or is a battery drainer on some devices it might be better to use createRGBImage() instead. This is because createRGBImage() will reorganize the raw graphics data into the native format which is required by the device.
I've changed this now to use a buffered Image created by createRGBImage().
createRGBImage() is used now.
The color should maybe configurable.
Log in to post a comment.
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.