#151 Filled transparent touch button background

closed
nobody
None
5
2013-03-16
2011-07-18
Martin
No

The patch adds transparent background for the buttons on the sides of the map screen.

Discussion

1 2 > >> (Page 1 of 2)
  • Martin

    Martin - 2012-04-03

    The button text color was still black in this patch. With white button color the transparent background buttons looking very good.

    The performance is similar as drawing something else onto the map screen. The drawing is done line by line. When worrying about performance we can make this configurable.

    I have a local Git branch with some other changes. If nobody is mind, I'll upload it so everybody can have a look what to take over.

     
  • sk750

    sk750 - 2012-04-03

    Would be pleased to see this feature with white colour (and maybe later on configurable) in git then. Would be good to commit other changes separately one by one if they are complex.

     
  • Martin

    Martin - 2012-04-04

    The buttons with transparent background can be tested now. Old zip maps will still have the black button text color!

    I also pushed a branch master_extended where you can have a look onto.

     
  • sk750

    sk750 - 2012-04-04

    Hmm...got this wrong thought about white background color not text color but'll see how it looks on real device. However in landscape mode the buttons are reordered to a four button square causing with your patch * and _ to overlap because of setAdditionalOffsetY.

    Btw. always thought _ schould be above * in landscape mode as well but never got to it.

     
  • Jyrki Kuoppala

    Jyrki Kuoppala - 2012-04-04

    I like the transparency, but when the map happens to be dark near the spot of the icons, it's very hard to see the dark character on the button. However I tested white text on the +-_|>* text, and I like how that looks, much more clear.

    Another alternative would be to make the map lighter instead of darker, not sure if that's technically feasible.

     
  • sk750

    sk750 - 2012-04-04

    > Another alternative would be to make the map lighter instead of darker, not
    sure if that's technically feasible.

    That's line 667 of LayoutElement, just changed to

    iaTransparentPaintingBlack[i] = 0x80AAAAAA;

    (and black text color in colors.inc)

    This would make the map lighter under the button which I also think would be preferrable.

     
  • Jyrki Kuoppala

    Jyrki Kuoppala - 2012-04-04

    >Would be pleased to see this feature with white colour (and maybe later on
    >configurable) in git then. Would be good to commit other changes separately
    >one by one if they are complex.

    OK, didn't see this discussed already. Do you mean white colour for the button (would it make the map lighter?) or white colour for the text? If for the text, I see a problem - old maps have the text color as dark, and with the new app version, background will be dark as well, making readability worse then before.

     
  • Jyrki Kuoppala

    Jyrki Kuoppala - 2012-04-04

    OK, but probably the button background color/transparency should also be made configurable in map to allow for users to change.

     
  • sk750

    sk750 - 2012-04-04

    iaTransparentPaintingBlack[i] = 0x80FFFFFF;
    looks even nicer to me (that's white).

    @jkpj:
    Yes, this is the value I talked about making configurable in colors.inc

     
  • Jyrki Kuoppala

    Jyrki Kuoppala - 2012-04-05

    @sk750: Thanks, looks quite readably with that value (though stylistically dark background with white text maybe looks better), maybe that setting should be the default for the time being (while the color is hard-coded in the app). When map format changes, dark background with white text can be made the default.

     
  • Martin

    Martin - 2012-04-05

    Lets take a hard coded bright background by now since actual maps using black button text. Making the value configurable in the next map format will give the freedom to play around with different values.

     
  • sk750

    sk750 - 2012-04-05

    I've pushed for now a white background with black text to git.

    What I'd like more about a bright backgound, is that you can IMHO better see the map that is under the transparent button. With the dark transparent button the map was hardly to recognize making the transparent background only slightly more useful than an opaque background.

    Also might be good to make this effect configurable - from googling it seems that drawRGB() has issues on some devices, especially very low performance.

     
  • Martin

    Martin - 2012-04-05

    What about an user configurable value allowing to have transparent, solid or no background?

     
  • sk750

    sk750 - 2012-04-05

    Yes - I think filling with a color (transparent ARGB or solid RGB) should be configurable in colors.inc, while turning off the filled background should be possible at runtime.

     
  • sk750

    sk750 - 2012-04-09

    Transparent button background probably would be nice for virtual keyboard as well to increase readability of the button texts while keeping the search results readable, too.

     
  • sk750

    sk750 - 2012-04-10

    As drawRGB() might need too much performance and/or is a battery drainer on some devices it might be better to use createRGBImage() instead. This is because createRGBImage() will reorganize the raw graphics data into the native format which is required by the device.

     
  • sk750

    sk750 - 2012-04-10

    I've changed this now to use a buffered Image created by createRGBImage().

     
  • Martin

    Martin - 2013-03-16
    • status: open --> closed
     
  • Martin

    Martin - 2013-03-16

    createRGBImage() is used now.
    The color should maybe configurable.

    Closed.

     
  • Martin

    Martin - 2013-03-16
    • status: closed --> open
     
1 2 > >> (Page 1 of 2)

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks