[Gpsbabel-code] Re: Garmin upload tracks patch
Brought to you by:
robertl
From: Robert L. <rob...@us...> - 2004-02-05 23:31:33
|
I don't have a Garmin, but this looks pretty reasonable to me. > + * GPS_Track_New seems to return garbage defaults so we fix those here. [ begin bitter sarcasm ] Thanx, libjeeps... [ end mumbling ] I've had to clean up variations of this in libjeeps for WAY too long. Can you verify that editing jeeps/gpsmem.c so that if if(!(ret=(GPS_PTrack)malloc(sizeof(GPS_OTrack)))) becomes something like if(!(ret=(GPS_PTrack)calloc(1, sizeof(GPS_OTrack)))) (and dropping the explicit initializers here) life is good? If you can test with that tweak and resubmit it, I'll apply it. Honestly, if you don't don't make the tweak, I'll probably still go for it. I'll just feel better about it with the tweak, but there are so many variations of this problem in libjeeps that I won't lose sleep about it. :-) RJL |