Re: [Gpsbabel-code] Mapopolis Mapconverter Patch Committed

[Robert L. <rob...@us...>]

Alex Mottram wrote:

> Also included are patches for fatal() and warning() that adds va_end()
> to deinitialize arguments initialized by va_start().  (Robert, that
> was in the patch you sent me, so I just included it and did the same
> for warning()).

I think it was either Solaris or OS/X that freaked out not having this.
Since it's required by the language, I just did it.

> +o GPSBabel encodes "foo.txt" to have mapconverter use the output filename
> +  of "foo.pdb".  Similarly, if you tell GPSBabel to write output as
> +  "bananagps.txt", mapconverter output will be "bananagps.pdb".

Type that slower for me, please.

>      /* output prologue lines, if any. */
>      QUEUE_FOR_EACH(&xcsv_file.prologue, elem, tmp) {
> -        ogp = (ogue_t *) elem;
> -        fprintf (xcsv_file.xcsvfp, "%s%s", ogp->val, 
> xcsv_file.record_delimiter);
> +       char *ol;
> +       ogp = (ogue_t *) elem;
> +
> +       ol = strsub(ogp->val, "__FILE__", xcsv_file.fname);

Should we document this horror in the README.csv stuff?

> Index: style/custom.style
> ===================================================================
> RCS file: /cvsroot/gpsbabel/gpsbabel/style/custom.style,v
> retrieving revision 1.3
> diff -p -u -r1.3 custom.style
> --- style/custom.style	2 Mar 2003 01:41:45 -0000	1.3
> +++ style/custom.style	12 Aug 2003 14:11:30 -0000
> @@ -17,7 +17,7 @@ BADCHARS		COMMA
>  #
>  # HEADER STUFF:
>  #
> -PROLOGUE	Prologue Line 1
> +PROLOGUE	Prologue Line 1 __FILE__

I just did that for testing.   It's your call whether to keep that or not.


Thanx!

RJL