Thread: [Gpsbabel-code] m241 and m241-bin is mis-interpreted as GR245
Brought to you by:
robertl
From: Camus L. <cam...@gm...> - 2009-12-22 03:42:18
|
In current setting of mtk_logger.c, it will wrongly parse the data as GR245 format and resulted wrong speed and height value. I suggest to change the line number 1404 as follows From: if ( mtk_device != HOLUX_GR245 ){ To: if ( (mtk_device != HOLUX_GR245) && ( memcmp(&buf[i], "HOLUXGR241", 10) != 0){ Thanks |
From: Stefan B. <yol...@fr...> - 2009-12-22 16:34:24
|
Am Dienstag 22 Dezember 2009 04:42:02 schrieb Camus Lai: > In current setting of mtk_logger.c, it will wrongly parse the data as GR245 > format and resulted wrong speed and height value. I suggest to change the > line number 1404 as follows > > From: > > if ( mtk_device != HOLUX_GR245 ){ > > > > To: > > if ( (mtk_device != HOLUX_GR245) && ( memcmp(&buf[i], "HOLUXGR241", > 10) != 0){ Looks senseful, but could you please post the binary file taken from the device somewhere one can download it to have a test case? Regards, Stefan |
From: Camus L. <cam...@gm...> - 2009-12-23 01:58:02
|
I have post a data file in the bug tracker. Camus Lai Sent on a handheld On 23 Dec 2009, at 12:34 AM, Stefan Bauer <yol...@fr...> wrote: > Am Dienstag 22 Dezember 2009 04:42:02 schrieb Camus Lai: >> In current setting of mtk_logger.c, it will wrongly parse the data >> as GR245 >> format and resulted wrong speed and height value. I suggest to >> change the >> line number 1404 as follows >> >> From: >> >> if ( mtk_device != HOLUX_GR245 ){ >> >> >> >> To: >> >> if ( (mtk_device != HOLUX_GR245) && ( memcmp(&buf[i], >> "HOLUXGR241", >> 10) != 0){ > > Looks senseful, but could you please post the binary file taken from > the > device somewhere one can download it to have a test case? > > Regards, Stefan > > --- > --- > --- > --------------------------------------------------------------------- > This SF.Net email is sponsored by the Verizon Developer Community > Take advantage of Verizon's best-in-class app development support > A streamlined, 14 day to market process makes app distribution fast > and easy > Join now and get one step closer to millions of Verizon customers > http://p.sf.net/sfu/verizon-dev2dev > _______________________________________________ > Gpsbabel-code mailing list http://www.gpsbabel.org > Gps...@li... > https://lists.sourceforge.net/lists/listinfo/gpsbabel-code |
From: P. B. <e4b...@ya...> - 2009-12-22 19:16:16
|
Hi, this seems a bit strange to me, I would suggest a more proper change on line 1403 instead, otherwise the parse would be off by 4 bytes.. -if ( memcmp(&buf[i+16], " ", 4) == 0 ){ // Assume loglen >= 20... +if ( memcmp(buf, "HOLUXGR245", 10) == 0 && memcmp(&buf[i+16], " ", 4) == 0 ){ // Assume loglen >= 20... This is very untested... /devlin > In current setting of mtk_logger.c, it will > wrongly parse the data as GR245 format and resulted wrong > speed and height value. I suggest to change the line number > 1404 as follows > From: > > if ( mtk_device != HOLUX_GR245 ){ > > > To: > > if ( (mtk_device != HOLUX_GR245) && (memcmp(&buf[i], "HOLUXGR241", 10) != 0){ > > > Thanks |
From: Camus L. <cam...@gm...> - 2009-12-23 02:00:36
|
Both 241 and 245 have this 4 byte of space. We need this line to skip thought them. Camus Lai Sent on a handheld On 23 Dec 2009, at 3:16 AM, "P. Borgentun" <e4b...@ya...> wrote: > Hi, > this seems a bit strange to me, I would suggest a more proper > change on line 1403 instead, otherwise the parse would be off > by 4 bytes.. > > -if ( memcmp(&buf[i+16], " ", 4) == 0 ){ // Assume loglen >= 20... > > +if ( memcmp(buf, "HOLUXGR245", 10) == 0 && memcmp(&buf[i+16], " > ", 4) == 0 ){ // Assume loglen >= 20... > > This is very untested... > /devlin > >> In current setting of mtk_logger.c, it will >> wrongly parse the data as GR245 format and resulted wrong >> speed and height value. I suggest to change the line number >> 1404 as follows >> From: >> >> if ( mtk_device != HOLUX_GR245 ){ >> >> >> To: >> >> if ( (mtk_device != HOLUX_GR245) && (memcmp(&buf[i], >> "HOLUXGR241", 10) != 0){ >> >> >> Thanks > > > > > > > --- > --- > --- > --------------------------------------------------------------------- > This SF.Net email is sponsored by the Verizon Developer Community > Take advantage of Verizon's best-in-class app development support > A streamlined, 14 day to market process makes app distribution fast > and easy > Join now and get one step closer to millions of Verizon customers > http://p.sf.net/sfu/verizon-dev2dev > _______________________________________________ > Gpsbabel-code mailing list http://www.gpsbabel.org > Gps...@li... > https://lists.sourceforge.net/lists/listinfo/gpsbabel-code |