#136 Regression in camera_set_config

closed-fixed
None
5
2010-06-30
2010-06-29
No

Changeset 12511 introduced a regression in the camera_set_config code: after the first successful EOS property update, the loop bails out, i.e. from multiple widget updates only one gets propagated to the camera.

Discussion

  • The second patch improves consistency in the debugging output of the set/get_config code. It helped me identifying the regression. Both patches apply to head of the 2_4 branch.

     
    • assigned_to: nobody --> marcusmeissner
     
  • the improve debugging patch does not apply

    I applied the set/config one, well spotted!

     
  • I updated the debugging-output-cosmetic patch. should apply to 13104.

     
    • status: open --> closed-fixed
     
  • applied thanks!

     
  • You didn't like the config.c-part of the debugging patch? That was mainly about making the existing config related debugging output more consistent. The latter also showed me, that there seems to be a problem with the Color Space prooerty. But I didn't look into it yet:

    libgphoto2: Getting property 'Color Space' / 0xd10f
    libgphoto2: Failed to parse value of property 'Color Space' / 0xd10f: ret -1

     
  • probably forgot to commit yet (and still on hd at home)