From: SourceForge.net <no...@so...> - 2004-05-06 16:13:03
|
Patches item #947064, was opened at 2004-05-03 18:27 Message generated for change (Comment added) made by hfiguiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=947064&group_id=8874 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Ilguiz Latypov (ilgiz) Assigned to: Lee Benfield (leibnitz27) Summary: adding 1.3M Creative CardCam Initial Comment: I've added the specifics of my 1.3M Creative CardCam to the smalcamera driver in libgphoto2. The patch is attached. I assumed that the same BGGR Bayer mosaic type is used in the camera. The patch makes the gamma correction a default compile-time option for all smalcameras. To achieve a reliable communication, I had to enable pieces of unknown communication that were previously commented out. I modified them based on the Windows USB Snoopy traces. Unfortunately, the quality of the pictures isn't as good as produced by the Creative CardCam Album application. I played with gamma correction and various demosaicing algorithms from ImageCooker without any luck. I added the raw format option so that the raw PPM mosaic files can be downloaded from smalcameras. I haven't tested the impact of my changes common to the other smalcameras. I tried to keep these common changes to minimum. Meanwhile I will submit another patch to the ImageCooker (mrwtoppm) maintainer making bayer2tiff accept BGGR mosaic and adding a PPM v6 demosaicing wrapper script. ---------------------------------------------------------------------- >Comment By: Hubert Figuiere (hfiguiere) Date: 2004-05-06 18:13 Message: Logged In: YES user_id=27487 Ilguiz, If you need information, feel free to contact the manufacturer: http://www.smalcamera.com/ They are nice. I'm pretty sure that they'd be happy to provide you a few bits (like the type of bayer, etc.). Tell them it is for gphoto2. They know us (it is a long story actually, and I know of few people from the staff). ---------------------------------------------------------------------- Comment By: Ilguiz Latypov (ilgiz) Date: 2004-05-06 18:09 Message: Logged In: YES user_id=281701 The gamma correction option was previously ignored in the demosaic.sh. Attached is the patch to ImageCooker with the updated demosaic.sh. The images produced by demosaic.sh are all greenish. Looks like I made a mistake somewhere. ---------------------------------------------------------------------- Comment By: Ilguiz Latypov (ilgiz) Date: 2004-05-06 17:41 Message: Logged In: YES user_id=281701 Attached is the patch to ImageCooker http://www.ivydesign.com/ImageCooker/ ImageCooker is a set of open source tools to process Bayer mosaic files, mostly the ones from Minolta cameras. ImageCooker implements algorithms described in the comparison study of demosaicing algorithms, http://www-ise.stanford.edu/~tingchen/ One of the tools, bayer2tiff, is generic enough to apply to raw PPM mosaic files after small changes with regard to the assumed Bayer tile type. The patch also adds a wrapper script to process PPM v6 files. The original bayer2tiff utility only accepts PPM v3 files. Unfortunately, I wasn't able to see any significant improvement in perception of the processed pictures. This might be due to an incorrect CardCam mosaic tile type I assumed. ---------------------------------------------------------------------- Comment By: Hubert Figuiere (hfiguiere) Date: 2004-05-06 08:52 Message: Logged In: YES user_id=27487 Lee. Can you test that the patch works fine with your Camera since you originally wrote the driver. If that is OK, it is fine to commit. Thanks a lot. Note: I might commit it in a month or so if I don't get a reply. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=308874&aid=947064&group_id=8874 |