[gphoto-devel] canon: avoiding set_file_attribute error

[Wolfram S. <wo...@th...>]

Hi,

I'm back at the observatory. First, I can confirm that Marcus'
replacement of n_tries with timeouts in canon_usb_poll_interrupt_pipe()
[revision 14166, 8 months ago] works for me with a 5D and 350D. No more
OS communication errors. Hooray!

Still, I get this error (and see it plenty on the web):

===
10.159575 canon/canon/usb.c(2): canon_usb_dialogue_full: camera status "Unknown status code 0x82120022 from camera" in response to command 0x7 0x11 0x201 (Set file attributes (new)))
10.159595 context(0): canon_usb_set_file_attributes: canon_usb_dialogue failed

*** Error ***
canon_usb_set_file_attributes: canon_usb_dialogue failed
===

This is for a 5D, the 350D returns 0x00000086 ("Can't unlock EOS keys
 (new)"). While debugging, I noticed that my attributes are all 0, so
I wondered if it makes sense to issue the command at all? And while I
was at it, the logic for STATUS_DOWNLOADED seems wrong, see attached
patch. This does not technically solve the problem but seems worth to
have nonetheless?

Regards,

   Wolfram