[Goom] patch from goom integration into xine

[Michael R. <mr...@us...>]

Hi goom team,

I hope this is the right list for my mail. If not, please tell me, where to 
turn to.

This is Michael Roitzsch from the xine team. As you might know, xine is using 
goom to present those nifty effects of yours for audio-only files. Since it 
is our policy to make installation easy for the user, we included a copy of 
the goom code into xine-lib. Unfortunately, this copy received some patches 
and fixes and was starting to drift from the original version, making future 
merges of new goom releases more difficult. To resolve this, I decided to 
include the current goom2k4-dev15 into xine-lib and ported all the patches to 
this new version.

Now I would like to ask, if some, maybe even all of these changes could be 
applied to your official goom tree. I attached a patch containing all our 
changes to far. It fixes three things:
* make goom silent
  This is the biggest and probably most unimportant part of the patch. It
  wraps those printfs I saw when running goom in xine, because xine-lib should
  be silent on the console.
  This part of the patch might be a problem, because some of the files I
  modified appear to be the output of flex/bison, so one actually has to patch
  the input files to these tools. But since I know next to nothing about
  flex/bison (I know just enough to avoid it... ;) ), I did not try that.
* fix goom on AMD64
  On several occasions, goom casts pointers to int. This is bad, because it
  breaks AMD64 and other 64 bit platforms. We fixed these by using a C99
  inttype.
* fix a memleak
  The free_ifs() added in ifs.c fixes a memory leak.

If there is a chance that this patch could find its way into the official 
tree, I would like to start work on yet another patch: Goom compilation 
inside xine-lib emits quite a lot of compiler warnings which I would like to 
fix.

Michael

-- 
"Unix? What's that? Is that like Linux?"