From: Colin A. <col...@go...> - 2009-05-03 09:14:52
|
The contract for the routine is correct (the preconditions do not exclude a string which includes escapes represnting a non-valid UTF-8 byte sequence, such as Latin-1 bytes, or just pure garbage). There is a test that unescape_string returns no byte greater than 255 - I think this is redundant (but it would need a postcondition on unescape_string to make it secure), but this is not relevant to the issue in hand. So the clients need changing to accept the possibility of a Void result. I'll look into this on Wednesday (or possibly Tuesday if I have more time than expected). 2009/5/2 Colin Paul Adams <co...@co...>: >>>>>> "Eric" == Eric Bezault <er...@go...> writes: > > Eric> Hi Colin, On January 18, 2007, in commit svn#5840, you > Eric> changed the implementation and contracts of feature > Eric> `unescaped_utf8' in UT_URL_ENCODING. However, after this > Eric> change of contracts, it looks like you didn't update its > Eric> callers. For example feature `decoded_utf8' in class > Eric> UT_URI_STRING, and hence its callers, still rely on the fact > Eric> that the result of `unescaped_utf8' is supposed to be > Eric> non-void. > > Eric> Can you have a look at that? This is a bug which is blocking > Eric> the conversion of Gobo to void-safe mode. > > I'll take a look early next week. > -- > Colin Adams > Preston Lancashire > > ------------------------------------------------------------------------------ > Register Now & Save for Velocity, the Web Performance & Operations > Conference from O'Reilly Media. Velocity features a full day of > expert-led, hands-on workshops and two days of sessions from industry > leaders in dedicated Performance & Operations tracks. Use code vel09scf > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > _______________________________________________ > gobo-eiffel-develop mailing list > gob...@li... > https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop > |