Re: [gobo-eiffel-develop] Binary search tree

[Eric B. <er...@go...>]

Hi Daniel,

Your binary search tree classes are now committed to SVN in
the SourceForge Gobo project. As agreed, I made some name
changes and some header comments and reformatting to better
match Gobo's style guildelines. I also removed the unnecessary
`void_is_valid_key' and merged `equality_tester' with `comparator'.
I probably did some other minor changes, such as making sure
that "key" features are not exported in the set classes
(set classes don't have the notion of keys in their interface).

I didn't review the binary search tree algorithms. But I think
that some improvements can be made. For example, would it be
possible to redefine `cursor_search_forth' and `cursor_search_back'
in DS_BINARY_SEARCH_TREE_SET, to take advantage that the items
are sorted, and hence avoid linear traversal?

Also, I think that `internal_put' and `internal_put_new' deserve
some postconditions that should match those of DS_SET and DS_TABLE
so that when they are used to implement the corresponding features
in set and table variants the code is correct in terms of DbC.

-- 
Eric Bezault
mailto:er...@go...
http://www.gobosoft.com