Re: [gobo-eiffel-develop] [ gobo-eiffel-Bugs-1830026 ] Precondition violated in XM_XSLT_OUTPUT_ENCODER

[Eric B. <er...@go...>]

Hi Colin,

I'm not sure why you chose to change the status of this issue to
Pending, but apparently the Bug Tracker closes any Pending issue
after a certain period. Perhaps it's better to keep your issues
Open to avoid such problem.


SourceForge.net wrote:
> Bugs item #1830026, was opened at 2007-11-11 09:40
> Message generated for change (Comment added) made by sf-robot
> You can respond by visiting: 
> https://sourceforge.net/tracker/?func=detail&atid=381937&aid=1830026&group_id=24591
> 
> Please note that this message will contain a full copy of the comment thread,
> including the initial issue submission, for this request,
> not just the latest update.
> Category: xslt
> Group: trunk
>> Status: Closed
> Resolution: Fixed
> Priority: 5
> Private: No
> Submitted By: Eric Bezault (ericb)
> Assigned to: Colin Paul Adams (colin-adams)
> Summary: Precondition violated in XM_XSLT_OUTPUT_ENCODER
> 
> Initial Comment:
> This bug report supercede bug#1829999.
> 
> When running 'geant -Dabort test_debug_se' in $GOBO/test/xml/xslt I get the exception trace below. From what I can see, it looks like we call XM_XSLT_OUTPUT_ENCODER.is_valid_string with a string that contains a Null character. This routine then calls `is_bad_character_code' which has a precondition `is_char'. But `is_char' returns False when the code is zero. So my guess is that either `is_char' should return True when the code is zero, or `is_valid_string' should make sure to call `is_bad_character_code' only after having checked that `is_char' holds (or both).
> 
> ----------------------------------------------------------------------
> 
>> Comment By: SourceForge Robot (sf-robot)
> Date: 2008-02-02 19:20
> 
> Message:
> Logged In: YES 
> user_id=1312539
> Originator: NO
> 
> This Tracker item was closed automatically by the system. It was
> previously set to a Pending status, and the original submitter
> did not respond within 14 days (the time period specified by
> the administrator of this Tracker).
> 
> ----------------------------------------------------------------------
> 
> Comment By: Colin Paul Adams (colin-adams)
> Date: 2008-01-18 11:59
> 
> Message:
> Logged In: YES 
> user_id=732953
> Originator: NO
> 
> The fix revealed another problem - NULLs were actually getting written out
> in a few scenarios, so further fixing was necessary.
> 
> ----------------------------------------------------------------------
> 
> Comment By: Colin Paul Adams (colin-adams)
> Date: 2008-01-14 13:07
> 
> Message:
> Logged In: YES 
> user_id=732953
> Originator: NO
> 
> Zero is not a legitimate character code, even in XML 1.1.
> 
> So I shall add a check for containing a NULL prior to calling
> is_bad_character_code.
> 
> ----------------------------------------------------------------------
> 
> Comment By: Eric Bezault (ericb)
> Date: 2007-11-11 09:43
> 
> Message:
> Logged In: YES 
> user_id=13278
> Originator: YES
> 
> Here is the relevant part of the exception trace:
> 
> ======================================
> output XM_XSLT_XML_EMITTER
> Current = XM_XSLT_HTML_EMITTER#05C23330
>         [ document_uri = Void
>           base_uri = ""
>           is_open = True
>           is_document_started = True
>           is_written = True
>           outputter = #072089A8
>           output_properties = #052A4940
>           is_error = False
>           serializer = #052E8EB8
>           is_no_declaration_on_close = False
>           element_qname_stack = #0543BAE4
>           is_well_formed_document_required = False
>           is_output_open = True
>           is_declaration_written = False
>           is_empty = False
>           is_open_start_tag = True
>           raw_outputter = #05377690
>           encoder_factory = #046AC428
>           encoding = "ISO-8859-1"
>           current_element_name_code = 3273
>           is_hex_preferred = False
>           allow_undeclare_prefixes = False
>           name_lookup_table = #04629FF8
>           name_lookup_table_size = 0
>           media_type = "text/html"
>           escape_uri_attributes = True
>           non_ascii_representation = 2
>           excluded_representation = 3
>           in_script = -999998
>           element_name = "img"
>           element_uri_code = 0
>         ]
> a_character_string = "%U../image/previous.gif%U"
> line 565 column 28 file
> C:\DriveE\gobo\gobo\library\xml\xslt\serializer\xm_xslt_
> xml_emitter.e
> ======================================
> <late-binding-wrapper> is_valid_string
> ======================================
> is_valid_string XM_XSLT_OUTPUT_ENCODER
> Current = XM_XSLT_LATIN1_ENCODER#072089A8
>         [ encoding = "ISO-8859-1"
>           outputter = #05377690
>           is_error = False
>         ]
> a_character_string = "%U../image/previous.gif%U"
> Result = True
> an_index = 1
> line 74 column 9 file
> C:\DriveE\gobo\gobo\library\xml\xslt\serializer\xm_xslt_ou
> tput_encoder.e
> ======================================
> is_bad_character_code XM_XSLT_LATIN1_ENCODER
> Current = XM_XSLT_LATIN1_ENCODER#072089A8
>         [ encoding = "ISO-8859-1"
>           outputter = #05377690
>           is_error = False
>         ]
> a_code = 0
> Result = False
> line 56 column 26 file
> C:\DriveE\gobo\gobo\library\xml\xslt\serializer\xm_xslt_o
> utput_encoder.e
> =====   Top of run-time stack    =====
> Exception number 9 not handled.
> Precondition (require clause) failed.
> 
> ----------------------------------------------------------------------
> 
> You can respond by visiting: 
> https://sourceforge.net/tracker/?func=detail&atid=381937&aid=1830026&group_id=24591
> 
> 
> 


-- 
Eric Bezault
mailto:er...@go...
http://www.gobosoft.com