Re: [gobo-eiffel-develop] Perverse bug with gec?

[Colin P. A. <co...@co...>]

>>>>> "Eric" == Eric Bezault <er...@go...> writes:

    Eric> Colin Paul Adams wrote:
    >>>>>>> "Eric" == Eric Bezault <er...@go...> writes:
    >> 
    >> 
    Eric> I can see one difference between ISE and Gobo when opening
    Eric> the file under Linux/Unix. When opening a binary file, Gobo
    Eric> does "rb" (same as Windows) whereas ISE does "r" for the
    Eric> mode. I guess this is the problem. I will fix that and we
    Eric> will see how it goes. In the meantime I'd be interested if
    Eric> you could have a look at the manpage for fopen() on Linux
    Eric> and see if there is anything specified for "rb" (like "open
    Eric> the file in case-insensitive mode" ;-)).
    >> 
    >> It says:
    >> 
    >> " The mode string can also include the letter b either as a
    >> last character or as a character between the characters in any
    >> of the two- character strings described above.  This is
    >> strictly for compatibility with C89 and has no effect; the b is
    >> ignored on all POSIX conform- ing systems, including Linux.
    >> (Other systems may treat text files and binary files
    >> differently, and adding the b may be a good idea if you do I/O
    >> to a binary file and expect that your program may be ported to
    >> non-Unix environments.)  "
    >> 


    Eric> OK. Just to double-check, can you try to remove the "b"s anyway
    Eric> in function 'file_open_mode' in
    Eric> $GOBO/tool/gec/runtime/c/eif_file.c and recompile your
    Eric> program (no need to recompile gec itself)?  Perhaps the
    Eric> "compatibility" goes up to the point where filenames are
    Eric> considered case-insensitive. Who knows.

To my surprise, it does the trick.
Shall I check it in? 
If the answer is yes, which tests do I need to run?
-- 
Colin Adams
Preston Lancashire