From: Eric B. <er...@go...> - 2007-02-24 16:22:13
|
Colin Paul Adams wrote: >>>>>> "Eric" == Eric Bezault <er...@go...> writes: > > Eric> For consistency with > Eric> `is_hexadecimal' I would name the old feature `is_decimal' > Eric> (rather than `is_decimal_digits'). > > OK. > And perhaps the header comment should explain that it returns True > only if every character is a decimal digit from the ASCII block of > Unicode (there are other sets of decimal digits). OK. That's what the ELKS spec for `is_integer' does: http://www.gobosoft.com/eiffel/nice/elks01/string.html#is_integer I wonder whether ISE (and hence FreeELKS) accepts leading and trailing spaces. > Eric> what is in ELKS for `is_integer' to see how we can apply it > Eric> to `is_integer_64'. As far as I can see, none of those > Eric> accepts underscores (unlike Eiffel INTEGER_64 literals). > > What about leading +/-? They're accepted. > >> But then we have an inconsistent story with is_integer. Can we > >> rename this to is_decimal_digits? This will break existing > >> clients, so we can only do that if the next Gobo release is > >> numbered 4.0 (there is a precedent in that the upgrade from 2.0 > >> to 3.0 broke some existing clients). > > Eric> Do we need to break code now, or go to the "obsolete" stage > Eric> before? > > I guess we can define is_decimal as a duplicate of is_integer for now, > and mark is_integer as obsolete for the next release. Yes. -- Eric Bezault mailto:er...@go... http://www.gobosoft.com |