From: Colin A. <col...@go...> - 2008-04-15 17:43:07
|
I have just implemented the following routine: draw_text (x, y: INTEGER; a_text: STRING_GENERAL) is -- Draw `a_text' with left of baseline at (`x', `y') using `font'. local l_element: XM_ELEMENT l_attribute: XM_ATTRIBUTE l_text: XM_CHARACTER_DATA l_bytes: STRING l_utf8: UC_UTF8_STRING do create l_element.make_last (document.root_element, Svg_text, Svg_namespace) create l_element.make_last (Svg_x_attribute, Svg_namespace, x.out, l_element) create l_element.make_last (Svg_y_attribute, Svg_namespace, (-y).out, l_element) add_font_attributes (l_element) if a_text.is_string_8 then create l_text.make_last (l_element, a_text.as_string_8) else create l_bytes.make (a_text.count * 4) from i := 1 until i > a_text.count loop utf8.append_code_to_utf8 (l_bytes, a_text.item_code (i)) i := i + 1 end create l_utf8.make_from_utf8 (l_bytes) create l_text.make_last (l_element, l_utf8) end end We need a make_from_utf32 (or some such routine) in UC_STRING (or alternatively let XM_CHARACTER_DATA accept a STRING_GENEAL, or prefereably both). |
From: Eric B. <er...@go...> - 2008-04-18 13:13:19
|
Colin Adams wrote: > We need a make_from_utf32 (or some such routine) in UC_STRING (or > alternatively let XM_CHARACTER_DATA accept a STRING_GENEAL, or > prefereably both). I guess it's OK now to use STRING_GENERAL. Daniel never answered our messages about the future of SE 1.2 and his plans about ECMA Eiffel. So I guess that's the end of the story. Note that we will probably have a new release of Gobo in about two weeks from now (so, without support for SE 1.2) so that it will be ready at about the same time as the next release of EiffelStudio. -- Eric Bezault mailto:er...@go... http://www.gobosoft.com |
From: Colin A. <col...@go...> - 2008-04-18 13:41:02
|
Then it is time for you to decide what I have to do about the implementation of the XSLT time/date formatting functions that I moved to the time library. Options are: * Leave them in the time library. * Move them back to the XSLT library. * Move them to the string library (there is already a cluster for formatting strings there, so that makes some kind of sense). * Create a new library for them. I have a routine to create UC_UTF8_STRING from STRING_GENERAL (at the moment it is a function, but I could turn it into a creation procedure and put it into Gobo). Shall I submit it to the list for inspection? On 18/04/2008, Eric Bezault <er...@go...> wrote: > Colin Adams wrote: > > > We need a make_from_utf32 (or some such routine) in UC_STRING (or > > alternatively let XM_CHARACTER_DATA accept a STRING_GENEAL, or > > prefereably both). > > > > I guess it's OK now to use STRING_GENERAL. > > Daniel never answered our messages about the future of > SE 1.2 and his plans about ECMA Eiffel. So I guess that's > the end of the story. > > Note that we will probably have a new release of Gobo > in about two weeks from now (so, without support for > SE 1.2) so that it will be ready at about the same time > as the next release of EiffelStudio. > > -- > Eric Bezault > mailto:er...@go... > http://www.gobosoft.com > |
From: Eric B. <er...@go...> - 2008-04-18 14:03:26
|
Colin Adams wrote: > Then it is time for you to decide what I have to do about the > implementation of the XSLT time/date formatting functions that I moved > to the time library. > > Options are: > > * Leave them in the time library. > * Move them back to the XSLT library. > * Move them to the string library (there is already a cluster for > formatting strings there, so that makes some kind of sense). > * Create a new library for them. I need to remember what was the problem. Was it a new dependency between 'date' and 'xml'? > I have a routine to create UC_UTF8_STRING from STRING_GENERAL (at the > moment it is a function, but I could turn it into a creation procedure > and put it into Gobo). Shall I submit it to the list for inspection? OK. -- Eric Bezault mailto:er...@go... http://www.gobosoft.com |
From: Colin P. A. <co...@co...> - 2008-04-18 14:21:14
|
>>>>> "Eric" == Eric Bezault <er...@go...> writes: Eric> Colin Adams wrote: >> Then it is time for you to decide what I have to do about the >> implementation of the XSLT time/date formatting functions that >> I moved to the time library. >> >> Options are: >> >> * Leave them in the time library. * Move them back to the XSLT >> library. * Move them to the string library (there is already a >> cluster for formatting strings there, so that makes some kind >> of sense). * Create a new library for them. Eric> I need to remember what was the problem. Was it a new Eric> dependency between 'date' and 'xml'? I introduced new dependencies for the date/time library on the regular expression library (which I promptly removed when you said that the time library should be small) and the math library, and the string/unicode sub-library (there is no way that this dependency can be eliminated) and the structure library. -- Colin Adams Preston Lancashire |
From: Colin P. A. <co...@co...> - 2008-04-18 14:50:37
|
>>>>> "Eric" == Eric Bezault <er...@go...> writes: Eric> What is the disadvantage in moving it back to the XSLT Eric> library? I understand that this is used at AXAR, but Eric> everything in Gobo is included in the ECF file anyway. The only disadvantage I can think of is for people like Peter Gummer, who avoid the entire XML library to reduce compile time. The date formatting functionality is really very attractive, and has no relationship with XML other than it was formulated by the XSLT working group. This is why I would favour putting it in a new cluster string/date. -- Colin Adams Preston Lancashire |
From: Colin P. A. <co...@co...> - 2008-04-19 13:56:48
|
>>>>> "Colin" == Colin Paul Adams <co...@co...> writes: >>>>> "Eric" == Eric Bezault <er...@go...> writes: Eric> formatting classes in 'date' library. I guess moving it to Eric> string/date should be OK. I would hope that the library Eric> 'math' does not depend on 'string'. Colin> It's library.xace shows no indication of a dependency. More Colin> significantly, the system.xace for it's tests does not Colin> include the string/library.xace, and decisively, nor does Colin> the generated ge.xace in that test cluster. Colin> So I will go ahead with this move. Done, and committed. -- Colin Adams Preston Lancashire |
From: Eric B. <er...@go...> - 2008-04-18 14:25:56
|
Colin Paul Adams wrote: >>>>>> "Eric" == Eric Bezault <er...@go...> writes: > > Eric> Colin Adams wrote: > >> Then it is time for you to decide what I have to do about the > >> implementation of the XSLT time/date formatting functions that > >> I moved to the time library. > >> > >> Options are: > >> > >> * Leave them in the time library. * Move them back to the XSLT > >> library. * Move them to the string library (there is already a > >> cluster for formatting strings there, so that makes some kind > >> of sense). * Create a new library for them. > > Eric> I need to remember what was the problem. Was it a new > Eric> dependency between 'date' and 'xml'? > > I introduced new dependencies for the date/time library on the regular > expression library (which I promptly removed when you said that the > time library should be small) and the math library, and the > string/unicode sub-library (there is no way that this dependency can > be eliminated) and the structure library. What is the disadvantage in moving it back to the XSLT library? I understand that this is used at AXAR, but everything in Gobo is included in the ECF file anyway. -- Eric Bezault mailto:er...@go... http://www.gobosoft.com |
From: Eric B. <er...@go...> - 2008-04-18 15:37:31
|
Colin Paul Adams wrote: >>>>>> "Eric" == Eric Bezault <er...@go...> writes: > > Eric> What is the disadvantage in moving it back to the XSLT > Eric> library? I understand that this is used at AXAR, but > Eric> everything in Gobo is included in the ECF file anyway. > > The only disadvantage I can think of is for people like Peter Gummer, > who avoid the entire XML library to reduce compile time. The date > formatting functionality is really very attractive, and has no > relationship with XML other than it was formulated by the XSLT working > group. > > This is why I would favour putting it in a new cluster string/date. In term of dependency, what I would really like to avoid is to have a library A which depends (directly or indirectly) on library B and library B which depends on library A. As you already pointed out, library 'string' already depends on 'date', so if we follow this policy we cannot leave the XSLT formatting classes in 'date' library. I guess moving it to string/date should be OK. I would hope that the library 'math' does not depend on 'string'. -- Eric Bezault mailto:er...@go... http://www.gobosoft.com |
From: Colin P. A. <co...@co...> - 2008-04-18 17:05:25
|
>>>>> "Eric" == Eric Bezault <er...@go...> writes: Eric> formatting classes in 'date' library. I guess moving it to Eric> string/date should be OK. I would hope that the library Eric> 'math' does not depend on 'string'. It's library.xace shows no indication of a dependency. More significantly, the system.xace for it's tests does not include the string/library.xace, and decisively, nor does the generated ge.xace in that test cluster. So I will go ahead with this move. -- Colin Adams Preston Lancashire |
From: Eric B. <er...@go...> - 2008-04-22 08:12:29
|
Colin Paul Adams wrote: >>>>>> "Colin" == Colin Paul Adams <co...@co...> writes: > >>>>>> "Eric" == Eric Bezault <er...@go...> writes: > Eric> formatting classes in 'date' library. I guess moving it to > Eric> string/date should be OK. I would hope that the library > Eric> 'math' does not depend on 'string'. > > Colin> It's library.xace shows no indication of a dependency. More > Colin> significantly, the system.xace for it's tests does not > Colin> include the string/library.xace, and decisively, nor does > Colin> the generated ge.xace in that test cluster. > > Colin> So I will go ahead with this move. > > Done, and committed. I get this assertion violation when compiling the xslt tests with ISE 5.7 with assertions on. Test Summary for xslt # Passed: 83 tests # Failed: 0 test # ABORTED: 1 test # Total: 84 tests (453 assertions) Test Results: ABORT: [XM_XSLT_TEST_BOOKS.test_transform] Eiffel exception ------------------------------------------------------------------------------- Class / Object Routine Nature of exception Effect ------------------------------------------------------------------------------- ST_XSD_DATE_TIME_FORMAT zoned_date_time_to_string @9 valid_zoned_date_time_string: <0000000003EAFE88> Postcondition violated. Fail ------------------------------------------------------------------------------- ST_XSD_DATE_TIME_FORMAT zoned_date_time_to_string @4 <0000000003EAFE88> Routine failure. Fail ------------------------------------------------------------------------------- XM_XPATH_DATE_TIME_VALUE string_value @4 <0000000003EAF488> Routine failure. Fail ------------------------------------------------------------------------------- XM_XPATH_DATE_TIME_VALUE convert_to_type @6 <0000000003EAF488> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_CONTENT_CONSTRUCTOR evaluate_item @15 <0000000003C919F0> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_VALUE_OF expand_children @8 <0000000003C91980> (From XM_XSLT_TEXT_CONSTRUCTOR) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_VALUE_OF evaluate_item @8 <0000000003C91980> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_VALUE_OF create_iterator @5 <0000000003C91980> (From XM_XSLT_TEXT_CONSTRUCTOR) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_VALUE_OF create_node_iterator @5 <0000000003C91980> (From XM_XSLT_INSTRUCTION) Routine failure. Fail ------------------------------------------------------------------------------- XM_XPATH_BLOCK_NODE_ITERATOR forth @18 <0000000003EAE928> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_CONTENT_CONSTRUCTOR evaluate_sequence @48 <0000000003C916F8> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_CONTENT_CONSTRUCTOR evaluate_item @24 <0000000003C916F8> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_COMMENT expand_children @8 <0000000003C91690> (From XM_XSLT_TEXT_CONSTRUCTOR) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_COMMENT generate_tail_call @6 <0000000003C91690> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_BLOCK generate_tail_call @13 <0000000003C915F0> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_BLOCK generate_events @8 <0000000003C915F0> (From XM_XSLT_INSTRUCTION) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_FIXED_ELEMENT generate_tail_call @26 <0000000003C91570> (From XM_XSLT_ELEMENT_CONSTRUCTOR) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_TEMPLATE expand @6 <0000000003C91540> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_COMPILED_TEMPLATE generate_tail_call @8 <0000000003C91540> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TRANSFORMER apply_templates_2 @25 <0000000003D0E0B0> (From XM_XSLT_TEMPLATE_ROUTINES) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TRANSFORMER apply_templates @33 <0000000003D0E0B0> (From XM_XSLT_TEMPLATE_ROUTINES) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TRANSFORMER perform_transformation @10 <0000000003D0E0B0> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TRANSFORMER transform_document @24 <0000000003D0E0B0> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TRANSFORMER transform @71 <0000000003D0E0B0> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TEST_BOOKS test_transform @17 <0000000004A41D18> Routine failure. Fail ------------------------------------------------------------------------------- PROCEDURE fast_call <0000000004A41D88> Routine failure. Fail ------------------------------------------------------------------------------- PROCEDURE call @3 <0000000004A41D88> Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TEST_BOOKS execute_without_rescue @4 <0000000004A41D18> (From TS_TEST_CASE) Routine failure. Fail ------------------------------------------------------------------------------- XM_XSLT_TEST_BOOKS execute_with_rescue @3 <0000000004A41D18> (From TS_TEST_CASE) Routine failure. Retry =============================================================================== -- Eric Bezault mailto:er...@go... http://www.gobosoft.com |
From: Colin A. <col...@go...> - 2008-04-22 10:54:51
|
I just tried it and it passes (ISE 5.7 on Windows, after doing an svn update). On 22/04/2008, Eric Bezault <er...@go...> wrote: > I get this assertion violation when compiling the xslt > tests with ISE 5.7 with assertions on. > > Test Summary for xslt > > # Passed: 83 tests > # Failed: 0 test > # ABORTED: 1 test > # Total: 84 tests (453 assertions) > > Test Results: > ABORT: [XM_XSLT_TEST_BOOKS.test_transform] Eiffel exception > ------------------------------------------------------------------------------- > Class / Object Routine Nature of exception > Effect > ------------------------------------------------------------------------------- > ST_XSD_DATE_TIME_FORMAT > zoned_date_time_to_string @9 > valid_zoned_date_time_string: > <0000000003EAFE88> Postcondition violated. > Fail > ------------------------------------------------------------------------------- > ST_XSD_DATE_TIME_FORMAT > zoned_date_time_to_string @4 > <0000000003EAFE88> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XPATH_DATE_TIME_VALUE > string_value @4 > <0000000003EAF488> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XPATH_DATE_TIME_VALUE > convert_to_type @6 > <0000000003EAF488> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_CONTENT_CONSTRUCTOR > evaluate_item @15 > <0000000003C919F0> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_VALUE_OF > expand_children @8 > <0000000003C91980> (From XM_XSLT_TEXT_CONSTRUCTOR) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_VALUE_OF > evaluate_item @8 > <0000000003C91980> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_VALUE_OF > create_iterator @5 > <0000000003C91980> (From XM_XSLT_TEXT_CONSTRUCTOR) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_VALUE_OF > create_node_iterator @5 > <0000000003C91980> (From XM_XSLT_INSTRUCTION) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XPATH_BLOCK_NODE_ITERATOR > forth @18 > <0000000003EAE928> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_CONTENT_CONSTRUCTOR > evaluate_sequence @48 > <0000000003C916F8> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_CONTENT_CONSTRUCTOR > evaluate_item @24 > <0000000003C916F8> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_COMMENT > expand_children @8 > <0000000003C91690> (From XM_XSLT_TEXT_CONSTRUCTOR) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_COMMENT > generate_tail_call @6 > <0000000003C91690> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_BLOCK generate_tail_call @13 > <0000000003C915F0> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_BLOCK generate_events @8 > <0000000003C915F0> (From XM_XSLT_INSTRUCTION) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_FIXED_ELEMENT > generate_tail_call @26 > <0000000003C91570> (From XM_XSLT_ELEMENT_CONSTRUCTOR) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_TEMPLATE > expand @6 > <0000000003C91540> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_COMPILED_TEMPLATE > generate_tail_call @8 > <0000000003C91540> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TRANSFORMER apply_templates_2 @25 > <0000000003D0E0B0> (From XM_XSLT_TEMPLATE_ROUTINES) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TRANSFORMER apply_templates @33 > <0000000003D0E0B0> (From XM_XSLT_TEMPLATE_ROUTINES) > Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TRANSFORMER perform_transformation @10 > <0000000003D0E0B0> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TRANSFORMER transform_document @24 > <0000000003D0E0B0> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TRANSFORMER transform @71 > <0000000003D0E0B0> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TEST_BOOKS test_transform @17 > <0000000004A41D18> Routine failure. > Fail > ------------------------------------------------------------------------------- > PROCEDURE fast_call > <0000000004A41D88> Routine failure. > Fail > ------------------------------------------------------------------------------- > PROCEDURE call @3 > <0000000004A41D88> Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TEST_BOOKS execute_without_rescue @4 > <0000000004A41D18> (From TS_TEST_CASE) Routine failure. > Fail > ------------------------------------------------------------------------------- > XM_XSLT_TEST_BOOKS execute_with_rescue @3 > <0000000004A41D18> (From TS_TEST_CASE) Routine failure. > Retry > =============================================================================== > > > -- > Eric Bezault > mailto:er...@go... > http://www.gobosoft.com > > ------------------------------------------------------------------------- > This SF.net email is sponsored by the 2008 JavaOne(SM) Conference > Don't miss this year's exciting event. There's still time to save $100. > Use priority code J8TL2D2. > http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone > _______________________________________________ > gobo-eiffel-develop mailing list > gob...@li... > https://lists.sourceforge.net/lists/listinfo/gobo-eiffel-develop > |
From: Eric B. <er...@go...> - 2008-04-22 15:52:23
|
Colin Adams wrote: > I just tried it and it passes (ISE 5.7 on Windows, after doing an svn update). Hmm, this is strange: I ran the test again (no need to run svn update as I was already up-to-date) and now the test succeeds. Weird! -- Eric Bezault mailto:er...@go... http://www.gobosoft.com |