#171 Warn if commands follow "load" command

closed-accepted
nobody
None
5
2005-07-17
2005-05-29
No

All commands leading "load" on the same line are silently ignored. The
patch load_ceck-*.patch issues a warning when this happens.

Both sprintf and gprintf cut their results to 79 characters, again
without warning. The second patch, printf_check-*.patch gives a
message if the resulting string reaches this limit.

Juergen

Discussion

  • Ethan Merritt

    Ethan Merritt - 2005-07-11
    • summary: Warn for cut text --> Warn if text preceeds "load" command
     
  • Ethan Merritt

    Ethan Merritt - 2005-07-11

    Logged In: YES
    user_id=235620

    sprintf and gprintf output buffers are now dynamically
    allocated, so no more 80 char limit on output length.

    As to the load_check patch, I'd rather see a fix to the
    underlying problem.

     
  • Hans-Bernhard Broeker

    Logged In: YES
    user_id=27517

    The summary line was wrong, and the description easy to
    misunderstand. What gets ignored is commands *following* a
    'load' command, not commands preceding it. The reason for
    that is, once more, usage of global variables to keep the
    parsed command line. For 'load' to work, it has overwrites
    these, and there's nowhere to store the remainder of the
    current command line until after the 'load' command.

    This is a documented feature, i.e. it's not exactly a
    "problem" that absolutely has to be fixed. In the light of
    that, I think int_warn() is a good idea.

     
  • Hans-Bernhard Broeker

    • summary: Warn if text preceeds "load" command --> Warn if commands follow "load" command
     
  • Ethan Merritt

    Ethan Merritt - 2005-07-17
    • status: open --> closed-accepted
     
  • Ethan Merritt

    Ethan Merritt - 2005-07-17

    Logged In: YES
    user_id=235620

    OK. The "text ignored after load" patch is now in cvs.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks