#22 locking timer removed, tungsten support
Hi,
I've submitted a patch made by me and Alex
Smolyanov which includes a number of
changes:
- Removed locking timer, now keyring locks
upon exit or power-off. This fixes two
bugs (906399, 890751). In our opinion this
design is better because it doesn't
duplicate the system's functionality (Palm
OS has its own power-off timer) and allows
proper locking when switching
applications.
- Changed most of the forms from being
modal to using the application's event
loop. This was done so that powering the
device off will properly lock the
database. The 'Tips', delete conformation
and calendar control are still modal.
- Tungsten 5-way navigator support. This
change was based on the patch by John
Kirkland. Newer pilrc 3.0 and 5-Way
Navigator API SDK (can be found on
http://pluggedin.palmone.com\) are
required.
- The selection behavour in the list form
was improved to mimic the one in other
applications.
- Key fields on the edit form are displayed in bold.
- Hi-res lock/unlock icons were created
for colored devices. (They come as
separate files: lock.ppm, lock-8.ppm,
unlock.ppm, unlock-8.ppm and should be
places into the keyring directory).
I also added the binary so that the
changes could be tried out without
recompiling.
Logged In: YES
user_id=18252
It would be much easier to have the patches separated...
- Removed locking timer, now keyring locks upon exit or
power-off.
I agree that this design is much simpler and has the nice effect
that keyring is always locked when you can't see it any more.
OTOH it makes it impossible to quickly switch to another
application and back to copy information through the clipboard
or export multiple records as memo. I'm not sure whether
everyone likes this new behaviour
- Changed most of the forms from being modal to using the
application's event loop.
Okay, I have no problem with this patch.
- Tungsten 5-way navigator support.
I already applied John Kirklands patch (with a few modifications).
- The selection behaviour in the list form was improved
I'm not sure what you changed, but I will look over it again.
- Key fields on the edit form are displayed in bold.
For some translation the key names fit very tightly into the form.
I'm not sure whether bold ones would fit.
- Hi-res lock/unlock icons were created for colored devices.
This was easy to separate :) Patch is in CVS now.