Menu

#29 Fix MSVC compilation

Unstable_(example)
closed
None
5
2016-03-25
2016-03-25
Pete Batard
No

Commit 3dd05c and subsequent ones introduced the use of the GNU specific __attribute__((__unused__)), which breaks MSVC compilation...

I'll use this as a reminder that gnu-efi is compiled with more than GNU toolchains, and that contributors might want to be careful about adding GNU-specific extensions...

This patch does the following:

  • Create a new eficompiler.h header that sets all compiler-specific options and extensions
  • Create a new EFI_UNUSED macro to be used in lieu of __attribute__((__unused__)) and applies it to the relevant sources
  • Move the ALIGN(x) macro, previously defined in efisetjmp.h to the new header

Oh, and it also fixes a bunch of trailing whitespaces (because my code editor is set to do just that by default).

Hope this can be applied soon - thanks!

/Pete

1 Attachments

Discussion

  • Nigel Croxon

    Nigel Croxon - 2016-03-25
    • status: open --> closed
    • assigned_to: Nigel Croxon
     
  • Nigel Croxon

    Nigel Croxon - 2016-03-25

    Accepted and pushed to git tree.
    commit 5ff74ecae8b8452e3630bb00611fb610da72ac59

     
  • Pete Batard

    Pete Batard - 2016-03-25

    Much appreciated. Thanks!

     

Log in to post a comment.

MongoDB Logo MongoDB