Menu

#35 Wrong null-pointer check

v1.0_(example)
closed
None
5
2023-05-16
2023-05-10
No

Hello

Since commit [4f8b339facb471192e021fffd5db545a0fbddbc3] Make ELF constructors and destructors work, simple EFI tools like for example t.c from the apps directory crash.

The reason seems to be a wrong null-pointer check in the ctors()/dtors() functions in lib/entry.c:

        funcp func = *location;
-  if (location != NULL)
+  if (func != NULL)
                 func();

Related

Commit: [4f8b33]

Discussion

  • Nigel Croxon

    Nigel Croxon - 2023-05-16
    • status: open --> closed
    • assigned_to: Nigel Croxon
     
  • Nigel Croxon

    Nigel Croxon - 2023-05-16

    ommit fe76d597a9b85f8af55235dd41722abf8fe63ca1 (HEAD -> master, origin/master, origin/HEAD)
    Author: Nigel Croxon ncroxon@redhat.com
    Date: Tue May 16 08:34:07 2023 -0400

    Make ELF constructors/destructors work
    
    Since commit [4f8b339facb471192e021fffd5db545a0fbddbc3]
    Simple EFI tools like for example t.c from the apps directory crash.
    
    The reason seems to be a wrong null-pointer check in the
    ctors()/dtors() functions in lib/entry.c.
    
     

Log in to post a comment.