Re: [gnotepad-users] new user questions/suggestions

[Andy K. <ac...@ne...>]

On Fri, Aug 24, 2001 at 12:55:52PM +0100, Stephen Isard wrote:
...
> I tried replacing the call to gdk_window_get_position in win.c with one to
> gdk_window_get_root_origin, and the creeping stopped.  Is that a reasonable
> move, or will I have broken something else?  Here's the patch:

It's probably fairly reasonable.  At the time the code was written for
saving the window position, I believe gdk_window_get_root_origin()
wasn't even implemented then.  Unless I discover other problems, I'll
include this change in future releases.


> 2. I can't find preferences settings that will let me choose coordinates that
> I like and have gnp start there every time, regardless of whether the window
> gets moved around during a session.  The reason seems to be that the default
> coordinates only get consulted if "Save window position on exit" is in force.
> Shouldn't the test for whether to call gtk_widget_set_uposition in win.c be
> something on the lines of whether either default coordinate is set to -1,
> rather than IS_SAVE_WIN_POS()?

The assumption made here is that if "Save window position on exit" is
_not_ selected, then the user likely doesn't care about where the
window is placed the next time gnp starts.  If the option _is_
selected, then gnp will use the saved coordinates the next time it
starts.


> While I'm writing, there are a couple of standard unix features that look to
> me (in my ignorance) as if they wouldn't be very hard to incorporate, nor
> create much bloat.  One would be to read from standard input if the input file
> is specified as '-' on the command line, and the other would be to let the
> user specify an alternative preferences file.  I want to use gnp as a viewer
> for some program output, and want fewer buttons, tabs, etc. in this context
> than when I'm using it as a general purpose editor.  If these features are
> already present and I've missed them, then I'm ashamed of myself and please
> tell me how to invoke them.

Although no one has requested these features in the past, they seem
like useful features to add.  I can add them to the "to do" list (and
hopefully they will be implemented in the next version), but feel free
to submit a patch if you feel inclined.

regards,
--andy