RE: [gnomeicu-support] two patches

[Olivier C. <te...@vi...>]

Hey.. comments below..

Olivier Crete
Tester
te...@vi...
oli...@vi...

Those who do not understand Unix are condemned to reinvent it, poorly. -- H=
enry Spencer

On 26 Jun 2002, Gediminas Paulauskas wrote:

> An, 2002-06-25 13:58, jwise ra=F0=EB:
> > Thank you for your patches.  I'm on the road with a client, so I can't
> > get to a Linux box anytime soon.  If Gediminas thinks these patches are
> > good, someone can certainly commit.
> >=20
> > As for the main tree, I'm going to be doing a little bit of work on it
> > to get it away from using GID/UID (an ICQ-centric idea) and pull it out
> > one layer so each contact is recognized by Protocol + Group Name +
> > Contact Name.  If anyone sees any problems with this, please let me kno=
w
> > now.
>=20
> You can, want and need to move a contact between groups. So I don't
> think identifying by group is a good idea. Identifying was always done
> by UIN, so why not continue using it? This is unique. AIM username is
> unique too I guess.
>=20
> Contact Name is not unique, just search for your name in a nick field
> and you'll see

To support multiple protocols we need to use "protocol+protoid".. and each=
=20
contact must have a "visible nick" and "protoid" (that's a uin or=20
something simil


> Looking at the code, it is very strange to see passing UINs around and
> searching, or passing a GSlist and using only data of it. I would like
> that everywhere you need to say "do something with this contact", a
> pointer to contract data was passed. Or iter to the row in a model, I
> don't know that much about trees...

The reason that I use UINs in my code (v7*.c) is that when I wrote it I=20
had many doubts about the long term viability of the rest of the ICU code=
=20
and I was trying to save my code in the event the rest was unsavable.. But=
=20
I'm very very very happy that we saved the rest.. But I'm not too=20
enthusiastic about playing through the main data structs in the protocol=20
specific code, its not nice engineering..=20