From: Giles V. <gv...@sa...> - 2009-09-29 12:42:07
|
On 29 Sep 2009, at 13:31, Mitch Skinner wrote: > On 09/27/2009 03:16 PM, Giles Velarde wrote: >> I had a look over the weekend (see patch below). This turned out to >> be a little bit more complicated than I thought because if I tried >> to just do something simple in the error handler like >> >> this.setLoaded(); >> >> data structures weren't initialized properly and errors ensued. I >> got around this by faking an empty track inside the error handler >> and passing it onto loadSuccess(). Not being familiar with JBrowse, >> I don't know if this is the best way to do it, but it seems to work >> for me. > > Cool! It's great to see people getting into the code. What you did > was the first thing I thought of doing, but I wanted to solve the > problem for ImageTrack as well. This is what I just committed to > the master branch: > > http://github.com/jbrowse/jbrowse/commit/6e7f2e8940ccb3fa6bf2c79db499121289d67fe6 > > It adds yet another bit of state to the Track class, which I usually > try to avoid; on the other hand, it saves us from having to maintain > a proper fake empty track. > > Hopefully I don't sound like I'm dismissing what you did; I'm really > happy when I get patches, but I thought about it and decided I > wanted to go in a different direction. > > Regards, > Mitch No worries, Mitch. I am just scratching its surface right now, and was well aware that was probably a better way. Glad it's fixed! Will try it out asap. Cheers, Giles -- The Wellcome Trust Sanger Institute is operated by Genome Research Limited, a charity registered in England with number 1021457 and a company registered in England with number 2742969, whose registered office is 215 Euston Road, London, NW1 2BE. |