Re: [Gmailagent-devel] libgmail: important security fix needs testing

[Waseem S. D. <wd...@MI...>]

Yep, adding the [] fixed the first problem.

However, with all version of python I have (2.2, 2.3, 2.4), libgmail.py
still dies:
------------------------------------
wdaher@wdaher:~/Projects/libgmail$ python2.4 libgmail.py
Gmail account name: webmail.test
Password:

Please wait, logging in...
Login successful.

Traceback (most recent call last):
  File "libgmail.py", line 1430, in ?
    quotaInfo = ga.getQuotaInfo()
  File "libgmail.py", line 456, in getQuotaInfo
    self.getMessagesByFolder(U_INBOX_SEARCH)
  File "libgmail.py", line 436, in getMessagesByFolder
    return self._parseThreadSearch(folderName, allPages = allPages)
  File "libgmail.py", line 412, in _parseThreadSearch
    return GmailSearchResult(self, (searchType, kwargs), threadsInfo)
  File "libgmail.py", line 1094, in __init__
    self._threads = [GmailThread(self, thread) for thread in
threadsInfo[0]]
  File "libgmail.py", line 1182, in __init__
    self.id = threadsInfo[T_THREADID] # TODO: Change when canonical
updated?
TypeError: unsubscriptable object
------------------------------------

Also worth noting is that on debian the logging package seems to be
broken in 2.2
------------------------------------
wdaher@wdaher:~/Projects/libgmail$ python2.2 libgmail.py
Traceback (most recent call last):
  File "libgmail.py", line 46, in ?
    import logging
ImportError: No module named logging
------------------------------------

The second issue is less of a concern for me than the first (which seems
to be a showstopper, at least on my machine...).

I'll try to take another look tomorrow, if I can finish my algorithms
homework :-P

As for the CVS version, what you're getting anonymously should be
exactly what we're getting, as far as I can tell. SourceForge's CVS lags
checkins by a few hours sometimes, though.

- W

On Sun, 2005-09-18 at 17:05 -0400, Andrew Lin wrote:
> I just checked; listcomps do in fact work in 2.2.
> 
> On 9/18/05, Andrew Lin <one...@gm...> wrote:
> > Hm, I was wondering if you'd made the changes necessary to make it run
> > in anything but 2.4.  All of my machines have 2.4, so I've almost
> > forgotten what are 2.4 only features; of course, I'd assume that for
> > public consumption you guys want to stay compatible with 2.3 at the
> > least.
> > 
> > The change you described can probably be done more easily by just
> > adding [] around the genexp.  That should work in 2.3; I forget when
> > listcomps were added, but IIRC it should work in 2.2 as well.
> > 
> > Also, where can I find the CVS version you refer to?  I followed
> > sourceforge's directions for anonymous checkout of libgmail CVS, and
> > got (AFAICT) the same version as before.
> > 
> > Andrew