From: Stas Z <sta...@gm...> - 2005-09-28 20:28:18
|
On 9/28/05, Stefan Potyra <da...@po...> wrote: > I just read over your mail and the mailing list and would like to give so= me > further thoughts on language support: > > If language support is enabled, > (1) files from worldbuilder cannot be loaded > (2) keywords aren't highlighted. > (3) language/world files aren't exchangable > (4) the package examples are mostly in english, which cannot be used then > > You've discussed (3) quite long on the mailing list, and I'd rate this as= a > wishlist bug. Indeed, we started to work on that. Don't know when it's ready. > I'd rate (4) a little bit higher, as I tend to look at examples at first,= if I > want to get started with something. However this could be solved easily b= y > including more localized examples in the package. Your right, I will try to translate some of the examples. > For (2) I'd just say that this is a minor bug at most. That's already fixed in CVS. > So the real reason to drop language support would be (1). > > However after giving this a second thought I am not sure if dropping lang= uage > support has been a mistake. Does the benefit of beeing able to use the > worldbuilder outweigh language support? No, it doesn't and I consider (1) to be a bug which should be fixed asap. That also the reason I suggested that you left the language support out, considering it's going into a stable release soon. (Breezy) > To put it short, I'm really clueless if I did the right or wrong thing an= d I'd > appreciate to hear your opinion on this. Al things consider, I would say you did right dropping some of the language support. > (Btw.: I'd really like to go in sync to debian again, as this will not on= ly > save us merging work in the future, but have a real maintainer with > experience for this package care for it.) I think you should contact Sergio personally and discuss this with him. Besides, gvr is a learning tool, it's development was meant as a learning t= ool, it's used as a learning tool, perhaps it's packaging can also be a learning tool :-) Cheers, Stas -- A nation that continues year after year to spend more money on military def= ense than on programs of social uplift is approaching spiritual doom. Martin Luther King, Jr. |
From: Stas Z <sta...@gm...> - 2005-09-29 15:24:56
|
On 9/29/05, Stefan Potyra <da...@po...> wrote: > Hi again, > > thanks for your fast replies. > After hearing pros and cons to localization of the language files, I'd li= ke to > propose another solution for the ubuntu-package: > > I imported the patch from cvs[1] (and dropped some debug stuff in it) to > support highlighting localized keywords and wrote a patch to have > worldbuilder generate localized files[2]. > > However before doing anything wrong again, I'd like to hear your opinions > about this. Cool, I will test you patches tonight (I'm in GMT+2) Thanks, it's always nice to get patches alongside bug reports :-) > [1]: This is slightly different then the cvs-version, I also needed to ch= ange > EditorWindos.py:402 from > > self.kwords =3D [L2U(_('Robot')), L2U(_('Wall')), L2U(_('Beepers')), > L2U(_('Size'))] > > to > > self.kwords =3D [L2U(_('ROBOT')).title(), L2U(_('WALL')).title(), > L2U(_('BEEPERS')).title(), L2U(_('SIZE')).title()] Hmm, with a properly translated po file that won't be needed but it could serve as a backup for partial translated po files :-) Thanks, Stas -- A nation that continues year after year to spend more money on military def= ense than on programs of social uplift is approaching spiritual doom. Martin Luther King, Jr. |
From: Stas Z <sta...@gm...> - 2005-09-29 19:32:39
Attachments:
gvr-changed-files.tar.gz
|
On 9/29/05, Stas Z <sta...@gm...> wrote: > > However before doing anything wrong again, I'd like to hear your opinio= ns > > about this. > Cool, I will test you patches tonight (I'm in GMT+2) OK, I've applied the patches and they work great :-) The bugs related to the syntax highlighting and the localization of the worldbuilder are fixed now, thanks. When testing the worldbuilder I noticed a bug in the 'beeper set' dialog. You could choose the number of beepers the robot would carry but they never get set in the program. This is fixed also. So your patches are applied and together with my fix the worldbuilder seems Breezy ready. I committed the changes to CVS. Let me know if you think the gvr currently in CVS is ready for Breezy. PS, SF only updates the anonymous CVS every few hours or so so I attached the changed gvr files which are currently in CVS. Cheers, Stas -- A nation that continues year after year to spend more money on military def= ense than on programs of social uplift is approaching spiritual doom. Martin Luther King, Jr. |
From: Stefan P. <da...@po...> - 2005-09-29 21:01:08
|
Hi Stas,=20 Am Donnerstag 29 September 2005 20:33 schrieb Stas Z: > On 9/29/05, Stas Z <sta...@gm...> wrote: > > > However before doing anything wrong again, I'd like to hear your > > > opinions about this. > > > > Cool, I will test you patches tonight (I'm in GMT+2) > > OK, I've applied the patches and they work great :-) Thanks for your efforts and for testing. > The bugs related to the syntax highlighting and the localization > of the worldbuilder are fixed now, thanks. You're welcome ;) > > When testing the worldbuilder I noticed a bug in the 'beeper set' dialog. > You could choose the number of beepers the robot would carry but > they never get set in the program. > This is fixed also. Great! > > So your patches are applied and together with my fix the worldbuilder > seems Breezy ready. I committed the changes to CVS. > > Let me know if you think the gvr currently in CVS is ready for Breezy. It definitely is more than ready for breezy. Thanks again for all your work! I already got ok to break the freeze and will upload the new version of gvr= =20 tomorrow ;) P.S.: If you are interested, the latest source-package is at: http://revu.tauware.de/details.py?upid=3D664 P.P.S.: I just resent the message, as gmailagent-devel rejected my mail=20 because it suspected it to be spam. Cheers and thanks for your collaboration, Stefan. |