Re: [GLE-devel] error in qgle.pro.in?

[Jan S. <jan...@st...>]

Dear Christian,

This patch was indeed applied after the release.

The __DATE__ and __TIME__ are only used in the output of gle -info.

[jan@dhcppc5 gle]$ gle -info
GLE version: 4.2.5
Build date: Aug 16 2015 22:05:22
GLE_TOP: /usr/share/gle-graphics/4.2.5
GLE_BIN: /usr/bin
GhostScript: /usr/bin/gs
GS library: /usr/lib64/libgs.so.9
Bitmap import: JPEG, PNG, TIFF, GIF
Cairo rendering support: Yes
Poppler PDF support: Yes

I sometimes find this useful to double check that I'm running the correct build during my tests. But, for an official release this has little value as the version number should be sufficient. Should we not simply add a configure switch to disable this and print "Unknown" instead? OK if I go ahead and add this?

I overlooked the kfreebsd-buildd-has-no-proc patch. I've applied it now.

commit a7e3ff623b48d6a469c4374444b468a70e43d2e1
Author: Jan Struyf <jst...@st...>
Date: Wed Aug 19 11:27:49 2015 +0200
Applied patch to make GLE build on kfreeBSD (kfreebsd-buildd-has-no-proc) by Christian T. Steigies

diff --git a/src/gle/file_io.cpp b/src/gle/file_io.cpp
index b91eaad..284264f 100644
--- a/src/gle/file_io.cpp
+++ b/src/gle/file_io.cpp
@@ -1354,7 +1354,7 @@ bool GetExeName(const char* appname, char **argv, string& exe_name) {
return true;
}
#endif
-#if defined(__UNIX__) && !defined(__MACOS__) && !defined(__FREEBSD__)
+#if defined(__linux__)
/* try to read location from the /proc/self/exe file */
char path[PATH_MAX];
struct stat stat_buf;

Best Regards,

Jan

Op 19 augustus 2015, schreef Christian T. Steigies <ct...@de...>:
> Dear Jan,
> On Tue, Aug 18, 2015 at 02:04:37PM +0000, Jan Struyf wrote:
> > 
> > I've applied your patch in the following commit.
> > 
> > commit a61fdb900c0fbe87a4a123b03232d519fcbfbe3b
> > Author: Jan Struyf <<jst...@st...>>
> > Date: Tue Aug 18 16:01:39 2015 +0200
> > Applied patch to make QGLE correctly set LFLAGS (by Christian T. Steigies)
> > 
> > See: <<https://sourceforge.net/p/glx/gle/ci/a61fdb900c0fbe87a4a123b03232d519fcbfbe3b/>>
> > 
> This patch as well as the kfreebsd-buildd-has-no-proc are not applied in
> your just released version yet, correct? They are still enabled in the
> (new) debian package.
> 
> > I'm sorry about the huge delay.
> > 
> No problem, the new gle version is already installed in Debian/unstable.
> 
> My next goal is to make gle build reproducibly. I have noted that the build
> time seems to be set in src/gle/core.cpp and it seems __DATE__ and __TIME__
> can be overridden, but I did not figure out yet how this is done. Debian
> has proposed to use SOURCE_DATE_EPOC for this, which may be included in gcc:
> <https://wiki.debian.org/ReproducibleBuilds/TimestampsFromCPPMacros>
> What is your proposed way for package maintainers to set these variables at
> build time, so the package can be built reproducibly?
> 
> thanks,
> Christian
>