Re: [Glide-devel] Device3Dfx kernel-2.4 compatibility

[Guillem J. <gu...@ha...>]

On Thu, 2007-01-25 at 13:40:16 +0200, O.Sezer wrote:
> Hello: Changes committed on 2006-12-03 broke
> compilation of Device3Dfx against 2.4 series
> kernels. The change in question is titled
> 'Rename functions obsoleted in linux 2.1.93':
> 
> 3dfx_driver.c: In function `doQueryFetch':
> 3dfx_driver.c:422: warning: passing arg 1 of 
> `pci_read_config_byte_R3ccefab4' makes pointer from integer without a cast
> 3dfx_driver.c:427: warning: passing arg 1 of 
> `pci_read_config_word_R923654cb' makes pointer from integer without a cast
> 3dfx_driver.c:432: warning: passing arg 1 of 
> `pci_read_config_dword_R0bf170e2' makes pointer from integer without a cast
> 3dfx_driver.c: In function `doQueryUpdate':
> 3dfx_driver.c:480: warning: passing arg 1 of 
> `pci_read_config_dword_R0bf170e2' makes pointer from integer without a cast
> 3dfx_driver.c:505: warning: passing arg 1 of 
> `pci_write_config_dword_R77f7f940' makes pointer from integer without a cast
> 
> I attached a patch that restores compilability.

Hmm, that's because those functions take 'struct pci_dev *' instead of
unsigned int even in older version, I'll fix this properly by using
pci_dev everywhere.

Thanks for the report!

regards,
guillem