#107 varargs on FreeBSD 5

closed-fixed
5
2004-03-26
2004-03-26
No

Somehow FreeBSD 5.x's va_copy is not detected and memcpy breaks
on other architectures than i386, e.g. alpha.

Currently, the attached patch helps.

Discussion

  • Richard Guenther

    • assigned_to: nobody --> richi
     
  • Richard Guenther

    Logged In: YES
    user_id=7575

    I guess it's time for a configure check. I'll go over this
    piece again.
    Don't exactly remember why I put the memcpy fallback in, but
    I think I should drop it in favor of a configure failure.

     
  • Richard Guenther

    Logged In: YES
    user_id=7575

    Ok, can you try the attached patch which just removes the
    need for va_copy? It's untested, but maybe you get the idea
    and can fix up any simple errors I made.

    Thanks,
    Richard.

     
  • Volker Stolz

    Volker Stolz - 2004-03-26

    Logged In: YES
    user_id=126328

    Yes, glame builds fine with your patch as well. Thanks!
    I didn't check if it's doing what it's supposed to do though :)

     
  • Richard Guenther

    • status: open --> closed
     
  • Richard Guenther

    • status: closed --> closed-fixed
     
  • Richard Guenther

    Logged In: YES
    user_id=7575

    I checked it on debian unstable on ia32. But it should work
    in theory because now we avoid the fragile va_copy stuff.

    Checked in into unstable, will backport soon.

    Thanks for the report,

    Richard.

     
  • Richard Guenther

    Logged In: YES
    user_id=7575

    As always, testing ia32 is mood - the patch fails on ppc
    because I missed some spot - and viola - va_copy is back :(

    Added a check for it (but no workaround for a missing one)
    to unstable CVS, too. See attached patch "p2" for a working
    version (for systems with va_copy).

     
  • Richard Guenther

     

Log in to post a comment.