Hello,
Let me first say thanks (again) for enabling the option to disable all
debugging output. I am also thankful that you have implemented a more
straightforward offscreen rendering class.
There is however one problem with it (or what looks like a problem). The
setSize(Dimension size) method located at line 236 in file
GLOffScreenDrawable.java is implemented to set the internal size
(offScrnSize) to the passed in size by reference, not by copying the
actuall values (width and height). This poses a problem as a user might
use the same passed in reference (size), but that has been changed, again
in a call to setSize, and due to the implementation of setSize
(following), a size change is not recognized:
if((size!=null && size.equals(offScrnSize)==false) ||
size!=offScrnSize
)
{
offScrnSizeChanged=true;
offScrnSize=size;
initDrawable();
}
It seems it would be better if the components of the reference (size.width
and size.height) are copied to offScrnSize, than by saving the reference
itself.
To all relevant folks, thanks again for the newer version of GL4Java ... a
lot of these features are/were needed.
nader
|
