#89 patch for bug #420703 Assertion failed!

closed-accepted
5
2001-10-26
2001-08-07
No

Hi Jeff

I think I solved the problem

In the function rtl8139_init_one I assign to ioaddr
the content of tp->mmio_addr (Line 941)

If USE_IO_OPS its not defined the function
rtl8139_init_board makes an assignament to tp->mmio
(Line 836)

but if USE_IO_OPS its defined then tp->mmio its
undefined (NULL) (Lines 824 and 825)

The solution i proposed its to insert a line with the
assignament

*** 8139too.c Tue Aug 7 22:26:55 2001
--- 8139too.c.orig Sat Jul 7 03:36:57 2001
***************
*** 824,830 ****
#ifdef USE_IO_OPS
ioaddr = (void *) pio_start;
dev->base_addr = pio_start;
- tp->mmio_addr = ioaddr;
#else
/* ioremap MMIO region */
ioaddr = ioremap (mmio_start, mmio_len);
--- 824,829 ----

See ya

Celso Gonzalez
mitago at ono.com

Discussion

  • Celso González

    Celso González - 2001-08-08

    Logged In: YES
    user_id=278598

    Hi again

    Two things.
    a) The patch #429788 (2001-06-03) solves the same problem
    b) A better solution its take off from the #ifdef the line
    tp->mmio_addr = ioaddr;
    so it executes always and dont care about USE_IO_OPS

     
  • Celso González

    Celso González - 2001-08-08
    • assigned_to: nobody --> jgarzik
     
  • Jeff Garzik

    Jeff Garzik - 2001-10-26
    • status: open --> closed-accepted
     

Log in to post a comment.