#100 Remove string check from ethtool and add ioctl check

closed-rejected
None
5
2004-08-20
2003-11-08
No

Hello,

I am not the author of the previous patch which
addressed the same problem.

I have renamed my interfaces with iproute2 and ethtool
thinks all interfaces should be named eth or usb.

I have removed that check and added a check of
ifr.ifr_hwaddr.sa_family instead so it doesn't depend
on the name of the interface to see if it is a ethernet
interface.

I have no usb interface so I can't verify if this patch
detects usb ethernet interfaces but I would think they
are reported as regular ethernet interfaces.

Please drop me an email if you decide to use this patch.

Best Regards
Magnus <sarek@ozaba.cx>

Discussion

  • Magnus Boden

    Magnus Boden - 2003-11-08

    Patch that removes string check for ethtool.

     
  • Jeff Garzik

    Jeff Garzik - 2004-08-17
    • assigned_to: nobody --> jgarzik
     
  • Jeff Garzik

    Jeff Garzik - 2004-08-17

    Logged In: YES
    user_id=17443

    Can you please update the patch for version 2?

     
  • Jeff Garzik

    Jeff Garzik - 2004-08-17
    • status: open --> closed-out-of-date
     
  • Magnus Boden

    Magnus Boden - 2004-08-17

    Patch that removes string check for ethtool-2.

     
  • Magnus Boden

    Magnus Boden - 2004-08-17
    • status: closed-out-of-date --> open-out-of-date
     
  • Magnus Boden

    Magnus Boden - 2004-08-17

    Logged In: YES
    user_id=509630

    The patch is updated to version 2.

     
  • Jeff Garzik

    Jeff Garzik - 2004-08-20
    • status: open-out-of-date --> closed-rejected
     
  • Jeff Garzik

    Jeff Garzik - 2004-08-20

    Logged In: YES
    user_id=17443

    Nah, I think that your patch (updated to ethtool v2) does a
    bit too much checking.

     
  • Magnus Boden

    Magnus Boden - 2004-08-20

    Logged In: YES
    user_id=509630

    Ok.

    It does the same checking as the last patch did so I can not
    figure out why you would ask me to update the patch to
    version 2 since you could have dropped it before and I
    wouldn't have wasted my time.

    Regards
    Magnus

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks