Re: [Gitstat-devel] Current gitstat broken?

[Paul V. <pau...@gm...>]

Paul Vriens wrote:
> Hi,
> 
> Yes stupid thinko(s).
> 
> Using the date for the tags was a bad idea in this case. We picked the 
> date from the tags and used that as limits. What basically happened was:
> 
> get date of last tag : Dec-1-2007
> get date of the tag before that : Nov-1-2007
> 
> and then we calculate the commits between those dates. That's obviously 
> wrong as the date marks the 'end of a release'.
> 
> 
Please forget the bogus explanation. The fix I committed is correct but for 
different reasons as stated above.

We know to what tag a commit belongs so it's fine to use that for the graph.

The reason that the numbers were not correct is purely the date of the commits 
(AFAIK). If I take for example commit e7bd34a15b85655f24d1b45edbe3bdfebf9d027e:

[paul@penguin linux-2.6.git]$ git show e7bd34a15b85655f24d1b45edbe3bdfebf9d027e
commit e7bd34a15b85655f24d1b45edbe3bdfebf9d027e
Author: Paul Mundt <le...@li...>
Date:   Tue Jul 31 17:07:28 2007 +0900

     sh: Support explicit L1 cache disabling.

     This reworks the cache mode configuration in Kconfig, and allows for
     explicit selection of write-back/write-through/off configurations.
     All of the cache flushing routines are optimized away for the off
     case.

     Signed-off-by: Paul Mundt <le...@li...>

This patch dates Jul-31 whereas 2.6.23 came out on Oct-9.

git-gui shows for this commit:

Follow : v2.6.23-rc7
Precedes : v2.6.24-rc1

Cheers,

Paul.