Re: [Gitstat-devel] Current gitstat broken?

[<jun...@gm...>]

I received and applied that patch.
Plz, Check about it.
Thanks,all.

On Nov 12, 2007 4:59 PM, Paul Vriens <pau...@gm...> wrote:
>
> ??? wrote:
> > Hi,
> > In my opinion, gitstat has some bug,
> >
> > Now, when generate some chart with current gitstat,
> > 1. find start and end date of Tags.
> > 2. and count changest and author in this period.
> > 3. Make chart.
> >
> > But we could know It's not good solution.
> > see below page.
> >
> > http://tree.celinuxforum.org/gitstat/commit-detail.php?commit=1100b47ea557e1cd6d9b71fe7ba1a189ed8bf276
> >
> > This changeset is included in tag(v2.6.24-rc1), but it was commited at
> > 2007/06/28 20:15 !!
> >
> >       v2.6.24-rc2    2007/11/06 21:57:46
> >       v2.6.24-rc1    2007/10/24 04:50:57
> >       v2.6.23          2007/10/09 21:31:38
> >
> > So, we should make other logic for making chart.
> >
> > And the chart has wrong data rely on server-setting, too.
> > Now CELF server is setted on PST.
> > so, we should set server-time or make some modification on gitstat.
> >
> > Thanks,all.
> >
> > On Nov 12, 2007 10:04 AM, Soon-Son Kwon(Shawn) <ks...@kl...> wrote:
> >> Oops... we should check it.
> >>
> >> Paul: (Not Paul Mundt, but Paul Vriens huhu)
> >> could you check this? We don't have to feel lonely.
> >> At least there shold be several people watching
> >> this project. If we have more bug, then more people
> >> will show more interest. (just kidding) :-)
> >>
> >> Paul Mindt: Thank you for letting us know.
> >> I hope you could join the devel list and
> >> drop us some note from time to time...
> >>
> >>
> >> 2007/11/12, Paul Mundt <pau...@re...>:
> >>> My current statistics on gitstat seem to be completely miscalculated, and
> >>> have been broken eve since the -rc1 release. Could you see if there is a
> >>> bug here?
> >>>
> >>> git shortlog gets the numbers right, at least:
> >>>
> >>> $ git shortlog v2.6.23..v2.6.24-rc2  | grep 'Paul Mundt'
> >>> Paul Mundt (100):
> >>> ...
> >>>
> >>> while gitstat for some reason only reports 17?
> >>>
> >>
> >> --
> >> http://kldp.org/~kss
> >>
> >
> Hi,
>
> Yes stupid thinko(s).
>
> Using the date for the tags was a bad idea in this case. We picked the date from
> the tags and used that as limits. What basically happened was:
>
> get date of last tag : Dec-1-2007
> get date of the tag before that : Nov-1-2007
>
> and then we calculate the commits between those dates. That's obviously wrong as
> the date marks the 'end of a release'.
>
> I will sent a patch that corrects that.
>
> Another thing that's important in this particular case is that we now also can
> show release candidates (which we do). This means that getting the "Top
> contributors (Kernel Release) for 2.6.24-rc2" will by default be compared
> against 2.6.24-rc1 and not 2.6.23. The gitstat administrator can decide which
> tags can be used.
>
> So:
>
> a) I'll sent a patch
> b) I'll change http://tree.celinuxforum.org so that 2.6.24-rc1 is left out of
> the equation.
>
> Cheers,
>
> Paul.
>
> P.S. I guess we have this issue in other charts as well so I will have a look
> (later).
>
>
>
>
>