Re: [Gitstat-devel] Recent change to chart.php unveiled a potential problem

[Paul V. <pau...@gm...>]

Paul Vriens wrote:
> Paul Vriens wrote:
>> Hi,
>>
>> I just committed a change (temp. fix) to chart.php. With the change 
>> from 'committer' to 'author' the amount of data passed to horizbar.php 
>> changed.
>>
>> If you (without the patch) go to:
>>
>> http://tree.celinuxforum.org/gitstat/chart.php?chart_parameter1=3&chart_parameter_ver=v2.6.22&submit=1&chart_parameter2_year=2007&chart_parameter2_month=0&submit=1 
>>
>>
>> you'll see what I mean, no graph at all.
>>
>> There is currently a hardcoded limit of 10 entries in horizbar.php but 
>> that wasn't the issue. The real issue is that we pushed to much data 
>> to horizbar.php.
>>
>> Any idea of the limits? Maybe I should be starting harder to think of 
>> not passing the data via the URL but doing it via the database as I've 
>> tried to do a few days ago (and which was working btw).
>>
>> Cheers,
>>
>> Paul.
>>
> Hi,
> 
> It looks the problem is a little different as I thought. If you look at 
> the mentioned page you see one strange entry for the Group:
> 
> Fernando Luis [** ISO-8859-1 charset **] VázquezCao
> 
> I'll have a check later on. For now the patch doesn't do any harm though.
> 
> Cheers,
> 
> Paul.
> 
Hi,

It seems that these commits are already 'wrong' in git:

commit 45ae5e968ea01d8326833ca2863cec5183ce1930
Author: Fernando Luis [** ISO-8859-1 charset **] V<E1>zquezCao <fer...@os...
Date:   Wed May 2 19:27:18 2007 +0200

     [PATCH] i386: __send_IPI_dest_field - i386

So we should either filter them out on insertion to the DB or when retrieving.

What is the best approach?

Cheers,

Paul.