Re: [Gitstat-devel] New installation and configuration pages

[Paul V. <pau...@gm...>]

Lee jungseung wrote:
> Hi,
> 
> First of all, Thanks for your contribution.
> Actually, I couldn't focus on gitstat these days, sorry for that.
> 
> I don't know the way of using dbconfig.php and gitstatconfig.php.
> So, I couldn't tell about that well, but if it is needed to separate config.
> php, your idea could be good solution.

The idea behind this is that:

dbconfig.php holds the database configuration stuff (like GSTAT['ID'])
gitstatconfig.php holds all other configuration paramaters.

For people who are updating they can just copy their config.php to these new 
files. The functions in lib.php will make sure only the relevant stuff is extracted.

The dbconfig.php is always needed somewhere on the disk whereas the other stuff 
can reside anywhere we want.

gitstatconfig.php will be removed in the future and those parameters will reside 
in a/the database.

> 
> With some perl code it could be separated easily. But it doesn't care a
> whoop.

I actually thought about changing config.pl to do that but decided generating it 
from the admin page was so much easier. Especially as this will be moved partly 
to the database I didn't feel like touching config.pl.

This does however mean that the dbconfig.php has to change into a different kind 
of file/format so it can be read easily by both php and perl without too much 
hassle.

> 
> I'm waiting for new installation page. Someone said that gitstat is too
> complex to install and use. If it is done, gitstat could be used by more
> people.

I totally agree. I didn't know it would take this much effort though :-)
I will stop beautifying the installation and admin page, that's something we can 
do afterwards.

Cheers,

Paul.