Re: [Gitstat-devel] [gitstat-devel]Timezone problem

[Paul V. <pau...@gm...>]

Hi Lee,

Lee jungseung wrote:
> Hi,
> 
> The gitstat use 'mktime()' for making time information.
> e.g. $cart_time_start=mktime(0,0,0,1,1,$_GET['chart_parameter2_year']);
> As you know, the $cart_time_start is something like '2008.1.1 '2008.12.31
> (a kind of time standard?)
> 
> According to server setting, Time zones are different. 
> So, gitstat(using same git-tree) shows different statistics.
> 
> In my opinion, We need to use same time standard.
> 
> In case of using mktime(), How about to use gmmktime()? 
> http://kr2.php.net/gmmktime
> With gmmmktime(), we could maintain some standard for making statistics.
> How about your opinion?
> 
> Thanks,
> 
looks fine to me. I think it's definitely worth doing this. We also have some 
pieces of code that add a KST time. That has to be removed as well or changed to 
  the current timezone of that server.

Cheers,

Paul.