From: Lee j. <jun...@gm...> - 2008-01-23 00:09:41
|
Hi, Your patches are simple and make our code more beautiful. go ahead :) Thanks, -----Original Message----- From: git...@li... [mailto:gitstat-devel- bo...@li...] On Behalf Of Paul Vriens Sent: Wednesday, January 23, 2008 4:45 AM To: git...@li... Subject: [Gitstat-devel] [gitstat-devel] Start of new include file Hi, Before committing these new changes I thought of just throwing them in here to get some feedback (if any). I've created a new include/libgather.php (attached). This will be used (for now) by both chart.php and index.php as they both contain almost the same pieces of code. I've also attached the diff's for both mentioned files. All data gathering stuff will be moved to libbgather.php. Once that is done we have at least cleaned up some of the main pages. The idea is to remove all MySQL specific stuff from the main pages and put this in include files. Once that's done we can start thinking of introducing other means of storing/gathering information (i.e. SQLite or direct git access without any DB kind of thing). Silence will be taken as 'go ahead' :-). Cheers, Paul. |