From: Paul V. <pau...@gm...> - 2007-08-30 07:44:27
|
Hi, Just a list of things I've found so far - several graphs/statistics use fixed header strings - tags are checked for being "< 8" when statistics are being generated I know that the "<8" works fine for the kernel and gets rid of the release candidates but it's highly inflexible. Another thing related to this. Wine was changed from CVS to GIT somewhere at the end of 2005. Everything was imported to GIT but the tags are not necessarily of the correct date. This means that creating the taglist based on creatordate will not always give you the correct sorted list. One of our Wine developers came up with the idea to: == A possible solution would be to have gitstat check the commit referenced by the tag; that one has the right date. E.g "tag wine-0.0.2" references "commit 2c25c3e9442c69bd2402f94f264f0aafa58b00e0" which has as "CommitDate: Tue Jun 29 16:33:12 1993 +0000". == Another thing that is maybe only relevant for Wine is that the structure of the versioning changed over time: first wine-0.0.2 -> wine-0.7 then wine-<yymmdd> (from wine-940201 to wine-991212) then wine-<yyyymmdd> (from wine-20000109 to wine-20050930) now wine-0.9 0> wine-0.9.44 (current version). The tags are named the same of course. I don't know yet how to solve the above issues but will keep investigating. Cheers, Paul. |
From: <jun...@gm...> - 2007-08-31 01:08:10
|
>This means that creating the taglist based on creatordate will >not always give you the correct sorted list. Hi. When I heard your problem, I thought same solution with your colleague's Anyway, I think that there is no front door in case of wrong creatordate. If you find good solution, let me know it, please. Good luck..! On 8/30/07, Paul Vriens <pau...@gm...> wrote: > Hi, > > Just a list of things I've found so far > > - several graphs/statistics use fixed header strings > - tags are checked for being "< 8" when statistics are being generated > > I know that the "<8" works fine for the kernel and gets rid of the release > candidates but it's highly inflexible. > > Another thing related to this. Wine was changed from CVS to GIT somewhere at the > end of 2005. Everything was imported to GIT but the tags are not necessarily of > the correct date. This means that creating the taglist based on creatordate will > not always give you the correct sorted list. > One of our Wine developers came up with the idea to: > == > A possible solution would be to have gitstat check the commit referenced > by the tag; that one has the right date. E.g "tag wine-0.0.2" references > "commit 2c25c3e9442c69bd2402f94f264f0aafa58b00e0" which has as > "CommitDate: Tue Jun 29 16:33:12 1993 +0000". > == > Another thing that is maybe only relevant for Wine is that the structure of the > versioning changed over time: > > first wine-0.0.2 -> wine-0.7 > then wine-<yymmdd> (from wine-940201 to wine-991212) > then wine-<yyyymmdd> (from wine-20000109 to wine-20050930) > now wine-0.9 0> wine-0.9.44 (current version). > > The tags are named the same of course. > > I don't know yet how to solve the above issues but will keep investigating. > > Cheers, > > Paul. > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Gitstat-devel mailing list > Git...@li... > https://lists.sourceforge.net/lists/listinfo/gitstat-devel > |
From: Paul V. <pau...@gm...> - 2007-08-31 12:11:00
Attachments:
lib.patch
|
이정승 wrote: >> This means that creating the taglist based on creatordate will >> not always give you the correct sorted list. > > Hi. > > When I heard your problem, I thought same solution with your colleague's > Anyway, I think that there is no front door in case of wrong creatordate. > If you find good solution, let me know it, please. > Good luck..! > Hi, It seems there's a very easy solution! See the attached patch. (This is with git version 1.5.2.4). The patch to lib.pl puts the list of tags in the correct order in to the v_tag table. The patch to parset.pl make sure we use the date of the commit (referenced by the tag) for the epoch field. I haven't find a nicer way with any of the git tools to get the same information from only one command. This seemed to be the easiest (several git command produce nice output for not 3 the wanted fields, only git-cat-file does that). When you look at http://tree.celinuxforum.org/gitstat/tag.php you'll also see that the date for v2.6.11-tree up to v2.6.13-rc3 is the same. I think this patch also fixes that. I've only checked it on the kernel git-tree with the commands used, not with gitstat itself. Cheers, Paul. |
From: <jun...@gm...> - 2007-09-01 09:54:22
|
R29vZCBqb2IsCkl0IHNlZW1zIHRvIGJlIG5pY2Ugc29sdXRpb24uIQoKSSBkaWRuJ3QgYW5hbHl6 ZSB0aGlzIHBhdGNoIHlldC4KYnV0LCBJJ2xsIGNoZWNrIHRoaXMgcGF0Y2ggZGVlcGx5IGFuZCBJ ZiBpdCB3b3JrcyB3ZWxsLApJJ2xsIGluY2x1ZGUgaXQgbmV3IHJlbGVhc2UuClRoYW5rcyBmb3Ig eW91ciBjb250cmlidXRpb24uCgoKT24gOC8zMS8wNywgUGF1bCBWcmllbnMgPHBhdWwudnJpZW5z LmdpdHN0YXRAZ21haWwuY29tPiB3cm90ZToKPiDAzMGkvcIgd3JvdGU6Cj4gPj4gVGhpcyBtZWFu cyB0aGF0IGNyZWF0aW5nIHRoZSB0YWdsaXN0IGJhc2VkIG9uIGNyZWF0b3JkYXRlIHdpbGwKPiA+ PiBub3QgYWx3YXlzIGdpdmUgeW91IHRoZSBjb3JyZWN0IHNvcnRlZCBsaXN0Lgo+ID4KPiA+IEhp Lgo+ID4KPiA+IFdoZW4gSSBoZWFyZCB5b3VyIHByb2JsZW0sIEkgdGhvdWdodCBzYW1lIHNvbHV0 aW9uIHdpdGggeW91ciBjb2xsZWFndWUncwo+ID4gQW55d2F5LCBJIHRoaW5rIHRoYXQgdGhlcmUg aXMgbm8gZnJvbnQgZG9vciBpbiBjYXNlIG9mIHdyb25nIGNyZWF0b3JkYXRlLgo+ID4gSWYgeW91 IGZpbmQgZ29vZCBzb2x1dGlvbiwgbGV0IG1lIGtub3cgaXQsIHBsZWFzZS4KPiA+IEdvb2QgbHVj ay4uIQo+ID4KPgo+IEhpLAo+Cj4gSXQgc2VlbXMgdGhlcmUncyBhIHZlcnkgZWFzeSBzb2x1dGlv biEgU2VlIHRoZSBhdHRhY2hlZCBwYXRjaC4gKFRoaXMgaXMgd2l0aCBnaXQKPiB2ZXJzaW9uIDEu NS4yLjQpLiBUaGUgcGF0Y2ggdG8gbGliLnBsIHB1dHMgdGhlIGxpc3Qgb2YgdGFncyBpbiB0aGUg Y29ycmVjdCBvcmRlcgo+IGluIHRvIHRoZSB2X3RhZyB0YWJsZS4KPgo+IFRoZSBwYXRjaCB0byBw YXJzZXQucGwgbWFrZSBzdXJlIHdlIHVzZSB0aGUgZGF0ZSBvZiB0aGUgY29tbWl0IChyZWZlcmVu Y2VkIGJ5Cj4gdGhlIHRhZykgZm9yIHRoZSBlcG9jaCBmaWVsZC4gSSBoYXZlbid0IGZpbmQgYSBu aWNlciB3YXkgd2l0aCBhbnkgb2YgdGhlIGdpdAo+IHRvb2xzIHRvIGdldCB0aGUgc2FtZSBpbmZv cm1hdGlvbiBmcm9tIG9ubHkgb25lIGNvbW1hbmQuIFRoaXMgc2VlbWVkIHRvIGJlIHRoZQo+IGVh c2llc3QgKHNldmVyYWwgZ2l0IGNvbW1hbmQgcHJvZHVjZSBuaWNlIG91dHB1dCBmb3Igbm90IDMg dGhlIHdhbnRlZCBmaWVsZHMsCj4gb25seSBnaXQtY2F0LWZpbGUgZG9lcyB0aGF0KS4KPgo+IFdo ZW4geW91IGxvb2sgYXQgaHR0cDovL3RyZWUuY2VsaW51eGZvcnVtLm9yZy9naXRzdGF0L3RhZy5w aHAgeW91J2xsIGFsc28gc2VlCj4gdGhhdCB0aGUgZGF0ZSBmb3IgdjIuNi4xMS10cmVlIHVwIHRv IHYyLjYuMTMtcmMzIGlzIHRoZSBzYW1lLiBJIHRoaW5rIHRoaXMgcGF0Y2gKPiBhbHNvIGZpeGVz IHRoYXQuIEkndmUgb25seSBjaGVja2VkIGl0IG9uIHRoZSBrZXJuZWwgZ2l0LXRyZWUgd2l0aCB0 aGUgY29tbWFuZHMKPiB1c2VkLCBub3Qgd2l0aCBnaXRzdGF0IGl0c2VsZi4KPgo+IENoZWVycywK Pgo+IFBhdWwuCj4KPgo+Cj4KPgo+Cj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+IFRoaXMgU0YubmV0IGVt YWlsIGlzIHNwb25zb3JlZCBieTogU3BsdW5rIEluYy4KPiBTdGlsbCBncmVwcGluZyB0aHJvdWdo IGxvZyBmaWxlcyB0byBmaW5kIHByb2JsZW1zPyAgU3RvcC4KPiBOb3cgU2VhcmNoIGxvZyBldmVu dHMgYW5kIGNvbmZpZ3VyYXRpb24gZmlsZXMgdXNpbmcgQUpBWCBhbmQgYSBicm93c2VyLgo+IERv d25sb2FkIHlvdXIgRlJFRSBjb3B5IG9mIFNwbHVuayBub3cgPj4gIGh0dHA6Ly9nZXQuc3BsdW5r LmNvbS8KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IEdpdHN0YXQtZGV2ZWwgbWFpbGluZyBsaXN0Cj4gR2l0c3RhdC1kZXZlbEBsaXN0cy5zb3VyY2Vm b3JnZS5uZXQKPiBodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9n aXRzdGF0LWRldmVsCj4KPgo+Cg== |
From: <jun...@gm...> - 2007-09-03 00:29:39
|
R29vZCBqb2IsCkl0IHNlZW1zIHRvIGJlIG5pY2Ugc29sdXRpb24uIQoKSSBkaWRuJ3QgYW5hbHl6 ZSB0aGlzIHBhdGNoIHlldC4KYnV0LCBJJ2xsIGNoZWNrIHRoaXMgcGF0Y2ggZGVlcGx5IGFuZCBJ ZiBpdCB3b3JrcyB3ZWxsLApJJ2xsIGluY2x1ZGUgaXQgbmV3IHJlbGVhc2UuClRoYW5rcyBmb3Ig eW91ciBjb250cmlidXRpb24uCgoKT24gOC8zMS8wNywgUGF1bCBWcmllbnMgPHBhdWwudnJpZW5z LmdpdHN0YXRAZ21haWwuY29tPiB3cm90ZToKPiDAzMGkvcIgd3JvdGU6Cj4gPj4gVGhpcyBtZWFu cyB0aGF0IGNyZWF0aW5nIHRoZSB0YWdsaXN0IGJhc2VkIG9uIGNyZWF0b3JkYXRlIHdpbGwKPiA+ PiBub3QgYWx3YXlzIGdpdmUgeW91IHRoZSBjb3JyZWN0IHNvcnRlZCBsaXN0Lgo+ID4KPiA+IEhp Lgo+ID4KPiA+IFdoZW4gSSBoZWFyZCB5b3VyIHByb2JsZW0sIEkgdGhvdWdodCBzYW1lIHNvbHV0 aW9uIHdpdGggeW91ciBjb2xsZWFndWUncwo+ID4gQW55d2F5LCBJIHRoaW5rIHRoYXQgdGhlcmUg aXMgbm8gZnJvbnQgZG9vciBpbiBjYXNlIG9mIHdyb25nIGNyZWF0b3JkYXRlLgo+ID4gSWYgeW91 IGZpbmQgZ29vZCBzb2x1dGlvbiwgbGV0IG1lIGtub3cgaXQsIHBsZWFzZS4KPiA+IEdvb2QgbHVj ay4uIQo+ID4KPgo+IEhpLAo+Cj4gSXQgc2VlbXMgdGhlcmUncyBhIHZlcnkgZWFzeSBzb2x1dGlv biEgU2VlIHRoZSBhdHRhY2hlZCBwYXRjaC4gKFRoaXMgaXMgd2l0aCBnaXQKPiB2ZXJzaW9uIDEu NS4yLjQpLiBUaGUgcGF0Y2ggdG8gbGliLnBsIHB1dHMgdGhlIGxpc3Qgb2YgdGFncyBpbiB0aGUg Y29ycmVjdCBvcmRlcgo+IGluIHRvIHRoZSB2X3RhZyB0YWJsZS4KPgo+IFRoZSBwYXRjaCB0byBw YXJzZXQucGwgbWFrZSBzdXJlIHdlIHVzZSB0aGUgZGF0ZSBvZiB0aGUgY29tbWl0IChyZWZlcmVu Y2VkIGJ5Cj4gdGhlIHRhZykgZm9yIHRoZSBlcG9jaCBmaWVsZC4gSSBoYXZlbid0IGZpbmQgYSBu aWNlciB3YXkgd2l0aCBhbnkgb2YgdGhlIGdpdAo+IHRvb2xzIHRvIGdldCB0aGUgc2FtZSBpbmZv cm1hdGlvbiBmcm9tIG9ubHkgb25lIGNvbW1hbmQuIFRoaXMgc2VlbWVkIHRvIGJlIHRoZQo+IGVh c2llc3QgKHNldmVyYWwgZ2l0IGNvbW1hbmQgcHJvZHVjZSBuaWNlIG91dHB1dCBmb3Igbm90IDMg dGhlIHdhbnRlZCBmaWVsZHMsCj4gb25seSBnaXQtY2F0LWZpbGUgZG9lcyB0aGF0KS4KPgo+IFdo ZW4geW91IGxvb2sgYXQgaHR0cDovL3RyZWUuY2VsaW51eGZvcnVtLm9yZy9naXRzdGF0L3RhZy5w aHAgeW91J2xsIGFsc28gc2VlCj4gdGhhdCB0aGUgZGF0ZSBmb3IgdjIuNi4xMS10cmVlIHVwIHRv IHYyLjYuMTMtcmMzIGlzIHRoZSBzYW1lLiBJIHRoaW5rIHRoaXMgcGF0Y2gKPiBhbHNvIGZpeGVz IHRoYXQuIEkndmUgb25seSBjaGVja2VkIGl0IG9uIHRoZSBrZXJuZWwgZ2l0LXRyZWUgd2l0aCB0 aGUgY29tbWFuZHMKPiB1c2VkLCBub3Qgd2l0aCBnaXRzdGF0IGl0c2VsZi4KPgo+IENoZWVycywK Pgo+IFBhdWwuCj4KPgo+Cj4KPgo+Cg== |
From: Paul V. <pau...@gm...> - 2007-09-03 16:42:56
|
이정승 wrote: > Good job, > It seems to be nice solution.! > > I didn't analyze this patch yet. > but, I'll check this patch deeply and If it works well, > I'll include it new release. > Thanks for your contribution. > > Just had a quick look at my patches to gitstat and the linux kernel. There is one tag in there with no commit (as mentioned by Linus): [paul@penguin linux-2.6.git]$ git-cat-file tag 5dc01c595e6c6ec9ccda4f6f69c131c0dd945f8c object c39ae07f393806ccf406ef966e9a15afc43cc36a type tree tag v2.6.11-tree This is the 2.6.11 tree object. NOTE! There's no commit for this, since it happened before I started with git. Eventually we'll import some sort of history, and that should tie this tree object up to a real commit. In the meantime, this acts as an anchor point for doing diffs etc under git. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQBCeV/eF3YsRnbiHLsRAl+SAKCVp8lVXwpUhMEvy8N5jVBd16UCmACeOtP6 KLMHist5yj0sw1E4hDTyQa0= =/bIK -----END PGP SIGNATURE----- Doing a git-cat-file commit c39ae07f393806ccf406ef966e9a15afc43cc36a gives (obviously): [paul@penguin linux-2.6.git]$ git-cat-file commit c39ae07f393806ccf406ef966e9a15afc43cc36a fatal: git-cat-file c39ae07f393806ccf406ef966e9a15afc43cc36a: bad file Several of the kernel tags (from v2.6.11-tree upto v2.6.13-rc3) have no tagger. The new patch (attached) skips the not so valid tags (like v2.6.11-tree). The screenshot 'before' shows the current state and 'after' with my patches. Cheers, Paul. |