Menu

#4 Number of changeset per day is not correct

open
None
5
2007-09-06
2007-09-04
Paul Vriens
No

When you look at http://tree.celinuxforum.org/gitstat/index.php you'll see that the ChangeLog contains no entry for the 3rd of September but the graph does. This is not a timezone issue as it's the same on my local box. I've attached a patch which greatly simplifies the data gathering and also a before screenshot (how it is currently) and an after screenshot (how it is with the patch).

Discussion

  • Paul Vriens

    Paul Vriens - 2007-09-04

    The patch

     
  • Paul Vriens

    Paul Vriens - 2007-09-04

    Screenshot of current state

     
  • Paul Vriens

    Paul Vriens - 2007-09-04

    Logged In: YES
    user_id=1877250
    Originator: YES

    File Added: bargraph_before.png

     
  • Paul Vriens

    Paul Vriens - 2007-09-04

    Logged In: YES
    user_id=1877250
    Originator: YES

    File Added: bargraph_after.png

     
  • Paul Vriens

    Paul Vriens - 2007-09-04

    Screen with applied patch

     
  • Paul Vriens

    Paul Vriens - 2007-09-04

    Logged In: YES
    user_id=1877250
    Originator: YES

    I do know that the patch skips over days that are empty. I'll have a look at that, the patch was just attached to show you how things could be greatly simplified by using more SQL.

     
  • Paul Vriens

    Paul Vriens - 2007-09-04

    Logged In: YES
    user_id=1877250
    Originator: YES

    Please skip even the reading of the patch. I'll think it's worth to first cleanup chart.php before attempting to add something. The bug is there nevertheless.

     
  • Jungseung Lee

    Jungseung Lee - 2007-09-04

    Logged In: YES
    user_id=1867065
    Originator: NO

    Good point and Good patch.
    keep going...please

    Thanks,

     
  • Jungseung Lee

    Jungseung Lee - 2007-09-04
    • assigned_to: nobody --> kerino
     
  • Paul Vriens

    Paul Vriens - 2007-09-06
    • assigned_to: kerino --> paulvriens
     
  • Paul Vriens

    Paul Vriens - 2007-09-06

    Logged In: YES
    user_id=1877250
    Originator: YES

    I'm busy with this one. I've already sent some patches. I probably need a patch for index.php as well.

     
  • Paul Vriens

    Paul Vriens - 2007-09-25

    Logged In: YES
    user_id=1877250
    Originator: YES

    Just another remark. Even though it's better now, there is still the Timezone issue. I guess what we want to show is the graph of the real commit dates and not a graph where the dates are turned into local date/time.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.