[Gitslave-devs] [ gitslave-Bugs-3481722 ] Remove unecessary DESTDIR

[SourceForge.net <no...@so...>]

Bugs item #3481722, was opened at 2012-01-30 10:52
Message generated for change (Settings changed) made by dupuy
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1475673&aid=3481722&group_id=353214

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: None
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jehan Bing (nahor)
>Assigned to: Alexander Dupuy (dupuy)
Summary: Remove unecessary DESTDIR

Initial Comment:
"DESTDIR" and "prefix" should be one variable. People are more likely to want to install gitslave in "/home/john/bin" than "/home/john/usr/local/bin".

Moreover, as-is, gitslave doesn't install on Windows because the current default path is "//usr/local" because of the '/' between DESTDIR and prefix and that prefix is an absolute path. This default path references the shared directory "local" on the machine "usr".
And on Unix, if one were to use a relative path in prefix, the installation will be done relative to the root folder ("/../[...]") instead of the current folder.

New usage after applying the path:
    make install # for the default location, i.e. /usr/local/...
    make install prefix=[path] # for a non default location.

----------------------------------------------------------------------

Comment By: Alexander Dupuy (dupuy)
Date: 2012-01-30 11:26

Message:
The initial double slash (//usr/local/bin/gits) is due to a / between
$(DESTDIR) and $(prefix) in the install target.
I just pushed a commit to the git repository that fixes this.  Given the
DESTDIR convention used by Gentoo and the fact that the lead developer's
own systems run Gentoo, this is probably as fixed as this bug will get. 
You should be able to ignore the presence of DESTDIR now, though.

----------------------------------------------------------------------

Comment By: Jehan Bing (nahor)
Date: 2012-01-30 11:21

Message:
Nothing prevents prefix (or DESTDIR) to be
"/var/tmp/portage/ebuild/gitslave/usr/local", unless Gentoo (or others)
expects both variables to be present of course. I believe for Gentoo it
would be something like "make prefix="${D}/usr/local".

But well, bike shed and stuff :p. This was really just an attempt to fix
the extra "/", which is not a manipulation error but because you have an
explicit '/' between DESTDIR and prefix.
    DESTDIR / prefix => "" / "/usr/local"
With DESTDIR=/, you would get 3 slashes: "/" / "/usr/local"

----------------------------------------------------------------------

Comment By: Baka Project (bakaproject)
Date: 2012-01-30 11:02

Message:
Thank you for your comment.  However, we will not be eliminating one of
DESTDIR/prefix.  Some operating systems, like Gentoo, use methods of
installation where they do indeed install into somnething like
/var/tmp/portage/ebuild/gitslave/usr/bin/gits but after installation the
binary appears in /usr/bin/gits

I'm not sure how you got the // problem though.  By default the DESTDIR
variable is unset/empty, so it would expand to only one slash.  Only if you
manually specified DESTDIR=/ would you get two slashes.  Solution:  don't
do that.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=1475673&aid=3481722&group_id=353214