Re: [Gitclipse-devel] pull/push changes

[Paul M. B. <pm...@ny...>]

Patrick,

There was a bug in DotGitMonitor, in that there was a pre-condition to have a '.git' folder somewhere from the project root and up.  (this was assumed, not tested)
And, GitProviderPlugin.map should have checked with isManagedByGit before calling out [I have added this logic]

However, I believe the problem was with your test.

Look at GitProviderPluginTest testIsAssociated:34

You wrote: "//Test mapped project, this should fail because there's no meta info."

Then you try to map a project (with no .git dir), and an exeption is thrown (correctly).
However, now you fail on exception...  [I have fixed this]

So, all that remains is to figure out why testRefresh is still failing on the build system
It was failing for me, but I fixed it by adding .waitFor() to the end of the processBuilder.start() calls, b/c a separate process is forked, and it is important not to look for .git etc until the creating process finishes.

Now it works for me, but not on CC (btw - can we compile with debug info so we can get the line# where the assertion is failing?)

-Paul





----- Original Message -----
From: Patrick C Winters <pat...@ny...>
Date: Monday, August 4, 2008 2:16 pm
Subject: Re: [Gitclipse-devel] pull/push changes
To: Andrew Case <ac...@co...>
Cc: Paul Munson Bethe <pm...@ny...>, git...@li...


> Since Friday night the build was fixed and set to fail with test 
> errors.  Since Saturday night Michelle and I got the tests running 
> correctly and the build publishing the results.  Remember that the 
> build is using the latest javagit jar, so if your project isn't 
> compiling locally, you might need to update javagit on your machine.
> 
> Since we got it running, there's been exceptions and failures related 
> to the DotGitMonitor and Decorator.  I'm pretty sure this is related 
> to tests I created that import and use projects outside the workspace. 
>  Although this was mostly Paul's work, anybody with time can take a 
> look at it.  This should be top priority.  We need to support external 
> projects if gitclipse is going to be useful.
> 
> I sent a link in another thread about IResources, what they represent, 
> and how to get their java.io.File counterparts.  It's in the Eclipse 
> programmer's guide in the section on IResources.
> --
> Patrick
> 
> ----- Original Message -----
> From: Andrew Case <ac...@co...>
> Date: Monday, August 4, 2008 1:52 pm
> Subject: Re: [Gitclipse-devel] pull/push changes
> To: Paul Munson Bethe <pm...@ny...>
> Cc: git...@li...
> 
> > It was compiling fine on my machine.  I shouldn't have to care about 
> 
> > your machine.  That's what cruisecontrol is for.  My commit didn't 
> > break 
> > the CC build, it was already broken.  And has been for days on end!  
> 
> > This 
> > makes it impossible for me to commit something and know if it's 
> going 
> > to 
> > break your build or not.
> > 
> > Paul, As mentioned before, it looks like it's your tests that are 
> > causing 
> > the failure... please clean it up, ASAP.  Otherwise this will get 
> > worse 
> > the more people commit.
> > 
> > --
> > Drew
> > 
> > 
> > 
> > On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > 
> > >
> > > Well, on Saturday night, core and UI were building on my machine 
> > (though 
> > > tests were failing).
> > >
> > > Today, UI was failing to even compile due to those changes.  I 
> have 
> > 
> > > checked in the commented out version that at least compile.  About 
> 
> > to 
> > > have a fixed test that should fix the tests.
> > >
> > > ----- Original Message -----
> > > From: Andrew Case <ac...@co...>
> > > Date: Monday, August 4, 2008 1:18 pm
> > > Subject: Re: [Gitclipse-devel] pull/push changes
> > > To: Paul Munson Bethe <pm...@ny...>
> > > Cc: git...@li...
> > >
> > >
> > >> Did cruisecontrol move somewhere else that I'm aware of?  I haven't
> > >> seen
> > >> it build successfully in days!  It was broken way before my changes.
> > >>
> > >> --
> > >> Drew
> > >>
> > >>
> > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > >>
> > >>> Andrew,
> > >>>
> > >>> your changes (648) to GitPull/GitPush have broken the build...
> > >>>
> > >>> As we are not exposing those operations in the pre-alpha, I will
> > >> comment out the calling code in PullPage/PushPage
> > >>>
> > >>> Question to all:  Why did this not break cruise-control?
> > >>>
> > >>> -P
> > >>>
> > >>>
> > >>> -------------------------------------------------------------------------
> > >>> This SF.Net email is sponsored by the Moblin Your Move 
> Developer's 
> > challenge
> > >>> Build the coolest Linux based applications with Moblin SDK & win
> > >> great prizes
> > >>> Grand prize is a trip for two to an Open Source event anywhere in
> > >> the world
> > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > >>> _______________________________________________
> > >>> Gitclipse-devel mailing list
> > >>> Git...@li...
> > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> > >>>
> > >
> > 
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win 
> great 
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in 
> the 
> > world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Gitclipse-devel mailing list
> > Git...@li...
> > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel