From: Paul M. B. <pm...@ny...> - 2008-08-04 18:17:17
|
OK - fair enough. But it did break the compile - so first of all, I am wondering why this passed through that stage of CC. 2nd (amusingly): If I run the build and junit tests, they work for me. (using the fix I just committed) However they still appear to be broken on Cruise Control: Based on the log, it looks like what I had BEFORE I fixed my tests... SO, based on #1, and #2 I am wondering if cruise is actually pulling down the new source code? Patrick/Michelle, can you double check this? If the timestamp for .ui.test/.../DecoratorTest.java is not from after 1:30 today, then we have the problem. -Paul ----- Original Message ----- From: Andrew Case <ac...@co...> Date: Monday, August 4, 2008 1:53 pm Subject: Re: [Gitclipse-devel] pull/push changes To: Paul Munson Bethe <pm...@ny...> Cc: Andrew Case <ac...@co...>, git...@li... > It was compiling fine on my machine. I shouldn't have to care about > your machine. That's what cruisecontrol is for. My commit didn't > break > the CC build, it was already broken. And has been for days on end! > This > makes it impossible for me to commit something and know if it's going > to > break your build or not. > > Paul, As mentioned before, it looks like it's your tests that are > causing > the failure... please clean it up, ASAP. Otherwise this will get > worse > the more people commit. > > -- > Drew > > > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > > > > > Well, on Saturday night, core and UI were building on my machine > (though > > tests were failing). > > > > Today, UI was failing to even compile due to those changes. I have > > > checked in the commented out version that at least compile. About > to > > have a fixed test that should fix the tests. > > > > ----- Original Message ----- > > From: Andrew Case <ac...@co...> > > Date: Monday, August 4, 2008 1:18 pm > > Subject: Re: [Gitclipse-devel] pull/push changes > > To: Paul Munson Bethe <pm...@ny...> > > Cc: git...@li... > > > > > >> Did cruisecontrol move somewhere else that I'm aware of? I haven't > >> seen > >> it build successfully in days! It was broken way before my changes. > >> > >> -- > >> Drew > >> > >> > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote: > >> > >>> Andrew, > >>> > >>> your changes (648) to GitPull/GitPush have broken the build... > >>> > >>> As we are not exposing those operations in the pre-alpha, I will > >> comment out the calling code in PullPage/PushPage > >>> > >>> Question to all: Why did this not break cruise-control? > >>> > >>> -P > >>> > >>> > >>> ------------------------------------------------------------------------- > >>> This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > >>> Build the coolest Linux based applications with Moblin SDK & win > >> great prizes > >>> Grand prize is a trip for two to an Open Source event anywhere in > >> the world > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ > >>> _______________________________________________ > >>> Gitclipse-devel mailing list > >>> Git...@li... > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel > >>> > > |