[Gitclipse-devel] GitStatusAdapter refactoring

[Michelle S O. <ms...@ny...>]

Hey guys,

Just a heads up that I'm going to town on the GitStatusAdapter. The basic idea is to store the results in a form that lends itself more easily to efficient queries, either by status or by file. Rather than writing a new custom method every time we need a different kind of status query, there are going to be a small handful of methods which rely on filters to return the desired GitResources. You'll be able to query based on status (eg, give me all GitResources having this status) or by file. There will also be static factory methods to replace what's becoming a proliferation of constructors.

I'm really leery of replacing existing code just yet since there aren't tests, so I'm going to deprecate the old methods and leave it to you guys to switch over to the new ones. I'll implement filters to match the functionality of the old methods and make them available as static classes on GitStatusAdapter, so all you'll have to do is replace your method calls with the new methods/filters and then make sure that nothing is broken (I can try to do that, but it's hard to test functionality that you're not all that familiar with yet).

Once you see the code it will hopefully make more sense than this explanation. If you guys decide that you hate it, you can undeprecate the old methods and continue to use those, but I'm hoping I can make this class a little neater.

Michelle