From: Andrew C. <ac...@co...> - 2008-07-29 01:03:15
|
You can change it however you want as long as it works I don't care. I changed it because the way it was wasn't working (I actually made the commit before I got your email) becuase from what I could tell, there wasn't a javagit-0.0.1-SNAPSHOT.jar file and that's what was being looked for. Something not mentioned earlier was that the .classpath file needs to be set to whatever the .jar is called too. Do it however you want, as long as it works (it works currently). -- Drew On Mon, 28 Jul 2008, Michelle S Osborne wrote: > I had fixed it right after I sent that email. Why are we changing the > references back again? It doesn't matter what the name of the file is, as > long as we're consistent with it. > > ----- Original Message ----- > From: Andrew Case <ac...@co...> > Date: Monday, July 28, 2008 2:55 pm > Subject: Re: [Gitclipse-build] Broken build > To: Michelle S Osborne <ms...@ny...> > Cc: Patrick Winters <pat...@ny...>, > git...@li... > >> Already fixed. Maybe you want to fix it a different way though. I >> changed all the references in .classpath, MANIFEST.MF, and >> build.properties to use "javagit.jar" instead of >> "javagit-0.0.1-SNAPSHOT.jar". It works. The catch... >> >> Everyone will have to rename their javagit-0.0.1-SNAPSHOT.jar to >> javagit.jar in their edu.nyu.cs.javagit directories. >> >> Thanks! >> >> -- >> Drew >> >> >> On Mon, 28 Jul 2008, Michelle S Osborne wrote: >> >>> Okay, I will fix this as soon as I get a chance. >>> >>> ----- Original Message ----- >>> From: Patrick Winters <pat...@ny...> >>> Date: Monday, July 28, 2008 12:41 pm >>> Subject: RE: [Gitclipse-build] Broken build >>> To: 'Michelle S Osborne' <ms...@ny...>, 'Andrew Case' >>> <ac...@co...> >>> Cc: git...@li... >>> >>> >>>> Look at line 6 of the javagit plug-ins manifest. >>>> http://linserv3.cims.nyu.edu:11000/browse/OSP/gitclipse/trunk/edu.nyu.cs.jav >>>> agit/META-INF/MANIFEST.MF?r=525#l6 >>>> >>>> The plug-in is explicitly exporting "javagit-0.01-SNAPSHOT.jar" on >> its >>>> classpath. If this isn't the filename when it's inside the project, >>>> it will >>>> probably try and build, but won't find any javagit classes. >>>> >>>> We could change the name once it's in the project to just be "javagit.jar" >>>> and update the manifest. But James tells me this filename won't >>>> change for >>>> a long time. The other option is to extract the classes from the jar >>>> into a >>>> "bin" folder so we don't have any explicit filename references. >>>> >>>> >>>>> -----Original Message----- >>>>> From: git...@li... [mailto:gitclipse- >>>>> bui...@li...] On Behalf Of Michelle S Osborne >>>>> Sent: Monday, July 28, 2008 12:24 PM >>>>> To: Andrew Case >>>>> Cc: git...@li... >>>>> Subject: Re: [Gitclipse-build] Broken build >>>>> >>>>> It's not named javagit-0.01-SNAPSHOT.jar. I thought we had the build >>>>> set up so that the name of the jar file didn't matter, as long as >> the >>>>> javagitJar property points to the correct jar. If that's not the case >>>>> let me know and I will change it. >>>>> >>>>> I'm not sure what version I'm up to on my machine, but I know at some >>>>> point last night I was able to build. I happen to have the jar file >>>>> named javagit-0.01-SNAPSHOT.jar though, so that doesn't prove anything. >>>>> >>>>> Stupid question, but when you change the name of the jarfile on your >>>>> machine do you also change the value of the javagitJar property in >>>>> build.local.properties? >>>>> >>>>> Michelle >>>>> >>>>> ----- Original Message ----- >>>>> From: Andrew Case <ac...@co...> >>>>> Date: Monday, July 28, 2008 11:14 am >>>>> Subject: Re: Broken build >>>>> To: Michelle S Osborne <ms...@ny...> >>>>> Cc: git...@li... >>>>> >>>>> >>>>>> Hmmm... I wonder what it's problem is. From the logs I see >>>>>> >>>>>> Copying /home/mso206/cruisecontrol/javagit.jar to >>>>>> /home/mso206/cruisecontrol/gitclipse- >>>>> build/plugins/edu.nyu.cs.javagit/javagit.jar >>>>>> >>>>>> Are you copying javagit.jar to javagit-0.01-SNAPSHOT.jar or does >> this >>>>>> not >>>>>> need to happen? On my computer if it's not named >>>>>> javagit-0.01-SNAPSHOT.jar the build fails (this would have been >>>>>> failing >>>>>> all along though in that case). >>>>>> >>>>>> If you get the updated MoveDeleteHook.java does it build on your >>>>> machine? >>>>>> >>>>>> Thanks, >>>>>> >>>>>> -- >>>>>> Drew >>>>>> >>>>>> P.S. Moving this to the proper list. >>>>>> >>>>>> >>>>>> On Mon, 28 Jul 2008, Michelle S Osborne wrote: >>>>>> >>>>>>> It's already doing that.. >>>>>>> >>>>>>> ----- Original Message ----- >>>>>>> From: Patrick Winters <pat...@ny...> >>>>>>> Date: Sunday, July 27, 2008 11:48 pm >>>>>>> Subject: RE: [Gitclipse-devel] Broken build >>>>>>> To: 'Michelle S Osborne' <ms...@ny...>, 'gitclipse-devel' >>>>> <git...@li...> >>>>>>> >>>>>>> >>>>>>>> Michelle, >>>>>>>> For the time being can you have the javagit build run "mvn >>>>> package" >>>>>>>> and >>>>>>>> point the gitclipse jar property to the one created by them? This >>>>>> way >>>>>>>> we'll >>>>>>>> stay up-to-date. >>>>>>>> -- >>>>>>>> Patrick >>>>>>>> >>>>>>>>> -----Original Message----- >>>>>>>>> From: git...@li... >>>>> [mailto:gitclipse- >>>>>>>>> dev...@li...] On Behalf Of Patrick Winters >>>>>>>>> Sent: Sunday, July 27, 2008 11:38 PM >>>>>>>>> To: 'Andrew Case'; 'gitclipse-devel' >>>>>>>>> Subject: Re: [Gitclipse-devel] Broken build >>>>>>>>> >>>>>>>>> I take this back, I might have an old javagit jar. We don't have >>>>>>>>> Cruise >>>>>>>>> Control staying up-to-date with javagit yet. I e-mailed them >>>>> about >>>>>>>>> publishing their nightly builds somewhere so we can download them >>>>>> to >>>>>>>>> copy >>>>>>>>> into our build. We didn't think it would be smart for us to be >>>>> running >>>>>>>>> their build script within ours. >>>>>>>>> >>>>>>>>>> -----Original Message----- >>>>>>>>>> From: git...@li... >>>>>>>>> [mailto:gitclipse- >>>>>>>>>> dev...@li...] On Behalf Of Patrick >>>>> Winters >>>>>>>>>> Sent: Sunday, July 27, 2008 11:26 PM >>>>>>>>>> To: 'Andrew Case'; 'gitclipse-devel' >>>>>>>>>> Subject: Re: [Gitclipse-devel] Broken build >>>>>>>>>> >>>>>>>>>> I just updated my projects, and the only build problem I see >>>>> here >>>>>>>> is >>>>>>>>> an >>>>>>>>>> incorrect import. In GitMoveDeleteHook you imported the >>>>>>>>>> "edu.nyu.cs.javagit.api.commands.GitStatus" but you are trying >>>>> to >>>>>>>> use >>>>>>>>>> methods that belong to the temporary placeholder >>>>>>>>>> "edu.nyu.cs.gitclipse.core.internal.GitStatus" >>>>>>>>>> >>>>>>>>>> I don't have the import error you mention. >>>>>>>>>> >>>>>>>>>>> -----Original Message----- >>>>>>>>>>> From: git...@li... >>>>>>>>>> [mailto:gitclipse- >>>>>>>>>>> dev...@li...] On Behalf Of Andrew Case >>>>>>>>>>> Sent: Sunday, July 27, 2008 8:27 PM >>>>>>>>>>> To: gitclipse-devel >>>>>>>>>>> Subject: [Gitclipse-devel] Broken build >>>>>>>>>>> >>>>>>>>>>> Michelle/Patrick, >>>>>>>>>>> >>>>>>>>>>> It looks like I'm the first one to commit some code that uses >>>>> the >>>>>>>>>>> javagit >>>>>>>>>>> API. It seems to have broken the build as CC doesn't seem to >>>>> be >>>>>>>>> able >>>>>>>>>>> to >>>>>>>>>>> find edu.nyu.cs.javagit.api.*. Is CC building >>>>> edu.nyu.cs.javagit? >>>>>>>>>> Is >>>>>>>>>>> the >>>>>>>>>>> jar included in the edu.nyu.cs.javagit? Any ideas on what >>>>> seems >>>>>>>> to >>>>>>>>>> be >>>>>>>>>>> missing here? >>>>>>>>>>> >>>>>>>>>>> Build log snippet >>>>>>>>>>> ----------------- >>>>>>>>>>> >>>>>>>>>>> <message priority="info">[javac] ----------</message> >>>>>>>>>>> - >>>>>>>>>>> <message priority="info"> >>>>>>>>>>> [javac] 1. ERROR in >>>>>>>>>>> /home/mso206/cruisecontrol/gitclipse- >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>> build/plugins/edu.nyu.cs.gitclipse.core/src/edu/nyu/cs/gitclipse/core/G >>>>>>>>>>> itMoveDeleteHook.java >>>>>>>>>>> (at line 15) >>>>>>>>>>> </message> >>>>>>>>>>> - >>>>>>>>>>> <message priority="info"> >>>>>>>>>>> [javac] import edu.nyu.cs.javagit.api.JavaGitException; >>>>>>>>>>> </message> >>>>>>>>>>> <message priority="info">[javac] >>>>>>>>>>> ^^^^^^^^^^^^^^^^^^</message> >>>>>>>>>>> - >>>>>>>>>>> <message priority="info"> >>>>>>>>>>> [javac] The import edu.nyu.cs.javagit cannot be resolved >>>>>>>>>>> </message> >>>>>>>>>>> <message priority="info">[javac] ----------</message> >>>>>>>>>>> <message priority="warn">BUILD FAILED</message> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> I just can't find the import >>>>>>>>> edu.nyu.cs.javagit.api.JavaGitException. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Drew >>>>>>>>>>> >>>>>>>>>>> --------------------------------------------------------------- >>>>> ---- >>>>>>>>> -- >>>>>>>>>> -- >>>>>>>>>>> -- >>>>>>>>>>> This SF.Net email is sponsored by the Moblin Your Move >>>>> Developer's >>>>>>>>>>> challenge >>>>>>>>>>> Build the coolest Linux based applications with Moblin SDK & >>>>> win >>>>>>>>>> great >>>>>>>>>>> prizes >>>>>>>>>>> Grand prize is a trip for two to an Open Source event anywhere >>>>> in >>>>>>>>> the >>>>>>>>>>> world >>>>>>>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>>>>>>>>> _______________________________________________ >>>>>>>>>>> Gitclipse-devel mailing list >>>>>>>>>>> Git...@li... >>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> ---------------------------------------------------------------- >>>>> ----- >>>>>>>>> -- >>>>>>>>>> -- >>>>>>>>>> This SF.Net email is sponsored by the Moblin Your Move >>>>> Developer's >>>>>>>>>> challenge >>>>>>>>>> Build the coolest Linux based applications with Moblin SDK & >>>> win >>>>>>>>> great >>>>>>>>>> prizes >>>>>>>>>> Grand prize is a trip for two to an Open Source event anywhere >>>>> in >>>>>>>> the >>>>>>>>>> world >>>>>>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>>>>>>>> _______________________________________________ >>>>>>>>>> Gitclipse-devel mailing list >>>>>>>>>> Git...@li... >>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> ----------------------------------------------------------------- >>>>> ------ >>>>>>>>> -- >>>>>>>>> This SF.Net email is sponsored by the Moblin Your Move >>>>> Developer's >>>>>>>>> challenge >>>>>>>>> Build the coolest Linux based applications with Moblin SDK & win >>>>> great >>>>>>>>> prizes >>>>>>>>> Grand prize is a trip for two to an Open Source event anywhere >>>> in >>>>>> the >>>>>>>>> world >>>>>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>>>>>>> _______________________________________________ >>>>>>>>> Gitclipse-devel mailing list >>>>>>>>> Git...@li... >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> ------------------------------------------------------------------- >>>>> ------ >>>>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's >>>>> challenge >>>>>>> Build the coolest Linux based applications with Moblin SDK & win >>>>>> great prizes >>>>>>> Grand prize is a trip for two to an Open Source event anywhere in >>>>>> the world >>>>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>>>>> _______________________________________________ >>>>>>> Gitclipse-devel mailing list >>>>>>> Git...@li... >>>>>>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel >>>>>>> >>>>> >>>>> ----------------------------------------------------------------------- >>>>> -- >>>>> This SF.Net email is sponsored by the Moblin Your Move Developer's >>>>> challenge >>>>> Build the coolest Linux based applications with Moblin SDK & win great >>>>> prizes >>>>> Grand prize is a trip for two to an Open Source event anywhere in >> the >>>>> world >>>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>>>> _______________________________________________ >>>>> Gitclipse-build mailing list >>>>> Git...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/gitclipse-build >>>> >>>> >>> >>> ------------------------------------------------------------------------- >>> This SF.Net email is sponsored by the Moblin Your Move Developer's >>> challenge >>> Build the coolest Linux based applications with Moblin SDK & win >> great prizes >>> Grand prize is a trip for two to an Open Source event anywhere in >> the world >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/ >>> _______________________________________________ >>> Gitclipse-build mailing list >>> Git...@li... >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-build >>> > |