Re: [Gitclipse-devel] Commands vs ActionDelegates code review

[Michelle S O. <ms...@ny...>]

I believe we're talking about two different things.. swapping out actions for commands vs swapping out dialogs for wizards. Switching the actions out for commands shouldn't take more than a few minutes.

I'm not sure how the argument that we're voluntarily using page abstractions when we implement dialogs is compelling. I really don't see the benefit of using one over the other, and both IDEs that I regularly use have dialogs rather than wizards for most svn-related tasks. I hate to be the argumentative one, but this just feels like a waste of effort for questionable benefit.

Michelle

----- Original Message -----
From: pm...@ny...
Date: Thursday, July 17, 2008 7:26 pm
Subject: Re: [Gitclipse-devel] Commands vs ActionDelegates code review
To: Michelle S Osborne <ms...@ny...>, Patrick Winters <pat...@ny...>
Cc: Code Review <git...@li...>, Git...@sc..., Gitclipse Devel <git...@li...>

> Hold on.  Patrick's previous argument was compelling, so I am sold on 
> wizards.
> 
> But let's not rewrite something for the sake of rewriting it until 
> this week's requirements for release are done. 
> 
> Remember this week's task list, they are all on the Milestones page.
> 
> * do we have a plugin build of javagit yet?
> 
> -P
> 
> 
> 
> ------Original Message------
> From: Michelle S Osborne
> Sender: 
> To: Patrick Winters
> Cc: Code Review
> Cc: Git...@sc...
> Cc: Gitclipse Devel
> Sent: Jul 17, 2008 6:55 PM
> Subject: Re: [Gitclipse-devel] Commands vs ActionDelegates code review
> 
> I'll take care of them.
> 
> ----- Original Message -----
> From: Patrick Winters <pat...@ny...>
> Date: Thursday, July 17, 2008 5:32 pm
> Subject: [Gitclipse-devel] Commands vs ActionDelegates code review
> To: Gitclipse Devel <git...@li...>
> Cc: Gitclipse Code Review <git...@li...>
> 
> 
> > In Gitclipse-5 I tried to convert some actions to the command 
> > framework.  We
> > have a lot of action delegates that need to be re-written as commands.
> > Anybody want to take a stab at it?
> > --
> > Patrick
> > 
> > 
> > 
> > 
> > 
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win 
> great 
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in 
> the 
> > world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Gitclipse-devel mailing list
> > Git...@li...
> > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great 
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the 
> world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Gitclipse-devel mailing list
> Git...@li...
> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> 
> 
> Sent via BlackBerry