gitclipse-devel

Re: [Gitclipse-devel] GitFileStatus changes

[<pm...@ny...>]

Sorry.  I thought I tested that, but I guess not...  I changed it because I needed to know about Untracked files, and it didn't make sense to extend the functionality when there was the similar class.

I will fix this tomorrow - I had to go out of town last night/today, and I forgot to make a code review.

Also, I think that failing test is my fault.  Generally me messing things up here :(

I will sort it all out tomorrow.

-Paul

------Original Message------
From: Michelle S Osborne
Sender: 
To: pm...@ny...
Cc: git...@li...
Sent: Aug 2, 2008 5:37 PM
Subject: GitFileStatus changes

Paul,

Why did you change all uses of GitFileStatus to GitResourceStatus? You asked in a code review if there was a reason why I didn't use it and I answered you. If you weren't satisfied with the answer you could have discussed it further rather than taking it upon yourself to replace uses of one with the other. You didn't even create a code review for that changeset, so I didn't get a chance to give you feedback, like for example to tell you that your changes broke the commit dialog's status display.

I may add more fields to that enum. I don't have the time to change all of the commit dialog's uses of GitResourceStatus back to GitFileStatus, so if I do need to add fields I'm going to make the getParentTransition method throw exceptions for them, because I doubt that the method will make sense in the context of how I'm planning on using the enum.

Michelle


Sent via BlackBerry

Re: [Gitclipse-devel] GitFileStatus changes

[<pm...@ny...>]

Great.  Again, I am really sorry.  I know how crappy it can be when someone else breaks code you worked hard on.

-PB

------Original Message------
From: Michelle S Osborne
Sender: 
To: pm...@ny...
Cc: git...@li...
Sent: Aug 2, 2008 6:58 PM
Subject: Re: GitFileStatus changes

Okay, I guess that makes sense for now. I'm still not sure that the different uses of this enum are ultimately going to represent the same abstraction, but we can always separate them again if that becomes apparent. It would have been nice to say something about making the change though, given our discussion in the code review.

The broken functionality is my fault too, because there really should be tests. Once commit and add are release-ready I'm going to focus solely on that. We should be able to refactor with confidence.

Michelle

----- Original Message -----
From: pm...@ny...
Date: Saturday, August 2, 2008 6:31 pm
Subject: Re: GitFileStatus changes
To: Michelle S Osborne <ms...@ny...>
Cc: git...@li...

> Sorry.  I thought I tested that, but I guess not...  I changed it 
> because I needed to know about Untracked files, and it didn't make 
> sense to extend the functionality when there was the similar class.
> 
> I will fix this tomorrow - I had to go out of town last night/today, 
> and I forgot to make a code review.
> 
> Also, I think that failing test is my fault.  Generally me messing 
> things up here :(
> 
> I will sort it all out tomorrow.
> 
> -Paul
> 
> ------Original Message------
> From: Michelle S Osborne
> Sender: 
> To: pm...@ny...
> Cc: git...@li...
> Sent: Aug 2, 2008 5:37 PM
> Subject: GitFileStatus changes
> 
> Paul,
> 
> Why did you change all uses of GitFileStatus to GitResourceStatus? You 
> asked in a code review if there was a reason why I didn't use it and I 
> answered you. If you weren't satisfied with the answer you could have 
> discussed it further rather than taking it upon yourself to replace 
> uses of one with the other. You didn't even create a code review for 
> that changeset, so I didn't get a chance to give you feedback, like 
> for example to tell you that your changes broke the commit dialog's 
> status display.
> 
> I may add more fields to that enum. I don't have the time to change 
> all of the commit dialog's uses of GitResourceStatus back to 
> GitFileStatus, so if I do need to add fields I'm going to make the 
> getParentTransition method throw exceptions for them, because I doubt 
> that the method will make sense in the context of how I'm planning on 
> using the enum.
> 
> Michelle
> 
> 
> Sent via BlackBerry


Sent via BlackBerry

Re: [Gitclipse-devel] GitFileStatus changes

[Michelle S O. <ms...@ny...>]

Okay, I guess that makes sense for now. I'm still not sure that the different uses of this enum are ultimately going to represent the same abstraction, but we can always separate them again if that becomes apparent. It would have been nice to say something about making the change though, given our discussion in the code review.

The broken functionality is my fault too, because there really should be tests. Once commit and add are release-ready I'm going to focus solely on that. We should be able to refactor with confidence.

Michelle

----- Original Message -----
From: pm...@ny...
Date: Saturday, August 2, 2008 6:31 pm
Subject: Re: GitFileStatus changes
To: Michelle S Osborne <ms...@ny...>
Cc: git...@li...

> Sorry.  I thought I tested that, but I guess not...  I changed it 
> because I needed to know about Untracked files, and it didn't make 
> sense to extend the functionality when there was the similar class.
> 
> I will fix this tomorrow - I had to go out of town last night/today, 
> and I forgot to make a code review.
> 
> Also, I think that failing test is my fault.  Generally me messing 
> things up here :(
> 
> I will sort it all out tomorrow.
> 
> -Paul
> 
> ------Original Message------
> From: Michelle S Osborne
> Sender: 
> To: pm...@ny...
> Cc: git...@li...
> Sent: Aug 2, 2008 5:37 PM
> Subject: GitFileStatus changes
> 
> Paul,
> 
> Why did you change all uses of GitFileStatus to GitResourceStatus? You 
> asked in a code review if there was a reason why I didn't use it and I 
> answered you. If you weren't satisfied with the answer you could have 
> discussed it further rather than taking it upon yourself to replace 
> uses of one with the other. You didn't even create a code review for 
> that changeset, so I didn't get a chance to give you feedback, like 
> for example to tell you that your changes broke the commit dialog's 
> status display.
> 
> I may add more fields to that enum. I don't have the time to change 
> all of the commit dialog's uses of GitResourceStatus back to 
> GitFileStatus, so if I do need to add fields I'm going to make the 
> getParentTransition method throw exceptions for them, because I doubt 
> that the method will make sense in the context of how I'm planning on 
> using the enum.
> 
> Michelle
> 
> 
> Sent via BlackBerry

Re: [Gitclipse-devel] GitFileStatus changes

[Paul M. B. <pm...@ny...>]

What is interesting about this is the following:

Map<K,T>.get takes type Object, not K...

So ResourceLabelProvider.java:86 - I would have expected a compiler error, since I changed resource.status to return GitResourceStatus - but no, both compatible with Object...  thus the problem.

Fixed, and checked in now.

-Paul


----- Original Message -----
From: Michelle S Osborne <ms...@ny...>
Date: Saturday, August 2, 2008 6:58 pm
Subject: Re: GitFileStatus changes
To: pm...@ny...
Cc: git...@li...


> Okay, I guess that makes sense for now. I'm still not sure that the 
> different uses of this enum are ultimately going to represent the same 
> abstraction, but we can always separate them again if that becomes 
> apparent. It would have been nice to say something about making the 
> change though, given our discussion in the code review.
> 
> The broken functionality is my fault too, because there really should 
> be tests. Once commit and add are release-ready I'm going to focus 
> solely on that. We should be able to refactor with confidence.
> 
> Michelle
> 
> ----- Original Message -----
> From: pm...@ny...
> Date: Saturday, August 2, 2008 6:31 pm
> Subject: Re: GitFileStatus changes
> To: Michelle S Osborne <ms...@ny...>
> Cc: git...@li...
> 
> > Sorry.  I thought I tested that, but I guess not...  I changed it 
> > because I needed to know about Untracked files, and it didn't make 
> > sense to extend the functionality when there was the similar class.
> > 
> > I will fix this tomorrow - I had to go out of town last night/today, 
> 
> > and I forgot to make a code review.
> > 
> > Also, I think that failing test is my fault.  Generally me messing 
> > things up here :(
> > 
> > I will sort it all out tomorrow.
> > 
> > -Paul
> > 
> > ------Original Message------
> > From: Michelle S Osborne
> > Sender: 
> > To: pm...@ny...
> > Cc: git...@li...
> > Sent: Aug 2, 2008 5:37 PM
> > Subject: GitFileStatus changes
> > 
> > Paul,
> > 
> > Why did you change all uses of GitFileStatus to GitResourceStatus? 
> You 
> > asked in a code review if there was a reason why I didn't use it and 
> I 
> > answered you. If you weren't satisfied with the answer you could 
> have 
> > discussed it further rather than taking it upon yourself to replace 
> 
> > uses of one with the other. You didn't even create a code review for 
> 
> > that changeset, so I didn't get a chance to give you feedback, like 
> 
> > for example to tell you that your changes broke the commit dialog's 
> 
> > status display.
> > 
> > I may add more fields to that enum. I don't have the time to change 
> 
> > all of the commit dialog's uses of GitResourceStatus back to 
> > GitFileStatus, so if I do need to add fields I'm going to make the 
> > getParentTransition method throw exceptions for them, because I 
> doubt 
> > that the method will make sense in the context of how I'm planning 
> on 
> > using the enum.
> > 
> > Michelle
> > 
> > 
> > Sent via BlackBerry

Re: [Gitclipse-devel] GitFileStatus changes

[Michelle S O. <ms...@ny...>]

That is weird, now that you point it out. The argument types to 'put' are bound at compile-time but 'get' seems to ignore generics altogether.. anyone know why that is?

Michelle

----- Original Message -----
From: Paul Munson Bethe <pm...@ny...>
Date: Saturday, August 2, 2008 10:20 pm
Subject: Re: GitFileStatus changes
To: Michelle S Osborne <ms...@ny...>
Cc: git...@li...

> What is interesting about this is the following:
> 
> Map<K,T>.get takes type Object, not K...
> 
> So ResourceLabelProvider.java:86 - I would have expected a compiler 
> error, since I changed resource.status to return GitResourceStatus - 
> but no, both compatible with Object...  thus the problem.
> 
> Fixed, and checked in now.
> 
> -Paul
> 
> 
> ----- Original Message -----
> From: Michelle S Osborne <ms...@ny...>
> Date: Saturday, August 2, 2008 6:58 pm
> Subject: Re: GitFileStatus changes
> To: pm...@ny...
> Cc: git...@li...
> 
> 
> > Okay, I guess that makes sense for now. I'm still not sure that the 
> 
> > different uses of this enum are ultimately going to represent the 
> same 
> > abstraction, but we can always separate them again if that becomes 
> > apparent. It would have been nice to say something about making the 
> 
> > change though, given our discussion in the code review.
> > 
> > The broken functionality is my fault too, because there really 
> should 
> > be tests. Once commit and add are release-ready I'm going to focus 
> > solely on that. We should be able to refactor with confidence.
> > 
> > Michelle
> > 
> > ----- Original Message -----
> > From: pm...@ny...
> > Date: Saturday, August 2, 2008 6:31 pm
> > Subject: Re: GitFileStatus changes
> > To: Michelle S Osborne <ms...@ny...>
> > Cc: git...@li...
> > 
> > > Sorry.  I thought I tested that, but I guess not...  I changed it 
> 
> > > because I needed to know about Untracked files, and it didn't make 
> 
> > > sense to extend the functionality when there was the similar class.
> > > 
> > > I will fix this tomorrow - I had to go out of town last 
> night/today, 
> > 
> > > and I forgot to make a code review.
> > > 
> > > Also, I think that failing test is my fault.  Generally me messing 
> 
> > > things up here :(
> > > 
> > > I will sort it all out tomorrow.
> > > 
> > > -Paul
> > > 
> > > ------Original Message------
> > > From: Michelle S Osborne
> > > Sender: 
> > > To: pm...@ny...
> > > Cc: git...@li...
> > > Sent: Aug 2, 2008 5:37 PM
> > > Subject: GitFileStatus changes
> > > 
> > > Paul,
> > > 
> > > Why did you change all uses of GitFileStatus to GitResourceStatus? 
> 
> > You 
> > > asked in a code review if there was a reason why I didn't use it 
> and 
> > I 
> > > answered you. If you weren't satisfied with the answer you could 
> > have 
> > > discussed it further rather than taking it upon yourself to 
> replace 
> > 
> > > uses of one with the other. You didn't even create a code review 
> for 
> > 
> > > that changeset, so I didn't get a chance to give you feedback, 
> like 
> > 
> > > for example to tell you that your changes broke the commit 
> dialog's 
> > 
> > > status display.
> > > 
> > > I may add more fields to that enum. I don't have the time to 
> change 
> > 
> > > all of the commit dialog's uses of GitResourceStatus back to 
> > > GitFileStatus, so if I do need to add fields I'm going to make the 
> 
> > > getParentTransition method throw exceptions for them, because I 
> > doubt 
> > > that the method will make sense in the context of how I'm planning 
> 
> > on 
> > > using the enum.
> > > 
> > > Michelle
> > > 
> > > 
> > > Sent via BlackBerry

[Gitclipse-devel] pull/push changes

[Paul M. B. <pm...@ny...>]

Andrew,

your changes (648) to GitPull/GitPush have broken the build...

As we are not exposing those operations in the pre-alpha, I will comment out the calling code in PullPage/PushPage

Question to all:  Why did this not break cruise-control?

-P

[Gitclipse-devel] Website problems

[Andrew C. <ac...@co...>]

Hey Paul,

I was seeing the php errors that you ran into on the website.  I think it 
probably has something to do with a misconfigured sf.net webserver node in 
which it doesn't look in the current directory path for include files 
(while the other cluster nodes do).  I'm substituting a workaround for 
both our sites.

--
Drew


On Mon, 4 Aug 2008, Paul Munson Bethe wrote:

> Andrew,
>
> your changes (648) to GitPull/GitPush have broken the build...
>
> As we are not exposing those operations in the pre-alpha, I will comment out the calling code in PullPage/PushPage
>
> Question to all:  Why did this not break cruise-control?
>
> -P
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Gitclipse-devel mailing list
> Git...@li...
> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
>

Re: [Gitclipse-devel] pull/push changes

[Andrew C. <ac...@co...>]

Did cruisecontrol move somewhere else that I'm aware of?  I haven't seen 
it build successfully in days!  It was broken way before my changes.

--
Drew


On Mon, 4 Aug 2008, Paul Munson Bethe wrote:

> Andrew,
>
> your changes (648) to GitPull/GitPush have broken the build...
>
> As we are not exposing those operations in the pre-alpha, I will comment out the calling code in PullPage/PushPage
>
> Question to all:  Why did this not break cruise-control?
>
> -P
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Gitclipse-devel mailing list
> Git...@li...
> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
>

Re: [Gitclipse-devel] pull/push changes

[Paul M. B. <pm...@ny...>]

Well, on Saturday night, core and UI were building on my machine (though tests were failing).

Today, UI was failing to even compile due to those changes.  I have checked in the commented out version that at least compile.  About to have a fixed test that should fix the tests.

----- Original Message -----
From: Andrew Case <ac...@co...>
Date: Monday, August 4, 2008 1:18 pm
Subject: Re: [Gitclipse-devel] pull/push changes
To: Paul Munson Bethe <pm...@ny...>
Cc: git...@li...


> Did cruisecontrol move somewhere else that I'm aware of?  I haven't 
> seen 
> it build successfully in days!  It was broken way before my changes.
> 
> --
> Drew
> 
> 
> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> 
> > Andrew,
> >
> > your changes (648) to GitPull/GitPush have broken the build...
> >
> > As we are not exposing those operations in the pre-alpha, I will 
> comment out the calling code in PullPage/PushPage
> >
> > Question to all:  Why did this not break cruise-control?
> >
> > -P
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win 
> great prizes
> > Grand prize is a trip for two to an Open Source event anywhere in 
> the world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Gitclipse-devel mailing list
> > Git...@li...
> > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> >

Re: [Gitclipse-devel] pull/push changes

[Andrew C. <ac...@co...>]

It was compiling fine on my machine.  I shouldn't have to care about 
your machine.  That's what cruisecontrol is for.  My commit didn't break 
the CC build, it was already broken.  And has been for days on end!  This 
makes it impossible for me to commit something and know if it's going to 
break your build or not.

Paul, As mentioned before, it looks like it's your tests that are causing 
the failure... please clean it up, ASAP.  Otherwise this will get worse 
the more people commit.

--
Drew



On Mon, 4 Aug 2008, Paul Munson Bethe wrote:

>
> Well, on Saturday night, core and UI were building on my machine (though 
> tests were failing).
>
> Today, UI was failing to even compile due to those changes.  I have 
> checked in the commented out version that at least compile.  About to 
> have a fixed test that should fix the tests.
>
> ----- Original Message -----
> From: Andrew Case <ac...@co...>
> Date: Monday, August 4, 2008 1:18 pm
> Subject: Re: [Gitclipse-devel] pull/push changes
> To: Paul Munson Bethe <pm...@ny...>
> Cc: git...@li...
>
>
>> Did cruisecontrol move somewhere else that I'm aware of?  I haven't
>> seen
>> it build successfully in days!  It was broken way before my changes.
>>
>> --
>> Drew
>>
>>
>> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
>>
>>> Andrew,
>>>
>>> your changes (648) to GitPull/GitPush have broken the build...
>>>
>>> As we are not exposing those operations in the pre-alpha, I will
>> comment out the calling code in PullPage/PushPage
>>>
>>> Question to all:  Why did this not break cruise-control?
>>>
>>> -P
>>>
>>>
>>> -------------------------------------------------------------------------
>>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>>> Build the coolest Linux based applications with Moblin SDK & win
>> great prizes
>>> Grand prize is a trip for two to an Open Source event anywhere in
>> the world
>>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>> _______________________________________________
>>> Gitclipse-devel mailing list
>>> Git...@li...
>>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
>>>
>

Re: [Gitclipse-devel] pull/push changes

[Patrick C W. <pat...@ny...>]

Since Friday night the build was fixed and set to fail with test errors.  Since Saturday night Michelle and I got the tests running correctly and the build publishing the results.  Remember that the build is using the latest javagit jar, so if your project isn't compiling locally, you might need to update javagit on your machine.

Since we got it running, there's been exceptions and failures related to the DotGitMonitor and Decorator.  I'm pretty sure this is related to tests I created that import and use projects outside the workspace.  Although this was mostly Paul's work, anybody with time can take a look at it.  This should be top priority.  We need to support external projects if gitclipse is going to be useful.

I sent a link in another thread about IResources, what they represent, and how to get their java.io.File counterparts.  It's in the Eclipse programmer's guide in the section on IResources.
--
Patrick

----- Original Message -----
From: Andrew Case <ac...@co...>
Date: Monday, August 4, 2008 1:52 pm
Subject: Re: [Gitclipse-devel] pull/push changes
To: Paul Munson Bethe <pm...@ny...>
Cc: git...@li...

> It was compiling fine on my machine.  I shouldn't have to care about 
> your machine.  That's what cruisecontrol is for.  My commit didn't 
> break 
> the CC build, it was already broken.  And has been for days on end!  
> This 
> makes it impossible for me to commit something and know if it's going 
> to 
> break your build or not.
> 
> Paul, As mentioned before, it looks like it's your tests that are 
> causing 
> the failure... please clean it up, ASAP.  Otherwise this will get 
> worse 
> the more people commit.
> 
> --
> Drew
> 
> 
> 
> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> 
> >
> > Well, on Saturday night, core and UI were building on my machine 
> (though 
> > tests were failing).
> >
> > Today, UI was failing to even compile due to those changes.  I have 
> 
> > checked in the commented out version that at least compile.  About 
> to 
> > have a fixed test that should fix the tests.
> >
> > ----- Original Message -----
> > From: Andrew Case <ac...@co...>
> > Date: Monday, August 4, 2008 1:18 pm
> > Subject: Re: [Gitclipse-devel] pull/push changes
> > To: Paul Munson Bethe <pm...@ny...>
> > Cc: git...@li...
> >
> >
> >> Did cruisecontrol move somewhere else that I'm aware of?  I haven't
> >> seen
> >> it build successfully in days!  It was broken way before my changes.
> >>
> >> --
> >> Drew
> >>
> >>
> >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> >>
> >>> Andrew,
> >>>
> >>> your changes (648) to GitPull/GitPush have broken the build...
> >>>
> >>> As we are not exposing those operations in the pre-alpha, I will
> >> comment out the calling code in PullPage/PushPage
> >>>
> >>> Question to all:  Why did this not break cruise-control?
> >>>
> >>> -P
> >>>
> >>>
> >>> -------------------------------------------------------------------------
> >>> This SF.Net email is sponsored by the Moblin Your Move Developer's 
> challenge
> >>> Build the coolest Linux based applications with Moblin SDK & win
> >> great prizes
> >>> Grand prize is a trip for two to an Open Source event anywhere in
> >> the world
> >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>> _______________________________________________
> >>> Gitclipse-devel mailing list
> >>> Git...@li...
> >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> >>>
> >
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great 
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the 
> world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Gitclipse-devel mailing list
> Git...@li...
> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel

Re: [Gitclipse-devel] pull/push changes

[Paul M. B. <pm...@ny...>]

Patrick,

There was a bug in DotGitMonitor, in that there was a pre-condition to have a '.git' folder somewhere from the project root and up.  (this was assumed, not tested)
And, GitProviderPlugin.map should have checked with isManagedByGit before calling out [I have added this logic]

However, I believe the problem was with your test.

Look at GitProviderPluginTest testIsAssociated:34

You wrote: "//Test mapped project, this should fail because there's no meta info."

Then you try to map a project (with no .git dir), and an exeption is thrown (correctly).
However, now you fail on exception...  [I have fixed this]

So, all that remains is to figure out why testRefresh is still failing on the build system
It was failing for me, but I fixed it by adding .waitFor() to the end of the processBuilder.start() calls, b/c a separate process is forked, and it is important not to look for .git etc until the creating process finishes.

Now it works for me, but not on CC (btw - can we compile with debug info so we can get the line# where the assertion is failing?)

-Paul





----- Original Message -----
From: Patrick C Winters <pat...@ny...>
Date: Monday, August 4, 2008 2:16 pm
Subject: Re: [Gitclipse-devel] pull/push changes
To: Andrew Case <ac...@co...>
Cc: Paul Munson Bethe <pm...@ny...>, git...@li...


> Since Friday night the build was fixed and set to fail with test 
> errors.  Since Saturday night Michelle and I got the tests running 
> correctly and the build publishing the results.  Remember that the 
> build is using the latest javagit jar, so if your project isn't 
> compiling locally, you might need to update javagit on your machine.
> 
> Since we got it running, there's been exceptions and failures related 
> to the DotGitMonitor and Decorator.  I'm pretty sure this is related 
> to tests I created that import and use projects outside the workspace. 
>  Although this was mostly Paul's work, anybody with time can take a 
> look at it.  This should be top priority.  We need to support external 
> projects if gitclipse is going to be useful.
> 
> I sent a link in another thread about IResources, what they represent, 
> and how to get their java.io.File counterparts.  It's in the Eclipse 
> programmer's guide in the section on IResources.
> --
> Patrick
> 
> ----- Original Message -----
> From: Andrew Case <ac...@co...>
> Date: Monday, August 4, 2008 1:52 pm
> Subject: Re: [Gitclipse-devel] pull/push changes
> To: Paul Munson Bethe <pm...@ny...>
> Cc: git...@li...
> 
> > It was compiling fine on my machine.  I shouldn't have to care about 
> 
> > your machine.  That's what cruisecontrol is for.  My commit didn't 
> > break 
> > the CC build, it was already broken.  And has been for days on end!  
> 
> > This 
> > makes it impossible for me to commit something and know if it's 
> going 
> > to 
> > break your build or not.
> > 
> > Paul, As mentioned before, it looks like it's your tests that are 
> > causing 
> > the failure... please clean it up, ASAP.  Otherwise this will get 
> > worse 
> > the more people commit.
> > 
> > --
> > Drew
> > 
> > 
> > 
> > On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > 
> > >
> > > Well, on Saturday night, core and UI were building on my machine 
> > (though 
> > > tests were failing).
> > >
> > > Today, UI was failing to even compile due to those changes.  I 
> have 
> > 
> > > checked in the commented out version that at least compile.  About 
> 
> > to 
> > > have a fixed test that should fix the tests.
> > >
> > > ----- Original Message -----
> > > From: Andrew Case <ac...@co...>
> > > Date: Monday, August 4, 2008 1:18 pm
> > > Subject: Re: [Gitclipse-devel] pull/push changes
> > > To: Paul Munson Bethe <pm...@ny...>
> > > Cc: git...@li...
> > >
> > >
> > >> Did cruisecontrol move somewhere else that I'm aware of?  I haven't
> > >> seen
> > >> it build successfully in days!  It was broken way before my changes.
> > >>
> > >> --
> > >> Drew
> > >>
> > >>
> > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > >>
> > >>> Andrew,
> > >>>
> > >>> your changes (648) to GitPull/GitPush have broken the build...
> > >>>
> > >>> As we are not exposing those operations in the pre-alpha, I will
> > >> comment out the calling code in PullPage/PushPage
> > >>>
> > >>> Question to all:  Why did this not break cruise-control?
> > >>>
> > >>> -P
> > >>>
> > >>>
> > >>> -------------------------------------------------------------------------
> > >>> This SF.Net email is sponsored by the Moblin Your Move 
> Developer's 
> > challenge
> > >>> Build the coolest Linux based applications with Moblin SDK & win
> > >> great prizes
> > >>> Grand prize is a trip for two to an Open Source event anywhere in
> > >> the world
> > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > >>> _______________________________________________
> > >>> Gitclipse-devel mailing list
> > >>> Git...@li...
> > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> > >>>
> > >
> > 
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win 
> great 
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in 
> the 
> > world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Gitclipse-devel mailing list
> > Git...@li...
> > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel

Re: [Gitclipse-devel] pull/push changes

[Paul M. B. <pm...@ny...>]

OK - fair enough.  

But it did break the compile - so first of all, I am wondering why this passed through that stage of CC.

2nd (amusingly): If I run the build and junit tests, they work for me.  (using the fix I just committed)

However they still appear to be broken on Cruise Control:  Based on the log, it looks like what I had BEFORE I fixed my tests...  

SO, based on #1, and #2 I am wondering if cruise is actually pulling down the new source code?

Patrick/Michelle, can you double check this? 
If the timestamp for .ui.test/.../DecoratorTest.java is not from after 1:30 today, then we have the problem.

-Paul


----- Original Message -----
From: Andrew Case <ac...@co...>
Date: Monday, August 4, 2008 1:53 pm
Subject: Re: [Gitclipse-devel] pull/push changes
To: Paul Munson Bethe <pm...@ny...>
Cc: Andrew Case <ac...@co...>, git...@li...


> It was compiling fine on my machine.  I shouldn't have to care about 
> your machine.  That's what cruisecontrol is for.  My commit didn't 
> break 
> the CC build, it was already broken.  And has been for days on end!  
> This 
> makes it impossible for me to commit something and know if it's going 
> to 
> break your build or not.
> 
> Paul, As mentioned before, it looks like it's your tests that are 
> causing 
> the failure... please clean it up, ASAP.  Otherwise this will get 
> worse 
> the more people commit.
> 
> --
> Drew
> 
> 
> 
> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> 
> >
> > Well, on Saturday night, core and UI were building on my machine 
> (though 
> > tests were failing).
> >
> > Today, UI was failing to even compile due to those changes.  I have 
> 
> > checked in the commented out version that at least compile.  About 
> to 
> > have a fixed test that should fix the tests.
> >
> > ----- Original Message -----
> > From: Andrew Case <ac...@co...>
> > Date: Monday, August 4, 2008 1:18 pm
> > Subject: Re: [Gitclipse-devel] pull/push changes
> > To: Paul Munson Bethe <pm...@ny...>
> > Cc: git...@li...
> >
> >
> >> Did cruisecontrol move somewhere else that I'm aware of?  I haven't
> >> seen
> >> it build successfully in days!  It was broken way before my changes.
> >>
> >> --
> >> Drew
> >>
> >>
> >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> >>
> >>> Andrew,
> >>>
> >>> your changes (648) to GitPull/GitPush have broken the build...
> >>>
> >>> As we are not exposing those operations in the pre-alpha, I will
> >> comment out the calling code in PullPage/PushPage
> >>>
> >>> Question to all:  Why did this not break cruise-control?
> >>>
> >>> -P
> >>>
> >>>
> >>> -------------------------------------------------------------------------
> >>> This SF.Net email is sponsored by the Moblin Your Move Developer's 
> challenge
> >>> Build the coolest Linux based applications with Moblin SDK & win
> >> great prizes
> >>> Grand prize is a trip for two to an Open Source event anywhere in
> >> the world
> >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> >>> _______________________________________________
> >>> Gitclipse-devel mailing list
> >>> Git...@li...
> >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> >>>
> >

Re: [Gitclipse-devel] pull/push changes

[Paul M. B. <pm...@ny...>]

Hmm...  OK - I fixed the ui tests, but the core tests still fail where Patrick indicated.

BTW - the link you sent Patrick did not work.

----- Original Message -----
From: Paul Munson Bethe <pm...@ny...>
Date: Monday, August 4, 2008 2:17 pm
Subject: Re: [Gitclipse-devel] pull/push changes
To: Andrew Case <ac...@co...>
Cc: git...@li...


> OK - fair enough.  
> 
> But it did break the compile - so first of all, I am wondering why 
> this passed through that stage of CC.
> 
> 2nd (amusingly): If I run the build and junit tests, they work for me. 
>  (using the fix I just committed)
> 
> However they still appear to be broken on Cruise Control:  Based on 
> the log, it looks like what I had BEFORE I fixed my tests...  
> 
> SO, based on #1, and #2 I am wondering if cruise is actually pulling 
> down the new source code?
> 
> Patrick/Michelle, can you double check this? 
> If the timestamp for .ui.test/.../DecoratorTest.java is not from after 
> 1:30 today, then we have the problem.
> 
> -Paul
> 
> 
> ----- Original Message -----
> From: Andrew Case <ac...@co...>
> Date: Monday, August 4, 2008 1:53 pm
> Subject: Re: [Gitclipse-devel] pull/push changes
> To: Paul Munson Bethe <pm...@ny...>
> Cc: Andrew Case <ac...@co...>, git...@li...
> 
> 
> > It was compiling fine on my machine.  I shouldn't have to care about 
> 
> > your machine.  That's what cruisecontrol is for.  My commit didn't 
> > break 
> > the CC build, it was already broken.  And has been for days on end!  
> 
> > This 
> > makes it impossible for me to commit something and know if it's 
> going 
> > to 
> > break your build or not.
> > 
> > Paul, As mentioned before, it looks like it's your tests that are 
> > causing 
> > the failure... please clean it up, ASAP.  Otherwise this will get 
> > worse 
> > the more people commit.
> > 
> > --
> > Drew
> > 
> > 
> > 
> > On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > 
> > >
> > > Well, on Saturday night, core and UI were building on my machine 
> > (though 
> > > tests were failing).
> > >
> > > Today, UI was failing to even compile due to those changes.  I 
> have 
> > 
> > > checked in the commented out version that at least compile.  About 
> 
> > to 
> > > have a fixed test that should fix the tests.
> > >
> > > ----- Original Message -----
> > > From: Andrew Case <ac...@co...>
> > > Date: Monday, August 4, 2008 1:18 pm
> > > Subject: Re: [Gitclipse-devel] pull/push changes
> > > To: Paul Munson Bethe <pm...@ny...>
> > > Cc: git...@li...
> > >
> > >
> > >> Did cruisecontrol move somewhere else that I'm aware of?  I haven't
> > >> seen
> > >> it build successfully in days!  It was broken way before my changes.
> > >>
> > >> --
> > >> Drew
> > >>
> > >>
> > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > >>
> > >>> Andrew,
> > >>>
> > >>> your changes (648) to GitPull/GitPush have broken the build...
> > >>>
> > >>> As we are not exposing those operations in the pre-alpha, I will
> > >> comment out the calling code in PullPage/PushPage
> > >>>
> > >>> Question to all:  Why did this not break cruise-control?
> > >>>
> > >>> -P
> > >>>
> > >>>
> > >>> -------------------------------------------------------------------------
> > >>> This SF.Net email is sponsored by the Moblin Your Move 
> Developer's 
> > challenge
> > >>> Build the coolest Linux based applications with Moblin SDK & win
> > >> great prizes
> > >>> Grand prize is a trip for two to an Open Source event anywhere in
> > >> the world
> > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > >>> _______________________________________________
> > >>> Gitclipse-devel mailing list
> > >>> Git...@li...
> > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> > >>>
> > >
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great 
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the 
> world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Gitclipse-devel mailing list
> Git...@li...
> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel

Re: [Gitclipse-devel] pull/push changes

[Paul M. B. <pm...@ny...>]

Ahh...  NYU mail cut off the link into 2 parts -- sorry tried a naive click-thru.   Working now.

----- Original Message -----
From: Paul Munson Bethe <pm...@ny...>
Date: Monday, August 4, 2008 2:22 pm
Subject: Re: [Gitclipse-devel] pull/push changes
Cc: git...@li...


> Hmm...  OK - I fixed the ui tests, but the core tests still fail where 
> Patrick indicated.
> 
> BTW - the link you sent Patrick did not work.
> 
> ----- Original Message -----
> From: Paul Munson Bethe <pm...@ny...>
> Date: Monday, August 4, 2008 2:17 pm
> Subject: Re: [Gitclipse-devel] pull/push changes
> To: Andrew Case <ac...@co...>
> Cc: git...@li...
> 
> 
> > OK - fair enough.  
> > 
> > But it did break the compile - so first of all, I am wondering why 
> > this passed through that stage of CC.
> > 
> > 2nd (amusingly): If I run the build and junit tests, they work for 
> me. 
> >  (using the fix I just committed)
> > 
> > However they still appear to be broken on Cruise Control:  Based on 
> 
> > the log, it looks like what I had BEFORE I fixed my tests...  
> > 
> > SO, based on #1, and #2 I am wondering if cruise is actually pulling 
> 
> > down the new source code?
> > 
> > Patrick/Michelle, can you double check this? 
> > If the timestamp for .ui.test/.../DecoratorTest.java is not from 
> after 
> > 1:30 today, then we have the problem.
> > 
> > -Paul
> > 
> > 
> > ----- Original Message -----
> > From: Andrew Case <ac...@co...>
> > Date: Monday, August 4, 2008 1:53 pm
> > Subject: Re: [Gitclipse-devel] pull/push changes
> > To: Paul Munson Bethe <pm...@ny...>
> > Cc: Andrew Case <ac...@co...>, git...@li...
> > 
> > 
> > > It was compiling fine on my machine.  I shouldn't have to care 
> about 
> > 
> > > your machine.  That's what cruisecontrol is for.  My commit didn't 
> 
> > > break 
> > > the CC build, it was already broken.  And has been for days on 
> end!  
> > 
> > > This 
> > > makes it impossible for me to commit something and know if it's 
> > going 
> > > to 
> > > break your build or not.
> > > 
> > > Paul, As mentioned before, it looks like it's your tests that are 
> 
> > > causing 
> > > the failure... please clean it up, ASAP.  Otherwise this will get 
> 
> > > worse 
> > > the more people commit.
> > > 
> > > --
> > > Drew
> > > 
> > > 
> > > 
> > > On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > > 
> > > >
> > > > Well, on Saturday night, core and UI were building on my machine 
> 
> > > (though 
> > > > tests were failing).
> > > >
> > > > Today, UI was failing to even compile due to those changes.  I 
> > have 
> > > 
> > > > checked in the commented out version that at least compile.  
> About 
> > 
> > > to 
> > > > have a fixed test that should fix the tests.
> > > >
> > > > ----- Original Message -----
> > > > From: Andrew Case <ac...@co...>
> > > > Date: Monday, August 4, 2008 1:18 pm
> > > > Subject: Re: [Gitclipse-devel] pull/push changes
> > > > To: Paul Munson Bethe <pm...@ny...>
> > > > Cc: git...@li...
> > > >
> > > >
> > > >> Did cruisecontrol move somewhere else that I'm aware of?  I haven't
> > > >> seen
> > > >> it build successfully in days!  It was broken way before my changes.
> > > >>
> > > >> --
> > > >> Drew
> > > >>
> > > >>
> > > >> On Mon, 4 Aug 2008, Paul Munson Bethe wrote:
> > > >>
> > > >>> Andrew,
> > > >>>
> > > >>> your changes (648) to GitPull/GitPush have broken the build...
> > > >>>
> > > >>> As we are not exposing those operations in the pre-alpha, I will
> > > >> comment out the calling code in PullPage/PushPage
> > > >>>
> > > >>> Question to all:  Why did this not break cruise-control?
> > > >>>
> > > >>> -P
> > > >>>
> > > >>>
> > > >>> -------------------------------------------------------------------------
> > > >>> This SF.Net email is sponsored by the Moblin Your Move 
> > Developer's 
> > > challenge
> > > >>> Build the coolest Linux based applications with Moblin SDK & win
> > > >> great prizes
> > > >>> Grand prize is a trip for two to an Open Source event anywhere 
> in
> > > >> the world
> > > >>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > > >>> _______________________________________________
> > > >>> Gitclipse-devel mailing list
> > > >>> Git...@li...
> > > >>> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> > > >>>
> > > >
> > 
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> > Build the coolest Linux based applications with Moblin SDK & win 
> great 
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in 
> the 
> > world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Gitclipse-devel mailing list
> > Git...@li...
> > https://lists.sourceforge.net/lists/listinfo/gitclipse-devel
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great 
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the 
> world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Gitclipse-devel mailing list
> Git...@li...
> https://lists.sourceforge.net/lists/listinfo/gitclipse-devel