Re: [Ginp-developers] Project Quality

[Doug C. <do...@cu...>]

Dear Brian,

I have a look at Jalopy and the maven plugin and it has got a bit more
complicated than it used to be.  Basically I have lost patience with
it.  I can not find a SUN standard configuration so the best match is
the Maven coding conventions and the Jalopy standard.  It used to be a
bit easier to use but now it has gone all wizard, gui, product,
commercial etc... and I therefore it is beyond me to be able to
integrate it into the project as i used to do.

I can switch to the SUN standard for checkstyle but this complains a lot
about the use of {()} etc....

Therefore I would suggest that we leave it as it is and new code is
formated manually.  Thank Jalopy for doing 95% of the formating for us
and the rest we do by hand as and when we can be bothered.  The
Checkstyle Maven standard is the authority on what is and is not well
formatted.  Maven issue a formatter config for different IDEs
(http://maven.apache.org/guides/development/guide-m2-development.html#Maven%20Code%20Style). 


Is this acceptable to you, or do you have a better idea.?

note
{
    JavaDocs have to be done by had but maybe your IDE can help.
}


All the best,

Doug

Brian Burch wrote:
> Doug Culnane wrote:
>   
>> Done a one time format of all code with Japloy default settings, and
>> checked it in.
>>     
>
> Fast work! My svn update collected a lot of changed source.
>
> I looked at a random source and thought the default jalopy settings were 
> a bit strange...
>
> - two blanks for any empty argument list.
>
> - some very long lines that will get warnings in the style checks.
>
> - argument lists split, but aligned too far over on the right.
>
>
> In general, I find it very readable.. and the tabs have gone so there 
> aren't any statement continuations hidden off the right of my page.
>
> However, the Checkstyle report claims there are 788 errors. Although 
> most are to do with javadoc, there are quite a lot that are not. Should 
> we change the rules for Jalopy or Checkstyle?
>
> Do you want to fine-tune, or just leave things alone?
>
> Either is OK with me, but I won't start the code quality work until you 
> say you have finished formatting.
>
> Thanks,
>
> Brian
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>