Re: [Ginp-developers] Project Quality

[Brian B. <br...@Pi...>]

Doug Culnane wrote:
> Done a one time format of all code with Japloy default settings, and
> checked it in.

Fast work! My svn update collected a lot of changed source.

I looked at a random source and thought the default jalopy settings were 
a bit strange...

- two blanks for any empty argument list.

- some very long lines that will get warnings in the style checks.

- argument lists split, but aligned too far over on the right.


In general, I find it very readable.. and the tabs have gone so there 
aren't any statement continuations hidden off the right of my page.

However, the Checkstyle report claims there are 788 errors. Although 
most are to do with javadoc, there are quite a lot that are not. Should 
we change the rules for Jalopy or Checkstyle?

Do you want to fine-tune, or just leave things alone?

Either is OK with me, but I won't start the code quality work until you 
say you have finished formatting.

Thanks,

Brian