Re: [Ginp-developers] Latest changes

[Doug C. <do...@cu...>]

Brian Burch wrote:
> Doug,
>
> You will see I've made quite a few changes (commit little and often) to 
> improve the quality of the existing unit tests, but I'm slightly puzzled 
> that I cannot find them on
> http://ginp.sourceforge.net/statscm/2007-01.html
>
> do you know why?
>   
I need to do a
> mvn clean site site:deploy
this updates the public website so let me know when you want it updated
and it will do it.

> You will see I've mainly been working on logging during unit tests... I 
> don't have an ideal solution at the moment because it is not possible to 
> programatically change the Commons Logging level /after/ the first Log 
> instance has been created by the LoggerFactoryImpl. This is a 
> combination of limitations in the way LoggerFactoryImpl processes the 
> sources of its Properties and a lack of flexibility in SimpleLogger.
>   
I would not worry too much the logging of errors is correct behavior and
the testing of error conditions is also correct therefore it is only in
the case of a test failure that the log is interesting.
> If I had more time and enthusiasm, I would start with some code I have 
> in another (private) project and do it properly. Perhaps later this year?
>
> I also had to convert the Picture class to use Commons Logging - it was 
> still explicitly using log4j. Once done, I discovered 4 test cases were 
> failing because they could not find a jpeg file to play with. I sorted 
> all that out.
>   
Good work.
> I wonder whether there are more classes still unconverted Commons Logging?
>   
Maybe?
>
> Anyway, the project builds and tests satisfactorily. I've deployed it to 
> my own server and it looks OK. Can you try it out too?
>   
Will do in due course as I use the head in my own website.
> Brian
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Ginp-developers mailing list
> Gin...@li...
> https://lists.sourceforge.net/lists/listinfo/ginp-developers
>